New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 876133 link

Starred by 1 user
Status: Fixed
Owner:
cblume@chromium.org
Closed: Aug 22
Cc:
█ fsam...@chromium.org
vmi...@chromium.org
ericrk@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

content/renderer OWNERS cannot approve their unit tests

Project Member Reported by cblume@chromium.org, Aug 20 
content/renderer/OWNERS has things like:
per-file foo.*=person

but this excludes foo_unittest.cc.

Should the lines instead look like:
per-file foo*=person
?

Or should we change it to look like:
per-file foo.*=person
per-file foo_unittest.cc=person
?

Comment 1 by fsam...@chromium.org, Aug 20 

I think foo.* should change to foo*, yes. That seems totally reasonable to me.

It would also capture foo_somethingelse.cc but I think that's usually OK?

E.g. render_widget* is render_widget_stuff.cc

Comment 3 by cblume@chromium.org, Aug 21 

Agreed with #1.
I took a look at a few other OWNERS files and saw the render_widget* pattern.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a11e54f768088622ecfe4265bfb3e00024481572

commit a11e54f768088622ecfe4265bfb3e00024481572
Author: Chris Blume <cblume@chromium.org>
Date: Wed Aug 22 19:06:06 2018

content/renderer OWNERS can now approve unit tests

content/renderer/OWNERS has things like:
per-file foo.*=person

But this exclused foo_unittest.cc.

This patch gives those owners the ability to also approve the unit tests
which cover their owned areas.

BUG= 876133 

Change-Id: Id34003749c63fd044716f31907f91a84c2c264cc
Reviewed-on: https://chromium-review.googlesource.com/1182609
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585191}
[modify] https://crrev.com/a11e54f768088622ecfe4265bfb3e00024481572/content/renderer/OWNERS

Comment 5 by cblume@chromium.org, Aug 22

Status: Fixed (was: Assigned)
►

Sign in to add a comment