New issue
Advanced search Search tips

Issue 876123 link

Starred by 1 user
Status: Fixed
Owner:
shaseley@google.com
Closed: Aug 23
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Move features::kStopInBackground to blink::features and remove from RuntimeEnabledFeatures

Project Member Reported by shaseley@google.com, Aug 20 
This accomplishes a few minor things:
1) As a blink runtime feature, kStopInBackground won't move past "test" since freezing on desktop will be initiated by the browser, so it's not clear this belongs here.

2) Removes *StopInBackground* methods, which are legacy names. We would ideally rename this to "freeze-in-background", but this would break user settings.

3) Moves kStopInBackground to the same location as kStopNonTimersInBackground.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8eefdcdd34bcfa6891f1486fe8417486ca87824d

commit 8eefdcdd34bcfa6891f1486fe8417486ca87824d
Author: Scott Haseley <shaseley@google.com>
Date: Wed Aug 22 16:50:19 2018

[scheduler] Move stop-in-background feature to blink::features and change availability to Android-only

Changing the availability to Android-only since freezing on desktop
is driven by the browser (TabManager), and this feature will conflict.
Moving this feature to blink::features to be consistent with other
scheduler features (kStopNonTimersInBackground), and since as a runtime
enabled feature it will not make it past "test" since it is only
available on Android.

Bug:  876123 
Change-Id: Ib83341504be4222da548bab2d6bb71375712bf52
Reviewed-on: https://chromium-review.googlesource.com/1182516
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Shubhie Panicker <panicker@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Scott Haseley <shaseley@google.com>
Cr-Commit-Position: refs/heads/master@{#585087}
[modify] https://crrev.com/8eefdcdd34bcfa6891f1486fe8417486ca87824d/chrome/browser/about_flags.cc
[modify] https://crrev.com/8eefdcdd34bcfa6891f1486fe8417486ca87824d/chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
[modify] https://crrev.com/8eefdcdd34bcfa6891f1486fe8417486ca87824d/content/child/runtime_features.cc
[modify] https://crrev.com/8eefdcdd34bcfa6891f1486fe8417486ca87824d/content/public/common/content_features.cc
[modify] https://crrev.com/8eefdcdd34bcfa6891f1486fe8417486ca87824d/content/public/common/content_features.h
[modify] https://crrev.com/8eefdcdd34bcfa6891f1486fe8417486ca87824d/third_party/blink/common/features.cc
[modify] https://crrev.com/8eefdcdd34bcfa6891f1486fe8417486ca87824d/third_party/blink/public/common/features.h
[modify] https://crrev.com/8eefdcdd34bcfa6891f1486fe8417486ca87824d/third_party/blink/public/platform/web_runtime_features.h
[modify] https://crrev.com/8eefdcdd34bcfa6891f1486fe8417486ca87824d/third_party/blink/renderer/platform/exported/web_runtime_features.cc
[modify] https://crrev.com/8eefdcdd34bcfa6891f1486fe8417486ca87824d/third_party/blink/renderer/platform/runtime_enabled_features.json5
[modify] https://crrev.com/8eefdcdd34bcfa6891f1486fe8417486ca87824d/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.cc
[modify] https://crrev.com/8eefdcdd34bcfa6891f1486fe8417486ca87824d/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl_unittest.cc

Comment 2 by shaseley@google.com, Aug 23

Status: Fixed (was: Started)
►

Sign in to add a comment