New issue
Advanced search Search tips

Issue 876115 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

mash: Remove accessibility autoclick mojo app

Project Member Reported by jamescook@chromium.org, Aug 20

Issue description

A couple years ago the mustash team in WAT ported the a11y autoclick feature to work as an out-of-process mojo app. It's similar to the way the keyboard shortcut viewer app works. It runs in its own process, opens a views::Widget to draw a circle around the cursor, and calls a one-off mojo API in our window service code to inject a click.

The idea was to demonstrate that a11y features could be a separate app. However, we never shipped this, as it was dependent on window service APIs that were only available when ash ran fully out-of-process.

We've recently shipped enough of the window service APIs that the autoclick app *could* be shipped. However, it isn't a priority for the mustash team -- we've got our hands full with keyboard shortcut viewer, out-of-process ash, and other stuff.

The autoclick code in ash is now kind of awkward -- it's split into multiple components, regular ash + mojo app + common code. It would be simpler to just keep the regular ash version and unfork it. If the a11y team in the future wanted to ship an a11y app they could copy the structure of either the tap_visualizer app or the keyboard shortcut viewer app, which the mustash team is supporting.

 
Cc: sadrul@chromium.org riajiang@chromium.org
CC sadrul/riajiang just FYI

I pinged dmazzoni and he's OK with removing this.

Lemme know if you feel strongly about keeping it and/or have plans to ship it.

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa6aaad888ee4619f709de684992cac9b5d69075

commit aa6aaad888ee4619f709de684992cac9b5d69075
Author: James Cook <jamescook@chromium.org>
Date: Fri Aug 24 01:00:06 2018

chromeos: Remove accessibility autoclick app

Neither the mustash team nor the accessibility team has any concrete
plans to ship this. We can always restore it if we change our minds.

This eliminates a couple IsAshInBrowserProcess() checks in //ash.

Bug:  876115 
Test: ash_unittests
Change-Id: I60928f52facc4a4d382dff2c4c373d967f203f0a
Reviewed-on: https://chromium-review.googlesource.com/1187563
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585679}
[modify] https://crrev.com/aa6aaad888ee4619f709de684992cac9b5d69075/ash/BUILD.gn
[modify] https://crrev.com/aa6aaad888ee4619f709de684992cac9b5d69075/ash/DEPS
[modify] https://crrev.com/aa6aaad888ee4619f709de684992cac9b5d69075/ash/accessibility/accessibility_controller.cc
[modify] https://crrev.com/aa6aaad888ee4619f709de684992cac9b5d69075/ash/accessibility/accessibility_controller.h
[modify] https://crrev.com/aa6aaad888ee4619f709de684992cac9b5d69075/ash/ash_strings.grd
[modify] https://crrev.com/aa6aaad888ee4619f709de684992cac9b5d69075/ash/autoclick/common/autoclick_controller_common.h
[delete] https://crrev.com/96aee2cc743453f555e6a233ec968a01bfd32d6f/ash/components/autoclick/BUILD.gn
[delete] https://crrev.com/96aee2cc743453f555e6a233ec968a01bfd32d6f/ash/components/autoclick/DEPS
[delete] https://crrev.com/96aee2cc743453f555e6a233ec968a01bfd32d6f/ash/components/autoclick/OWNERS
[delete] https://crrev.com/96aee2cc743453f555e6a233ec968a01bfd32d6f/ash/components/autoclick/autoclick_application.cc
[delete] https://crrev.com/96aee2cc743453f555e6a233ec968a01bfd32d6f/ash/components/autoclick/autoclick_application.h
[delete] https://crrev.com/96aee2cc743453f555e6a233ec968a01bfd32d6f/ash/components/autoclick/main.cc
[delete] https://crrev.com/96aee2cc743453f555e6a233ec968a01bfd32d6f/ash/components/autoclick/manifest.json
[delete] https://crrev.com/96aee2cc743453f555e6a233ec968a01bfd32d6f/ash/components/autoclick/public/mojom/BUILD.gn
[delete] https://crrev.com/96aee2cc743453f555e6a233ec968a01bfd32d6f/ash/components/autoclick/public/mojom/OWNERS
[delete] https://crrev.com/96aee2cc743453f555e6a233ec968a01bfd32d6f/ash/components/autoclick/public/mojom/autoclick.mojom
[modify] https://crrev.com/aa6aaad888ee4619f709de684992cac9b5d69075/ash/manifest.json
[modify] https://crrev.com/aa6aaad888ee4619f709de684992cac9b5d69075/ash/shell.cc
[modify] https://crrev.com/aa6aaad888ee4619f709de684992cac9b5d69075/chrome/app/BUILD.gn
[modify] https://crrev.com/aa6aaad888ee4619f709de684992cac9b5d69075/chrome/browser/ash_service_registry.cc
[modify] https://crrev.com/aa6aaad888ee4619f709de684992cac9b5d69075/chrome/browser/chrome_content_browser_manifest_overlay.json
[modify] https://crrev.com/aa6aaad888ee4619f709de684992cac9b5d69075/chrome/utility/BUILD.gn
[modify] https://crrev.com/aa6aaad888ee4619f709de684992cac9b5d69075/chrome/utility/DEPS
[modify] https://crrev.com/aa6aaad888ee4619f709de684992cac9b5d69075/chrome/utility/mash_service_factory.cc
[modify] https://crrev.com/aa6aaad888ee4619f709de684992cac9b5d69075/mash/BUILD.gn

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab4edf57b30fb35918238e36aa7da15832a72429

commit ab4edf57b30fb35918238e36aa7da15832a72429
Author: Katie D <katie@chromium.org>
Date: Fri Oct 12 16:53:55 2018

Refactor AutoclickControllerCommon into AutoclickController.

This cleans up Autoclick code, resolving a TODO, by refactoring
AutoclickControllerCommon into AutoclickController and eliminating
the need for the delegate. Also makes AutoclickController into
a concrete class, removing the need for AutoclickControllerImpl
and improving readability.

Bug:  876115 
Change-Id: Id38917adc38aafcb4f4602e8827f0ad43d1f1dba
Reviewed-on: https://chromium-review.googlesource.com/c/1277961
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599251}
[modify] https://crrev.com/ab4edf57b30fb35918238e36aa7da15832a72429/ash/autoclick/autoclick_controller.cc
[modify] https://crrev.com/ab4edf57b30fb35918238e36aa7da15832a72429/ash/autoclick/autoclick_controller.h
[modify] https://crrev.com/ab4edf57b30fb35918238e36aa7da15832a72429/ash/autoclick/common/BUILD.gn
[delete] https://crrev.com/77e3a8b37b2c6c164f8569ff366c8ccf48bd5a5f/ash/autoclick/common/autoclick_controller_common.cc
[delete] https://crrev.com/77e3a8b37b2c6c164f8569ff366c8ccf48bd5a5f/ash/autoclick/common/autoclick_controller_common.h
[delete] https://crrev.com/77e3a8b37b2c6c164f8569ff366c8ccf48bd5a5f/ash/autoclick/common/autoclick_controller_common_delegate.h
[modify] https://crrev.com/ab4edf57b30fb35918238e36aa7da15832a72429/ash/shell.cc

Sign in to add a comment