New issue
Advanced search Search tips

Issue 876113 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 22
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Scaling artifacts on Chrome icon in Launcher

Project Member Reported by kaznacheev@chromium.org, Aug 20

Issue description

Chrome Version: 70.0.3529.0
OS: Chrome

What steps will reproduce the problem?
(1) Open Launcher
(2) Observe the Chrome icon

What is the expected result?
Edges should be smooth

What happens instead?
On some zoom levels the icon edges are jagged



Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f44299c2123609f028752778b6a50f68eb7cc5a4

commit f44299c2123609f028752778b6a50f68eb7cc5a4
Author: Vladislav Kaznacheev <kaznacheev@google.com>
Date: Wed Aug 22 17:58:43 2018

Scale Launcher icons for extension correctly

Use the same icon size as for other app types
(app_list::AppListConfig::instance().grid_icon_dimension())
to avoid unnecessary repetitive scaling.

Bug:  876113 
Test: manual, steps in the bug
Change-Id: Ib5e260263f874f0067c3276293a7c2dc917c775a
Reviewed-on: https://chromium-review.googlesource.com/1182454
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585156}
[modify] https://crrev.com/f44299c2123609f028752778b6a50f68eb7cc5a4/chrome/browser/extensions/chrome_app_icon_unittest.cc
[modify] https://crrev.com/f44299c2123609f028752778b6a50f68eb7cc5a4/chrome/browser/ui/app_list/extension_app_item.cc
[modify] https://crrev.com/f44299c2123609f028752778b6a50f68eb7cc5a4/chrome/browser/ui/app_list/extension_app_model_builder.cc

Status: Fixed (was: Assigned)

Sign in to add a comment