New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 876111 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

"Use the same proxy for all protocols" toggle does not reflect the correct status.

Project Member Reported by aashuto...@chromium.org, Aug 20

Issue description

Chrome Version: <From about:version: Google Chrome 68.0.3440.118>
Chrome OS Version: <From about:version: Platform 10718.0.0.>
Chrome OS Platform: <Hana/Kevin>
<b>Network info: <network, encryption type, router model (if known)></b>

Please specify Cr-* of the system to which this bug/feature applies (add
the label below).

Steps To Reproduce:
(1) Click on the connected network and go to proxy settings
(2) Change it to the Manual proxy configuration.
(3) Turn off the "use the same proxy for all protocols" toggle.
(4) Fill in host and port details for Http proxy and click save

Expected Result:
The "use the same proxy for all protocols" should be off. 
Actual Result:
"use the same proxy for all protocols" toggles on

chrome://net-internals/#proxy - Shows correct results i.e. proxy settings only for HTTP protocol. 

Note: All other protocols should be left as default. If we change hostname or port number for other protocol, we do not see this issue. 
How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)

What is the impact to the user, and is there a workaround? If so, what is
it?
Corner case but the user is not shown the correct configuration. 

Please provide any additional information below. Attach a screenshot or
log if possible.

For graphics-related bugs, please copy/paste the contents of the about gpu
page at the end of this report.
https://listnr.corp.google.com/report/85612469235

Will update, if similar issue is seen on M69 and M70
 
Labels: -M-68 M-70
Owner: steve...@chromium.org
Status: Assigned (was: Untriaged)
Probably not urgent enough to fix for 68 or even 69. Please confirm that this affects 70.

Status: Started (was: Assigned)
The functionality is correct (only http is set to proxy), it's just the toggle that is incorrect.

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fad8c5b09869cba0f2a966f713c9fb45fe99145

commit 8fad8c5b09869cba0f2a966f713c9fb45fe99145
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Sep 07 21:10:05 2018

Network Settings proxy: Fix 'use same' toggle logic

Bug:  876111 
Change-Id: I8338c42e716142c4280336ea223205941002c6bf
Reviewed-on: https://chromium-review.googlesource.com/1185724
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589645}
[modify] https://crrev.com/8fad8c5b09869cba0f2a966f713c9fb45fe99145/ui/webui/resources/cr_components/chromeos/network/network_proxy.js

Labels: -M-70 M-71
Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Nocturne 11151.9.0

Sign in to add a comment