New issue
Advanced search Search tips

Issue 876110 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocked on:
issue 678391



Sign in to add a comment

Migrate HostCache code in net_internals_ui.cc to network service

Project Member Reported by ericorth@chromium.org, Aug 20

Issue description

net-internals includes code for clearing HostCache.  Won't be very effective unless we use the mojo API to clear the cache in the network service.
 
Blocking: 678391
Labels: Hotlist-KnownIssue
Clearing the cache is straightforward to support as we already expose it on mojom::NetworkContext.

Whereas enumerating the cache seems like something we can drop from net-internals.
Labels: -Hotlist-KnownIssue
Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Status: Available (was: Untriaged)
Labels: Proj-Servicification-Stable
Labels: Hotlist-KnownIssue
Owner: cmumford@chromium.org
Status: Started (was: Available)
ericorth@ Looking at net_internals_ui.cc it still does quite a bit of direct access to the net::URLRequestContext and other classes from //net that hit the wire. Specifically:

* net::TransportSecurityState access.
* net::ProxyResolutionService access.
* net::HttpNetworkSession access
* NetInternalsMessageHandler::IOThreadImpl::OnExpectCTTestReport directly instantiates network::ExpectCTReporter passing it a URLNetworkContext.

I believe these all need to be moved to network service calls and wanted to check with you to see if 1) I am correct, and 2) should I do it as part of this issue, or are there other issues - and maybe people working them?
1) I believe so.  Pretty much any access into //net (except basic stuff like enums/constants) needs to be migrated or deprecated.

2) I created this issue specific to the HostCache access because that was what I was looking into.  Unknown if other issues exist for the other references because I have not looked into it.  If you can't find any, I have no objections to generalizing this issue to cover the other stuff.
Great. Will convert the entire file. Thx ericorth@.
Up for review: https://crrev.com/c/1228235
Blockedon: 678391
Blocking: -678391
The review is proceeding, but the netlog functionality is in the process of being moved from chrome://net-internals to chrome://net-export as part of  issue 678391 . That CL is up for review at https://crrev.com/c/1228483. Once it lands I'll remove the netlogging from this bugs CL (https://crrev.com/c/1228235) and continue with the review.
CL rebased and continuing with the review: https://crrev.com/c/1228235.
Project Member

Comment 17 by bugdroid1@chromium.org, Oct 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311

commit f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311
Author: Chris Mumford <cmumford@google.com>
Date: Fri Oct 26 17:37:02 2018

Switch chrome://net-internals to the network service.

This change switches the implementation of the net-internals
page from direct calls to //net to the network service.

Bug:  876110 , 824974 , 755600 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Icf3b31d339084885761cb78c0bc929df92ee6781
Reviewed-on: https://chromium-review.googlesource.com/c/1228235
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603135}
[modify] https://crrev.com/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311/chrome/browser/password_manager/password_manager_test_base.cc
[modify] https://crrev.com/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311/chrome/browser/ssl/ssl_browsertest.cc
[modify] https://crrev.com/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311/chrome/browser/ui/webui/net_internals/net_internals_ui.cc
[modify] https://crrev.com/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311/components/password_manager/core/browser/http_credentials_cleaner_unittest.cc
[modify] https://crrev.com/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311/services/network/expect_ct_reporter.h
[modify] https://crrev.com/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311/services/network/network_context.cc
[modify] https://crrev.com/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311/services/network/network_context.h
[modify] https://crrev.com/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311/services/network/network_context_unittest.cc
[modify] https://crrev.com/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311/services/network/public/mojom/network_context.mojom
[modify] https://crrev.com/f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311/services/network/test/test_network_context.h

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/ce5a5595246180b8e9c99eaceadcf5518eaa41a6

Commit: ce5a5595246180b8e9c99eaceadcf5518eaa41a6
Author: cmumford@google.com
Commiter: cmumford@chromium.org
Date: 2018-11-04 14:53:39 +0000 UTC

Switch chrome://net-internals to the network service.

Merge to release branch.

This change switches the implementation of the net-internals
page from direct calls to //net to the network service.

TBRing mmenke@ for review of network service_context changes.

TBR=mmenke@chromium.org

(cherry picked from commit f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311)

Bug:  876110 , 824974 , 755600 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Icf3b31d339084885761cb78c0bc929df92ee6781
Reviewed-on: https://chromium-review.googlesource.com/c/1228235
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#603135}
Reviewed-on: https://chromium-review.googlesource.com/c/1316652
Reviewed-by: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#488}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Project Member

Comment 19 by bugdroid1@chromium.org, Nov 4

Labels: merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce5a5595246180b8e9c99eaceadcf5518eaa41a6

commit ce5a5595246180b8e9c99eaceadcf5518eaa41a6
Author: Chris Mumford <cmumford@google.com>
Date: Sun Nov 04 14:53:39 2018

Switch chrome://net-internals to the network service.

Merge to release branch.

This change switches the implementation of the net-internals
page from direct calls to //net to the network service.

TBRing mmenke@ for review of network service_context changes.

TBR=mmenke@chromium.org

(cherry picked from commit f24ce75bb57f0c1648a57f4cb5e7c5bf4db61311)

Bug:  876110 , 824974 , 755600 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Icf3b31d339084885761cb78c0bc929df92ee6781
Reviewed-on: https://chromium-review.googlesource.com/c/1228235
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#603135}
Reviewed-on: https://chromium-review.googlesource.com/c/1316652
Reviewed-by: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#488}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/ce5a5595246180b8e9c99eaceadcf5518eaa41a6/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/ce5a5595246180b8e9c99eaceadcf5518eaa41a6/chrome/browser/password_manager/password_manager_test_base.cc
[modify] https://crrev.com/ce5a5595246180b8e9c99eaceadcf5518eaa41a6/chrome/browser/ssl/ssl_browsertest.cc
[modify] https://crrev.com/ce5a5595246180b8e9c99eaceadcf5518eaa41a6/chrome/browser/ui/webui/net_internals/net_internals_ui.cc
[modify] https://crrev.com/ce5a5595246180b8e9c99eaceadcf5518eaa41a6/components/password_manager/core/browser/http_credentials_cleaner_unittest.cc
[modify] https://crrev.com/ce5a5595246180b8e9c99eaceadcf5518eaa41a6/services/network/expect_ct_reporter.h
[modify] https://crrev.com/ce5a5595246180b8e9c99eaceadcf5518eaa41a6/services/network/network_context.cc
[modify] https://crrev.com/ce5a5595246180b8e9c99eaceadcf5518eaa41a6/services/network/network_context.h
[modify] https://crrev.com/ce5a5595246180b8e9c99eaceadcf5518eaa41a6/services/network/network_context_unittest.cc
[modify] https://crrev.com/ce5a5595246180b8e9c99eaceadcf5518eaa41a6/services/network/public/mojom/network_context.mojom
[modify] https://crrev.com/ce5a5595246180b8e9c99eaceadcf5518eaa41a6/services/network/test/test_network_context.h

is this fixed?

Status: Fixed (was: Started)

Sign in to add a comment