New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 876107 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

chell-, daisy-, falco-, glados-, ranier-paladin: No room left in the flash

Project Member Reported by akhouderchah@chromium.org, Aug 20

Issue description

Sample failed build:
https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8937645126851435584

During the UnitTest stage on paladins for chell, daisy, falco, glados, ranier we get:

chromeos-ec-0.0.1-r5043: /usr/x86_64-pc-linux-gnu/arm-none-eabi/binutils-bin/2.27.0/ld.bfd.real: build/servo_v4/RO/ec.RO.elf section `.rodata' will not fit in region `FLASH'
chromeos-ec-0.0.1-r5043: /usr/x86_64-pc-linux-gnu/arm-none-eabi/binutils-bin/2.27.0/ld.bfd.real: No room left in the flash
chromeos-ec-0.0.1-r5043: /usr/x86_64-pc-linux-gnu/arm-none-eabi/binutils-bin/2.27.0/ld.bfd.real: region `FLASH' overflowed by 160 bytes
chromeos-ec-0.0.1-r5043: collect2: error: ld returned 1 exit status
chromeos-ec-0.0.1-r5043: make[2]: *** [Makefile.rules:407: build/servo_v4/RO/ec.RO.elf] Error 1
chromeos-ec-0.0.1-r5043: make[1]: *** [Makefile.rules:198: proj-servo_v4] Error 2


Eventually, the stage fails with:

cros_run_unit_tests: Unhandled exception:
Traceback (most recent call last):
  File "/mnt/host/source/chromite/bin/cros_run_unit_tests", line 169, in <module>
    DoMain()
  File "/mnt/host/source/chromite/bin/cros_run_unit_tests", line 165, in DoMain
    commandline.ScriptWrapperMain(FindTarget)
  File "/mnt/host/source/chromite/lib/commandline.py", line 912, in ScriptWrapperMain
    ret = target(argv[1:])
  File "/mnt/host/source/chromite/scripts/cros_run_unit_tests.py", line 103, in main
    jobs=min(10, multiprocessing.cpu_count()))
  File "/mnt/host/source/chromite/lib/chroot_util.py", line 177, in RunUnittests
    cros_build_lib.SudoRunCommand(command, extra_env=env, mute_output=False)
  File "/mnt/host/source/chromite/lib/cros_build_lib.py", line 322, in SudoRunCommand
    return RunCommand(sudo_cmd, **kwargs)
  File "/mnt/host/source/chromite/lib/cros_build_lib.py", line 647, in RunCommand
    raise RunCommandError(msg, cmd_result)
chromite.lib.cros_build_lib.RunCommandError: return code: 1; command: sudo 'PARALLEL_EMERGE_STATUS_FILE=/tmp/tmpRrZ3uo' 'FEATURES=test' 'PKGDIR=/build/falco/test-packages' -- /mnt/host/source/chromite/bin/parallel_emerge '--sysroot=/build/falco' '--jobs=10' sys-apps/rootdev chromeos-base/oobe_config chromeos-base/drivefs chromeos-base/libbrillo chromeos-base/vboot_reference chromeos-base/p2p chromeos-base/chaps chromeos-base/lorgnette chromeos-base/ippusb_manager chromeos-base/easy-unlock chromeos-base/google-breakpad chromeos-base/minijail chromeos-base/permission_broker chromeos-base/chromeos-config-tools chromeos-base/chromeos-ec chromeos-base/authpolicy net-misc/modemmanager-next chromeos-base/chromeos-login chromeos-base/vpn-manager chromeos-base/chromeos-trim chromeos-base/cryptohome chromeos-base/chromeos-init chromeos-base/bootstat chromeos-base/chromeos-installer chromeos-base/disk_updater sys-apps/flashmap chromeos-base/libcontainer dev-util/puffin dev-util/hdctools net-wireless/bluez chromeos-base/libchromeos-ui chromeos-base/imageloader chromeos-base/quipper media-sound/adhd chromeos-base/vpd chromeos-base/easy-unlock-crypto net-libs/libmbim chromeos-base/chromite chromeos-base/smbprovider chromeos-base/bluetooth chromeos-base/gestures chromeos-base/newblue chromeos-base/debugd chromeos-base/power_manager chromeos-base/autotest chromeos-base/libpasswordprovider chromeos-base/mist chromeos-base/crash-reporter dev-util/bsdiff chromeos-base/shill chromeos-base/factory_installer chromeos-base/chromeos-storage-info chromeos-base/memd chromeos-base/chromeos-imageburner chromeos-base/mtpd chromeos-base/metrics chromeos-base/ci-results-archiver chromeos-base/toolchain-tests chromeos-base/crosh chromeos-base/cros-disks chromeos-base/update_engine
cmd=['sudo', 'PARALLEL_EMERGE_STATUS_FILE=/tmp/tmpRrZ3uo', 'FEATURES=test', 'PKGDIR=/build/falco/test-packages', '--', '/mnt/host/source/chromite/bin/parallel_emerge', '--sysroot=/build/falco', '--jobs=10', 'sys-apps/rootdev', 'chromeos-base/oobe_config', 'chromeos-base/drivefs', 'chromeos-base/libbrillo', 'chromeos-base/vboot_reference', 'chromeos-base/p2p', 'chromeos-base/chaps', 'chromeos-base/lorgnette', 'chromeos-base/ippusb_manager', 'chromeos-base/easy-unlock', 'chromeos-base/google-breakpad', 'chromeos-base/minijail', 'chromeos-base/permission_broker', 'chromeos-base/chromeos-config-tools', 'chromeos-base/chromeos-ec', 'chromeos-base/authpolicy', 'net-misc/modemmanager-next', 'chromeos-base/chromeos-login', 'chromeos-base/vpn-manager', 'chromeos-base/chromeos-trim', 'chromeos-base/cryptohome', 'chromeos-base/chromeos-init', 'chromeos-base/bootstat', 'chromeos-base/chromeos-installer', 'chromeos-base/disk_updater', 'sys-apps/flashmap', 'chromeos-base/libcontainer', 'dev-util/puffin', 'dev-util/hdctools', 'net-wireless/bluez', 'chromeos-base/libchromeos-ui', 'chromeos-base/imageloader', 'chromeos-base/quipper', 'media-sound/adhd', 'chromeos-base/vpd', 'chromeos-base/easy-unlock-crypto', 'net-libs/libmbim', 'chromeos-base/chromite', 'chromeos-base/smbprovider', 'chromeos-base/bluetooth', 'chromeos-base/gestures', 'chromeos-base/newblue', 'chromeos-base/debugd', 'chromeos-base/power_manager', 'chromeos-base/autotest', 'chromeos-base/libpasswordprovider', 'chromeos-base/mist', 'chromeos-base/crash-reporter', 'dev-util/bsdiff', 'chromeos-base/shill', 'chromeos-base/factory_installer', 'chromeos-base/chromeos-storage-info', 'chromeos-base/memd', 'chromeos-base/chromeos-imageburner', 'chromeos-base/mtpd', 'chromeos-base/metrics', 'chromeos-base/ci-results-archiver', 'chromeos-base/toolchain-tests', 'chromeos-base/crosh', 'chromeos-base/cros-disks', 'chromeos-base/update_engine']
14:40:44: ERROR: 
return code: 1; command: /b/c/cbuild/repository/chromite/bin/cros_sdk 'USE=chrome_internal' 'PARALLEL_EMERGE_STATUS_FILE=/tmp/tmpRrZ3uo' -- /mnt/host/source/chromite/bin/cros_run_unit_tests '--board=falco'
cmd=['/b/c/cbuild/repository/chromite/bin/cros_sdk', u'USE=chrome_internal', 'PARALLEL_EMERGE_STATUS_FILE=/tmp/tmpRrZ3uo', '--', '/mnt/host/source/chromite/bin/cros_run_unit_tests', u'--board=falco'], cwd=/b/c/cbuild/repository, extra env={'USE': u'chrome_internal', 'PARALLEL_EMERGE_STATUS_FILE': '/tmp/tmpRrZ3uo'}
14:40:44: ERROR: Packages failed in /mnt/host/source/chromite/bin/cros_run_unit_tests: chromeos-base/chromeos-ec
 
Cc: dnojiri@chromium.org
After doing a git bisect, the EC change that broke this is https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1217607.

Sending out a revert now
Components: OS>Firmware>EC
Any idea how this CL made it through CQ?
Re#4: The usual reason is that CQ only builds a subset of boards, and the breakage isn't in that subset.
https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1239239.

With the patch above, we have 384 bytes left for glados before another unlucky patch hits the limit.
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/a8f584712935fd1ba1002a8ec43901f4c5593e5b

commit a8f584712935fd1ba1002a8ec43901f4c5593e5b
Author: Daisuke Nojiri <dnojiri@chromium.org>
Date: Sat Sep 22 02:50:17 2018

glados: Remove battfake command from RO

This CL removes battfake console command from RO to fix space issue.

BUG= chromium:876107 
BRANCH=none
TEST=buildall

Change-Id: Ib07c8729318424af3af7b46bdd1f9e5ea59580a8
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1239239
Reviewed-by: Jett Rink <jettrink@chromium.org>

[modify] https://crrev.com/a8f584712935fd1ba1002a8ec43901f4c5593e5b/board/glados/board.h

Owner: dnojiri@chromium.org
Status: Started (was: Untriaged)
Can we mark this as fixed? Is this on TOT? In that case we should remove the firmware from building for these boards.
As of today, we have:

Tightest boards' RW flash images, bytes free:
atlas_ish : -63264
minimuffin:   1060
zinger    :   1068

Tightest boards' RW RAM images, bytes free:
chell_pd  :    224
glados_pd :    224
oak_pd    :    224
Status: Fixed (was: Started)

Sign in to add a comment