New issue
Advanced search Search tips

Issue 876090 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Cleanup Material Refresh and MacViews Variations Checks

Project Member Reported by robliao@chromium.org, Aug 20

Issue description

Remove Variations Checks for GM2 and MacViews including but not limited to feature flags, functions checking feature flags, fieldtrial_testing_config.json configurations, etc.
 
Labels: -Target-70 -M-70 Target-71 M-71
Summary: Cleanup Material Refresh and MacViews Variations Checks (was: Cleanup GM2 and MacViews Variations Checks)
Components: UI>Browser
Labels: Proj-MdRefresh
Labels: Group-Feature_Process
Labels: -Proj-MdRefresh Proj-DesktopUI
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/144854454b206cbe9c191e51b905c1d6bf01e72e

commit 144854454b206cbe9c191e51b905c1d6bf01e72e
Author: Robert Liao <robliao@chromium.org>
Date: Thu Sep 20 21:22:12 2018

Remove Field Trial Support for Material Refresh

Material refresh is now on by default.

BUG= 876090 

Change-Id: I308da4d0ed5a4df6dc7104a573ed9063151caab0
Reviewed-on: https://chromium-review.googlesource.com/1229175
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592947}
[modify] https://crrev.com/144854454b206cbe9c191e51b905c1d6bf01e72e/ui/base/material_design/material_design_controller.cc

Labels: Hotlist-DesktopUITriaged
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d4fbfe0ee8049fce3d083866cc067c5b2ef2016

commit 1d4fbfe0ee8049fce3d083866cc067c5b2ef2016
Author: Robert Liao <robliao@chromium.org>
Date: Wed Oct 03 20:56:18 2018

Remove ViewsBrowserWindows from fieldtrial_testing_config.json

No code checks for this feature or experiment anymore.

BUG= 876090 

Change-Id: I3b190857043ea067e28842458d2343a08c9d3920
Reviewed-on: https://chromium-review.googlesource.com/c/1255893
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596353}
[modify] https://crrev.com/1d4fbfe0ee8049fce3d083866cc067c5b2ef2016/testing/variations/fieldtrial_testing_config.json

Status: Fixed (was: Assigned)
There is no more production code based work for this.

Sign in to add a comment