New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 876082 link

Starred by 1 user
Status: Fixed
Owner:
benjhayden@chromium.org
Closed: Aug 22
Cc:
simonhatch@chromium.org
█ eakuefner@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove models/histogram.py:SparseDiagnostic.GetMostRecentValuesByNames{,Async}

Project Member Reported by benjhayden@chromium.org, Aug 20 
These staticmethods assume that the diagnostics are GenericSets, so they don't support TagMaps. GetMostRecentValuesByNamesAsync is only called in find_anomalies, and GetMostRecentValuesByNames is not called anywhere. This CL generalized them to GetMostRecentDataByNamesAsync in order to support TagMaps:
https://chromium-review.googlesource.com/c/catapult/+/1176597
find_anomalies should call that and then data.get('values').
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/e15893bf0fb0042cfd4365b588ba46cce8e41bac

commit e15893bf0fb0042cfd4365b588ba46cce8e41bac
Author: benshayden <benjhayden@chromium.org>
Date: Wed Aug 22 22:45:41 2018

Remove SparseDiagnostic.GetMostRecentValuesByNames.

This method is replaced by GetMostRecentDataByNames{Sync,Async},
which supports all types of Diagnostics instead of just GenericSet.

Bug:  chromium:876082 
Change-Id: Ibdb22125766ba5994fad9831eefcc6e645ec9d39
Reviewed-on: https://chromium-review.googlesource.com/1185732
Reviewed-by: Simon Hatch <simonhatch@chromium.org>
Commit-Queue: Ben Hayden <benjhayden@chromium.org>

[modify] https://crrev.com/e15893bf0fb0042cfd4365b588ba46cce8e41bac/dashboard/dashboard/models/histogram_test.py
[modify] https://crrev.com/e15893bf0fb0042cfd4365b588ba46cce8e41bac/dashboard/dashboard/find_anomalies.py
[modify] https://crrev.com/e15893bf0fb0042cfd4365b588ba46cce8e41bac/dashboard/dashboard/models/histogram.py

Comment 2 by benjhayden@chromium.org, Aug 22

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c35cb7b095f3b20318cf38aa5ff0f035dd6f488e

commit c35cb7b095f3b20318cf38aa5ff0f035dd6f488e
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Aug 23 03:20:32 2018

Roll src/third_party/catapult c67a80df2679..d95dde6e066f (5 commits)

https://chromium.googlesource.com/catapult.git/+log/c67a80df2679..d95dde6e066f


git log c67a80df2679..d95dde6e066f --date=short --no-merges --format='%ad %ae %s'
2018-08-23 simonhatch@chromium.org Dashboard - List out docs for alerts.
2018-08-22 benjhayden@chromium.org Remove SparseDiagnostic.GetMostRecentValuesByNames.
2018-08-22 simonhatch@chromium.org Pinpoint - Include doc link in bug comment.
2018-08-22 benjhayden@chromium.org Set default_expiration: 20h in v2spa.yaml.
2018-08-22 benjhayden@chromium.org Allow passing custom version to deploy_v2spa.


Created with:
  gclient setdep -r src/third_party/catapult@d95dde6e066f

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:863861 , chromium:876082 , chromium:863861 
TBR=sullivan@chromium.org

Change-Id: Ib326be155ae9fb40b064de9512abbef02e4a23a7
Reviewed-on: https://chromium-review.googlesource.com/1185691
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#585384}
[modify] https://crrev.com/c35cb7b095f3b20318cf38aa5ff0f035dd6f488e/DEPS
►

Sign in to add a comment