New issue
Advanced search Search tips

Issue 876077 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Add DCHECK and UKM for last committed URL mismatch in Slim and Legacy navigation managers

Project Member Reported by eugene...@chromium.org, Aug 20

Issue description

Having DCHECK and UMA may allow to understand if Slim Navigation manager has more URL spoofing bugs. More details can be found here: https://docs.google.com/document/d/176QSjYkcZeTBWTmL_aLI1HLA6JE9w-7sW_1dRpC_QhE/edit?ts=5b63c438#heading=h.k6xaxe8kttig
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d07a4a173711822c89059dea4b3557964583976a

commit d07a4a173711822c89059dea4b3557964583976a
Author: Eugene But <eugenebut@google.com>
Date: Tue Aug 21 14:53:15 2018

Add NavigationContextImpl::IsLoadingHtml.

This boolean will be true for loadHTMLString: navigations.

-[CRWWebController setDocumentURL:] will have a DCHECK when new document
URL does not match last committed URL in WKBasedNavigationManager. This
DCHECK will help to diagnose possible URL spoofing bugs in Slim
Navigation feature.

For loadHTMLString: the URLs will not match, which is not a problem
because loadHTMLString: are only used in tests and error pages.

Bug:  876077 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iae163faf7f5cf90d5bb0e48a191786be2e1d8ee6
Reviewed-on: https://chromium-review.googlesource.com/1182313
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584740}
[modify] https://crrev.com/d07a4a173711822c89059dea4b3557964583976a/ios/web/web_state/navigation_context_impl.h
[modify] https://crrev.com/d07a4a173711822c89059dea4b3557964583976a/ios/web/web_state/navigation_context_impl.mm
[modify] https://crrev.com/d07a4a173711822c89059dea4b3557964583976a/ios/web/web_state/ui/crw_web_controller.mm

Summary: Add DCHECK and UKM for last committed URL mismatch in Slim and Legacy navigation managers (was: Add DCHECK and UMA for last committed URL mismatch in Slim and Legacy navigation managers)
UKM collection doc:
https://docs.google.com/document/d/14SygQ8BzLkzedTLuDfOHhakQHZOOJSU8TAJT3rxBGv4/edit#
Status: Fixed (was: Started)

Sign in to add a comment