New issue
Advanced search Search tips

Issue 876064 link

Starred by 1 user
Status: Fixed
Owner:
masonfreed@chromium.org
Closed: Aug 23
Cc:
vmp...@chromium.org
schenney@chromium.org
chrishtr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 875963



Sign in to add a comment

Implement selection rects for display compositor pixel dumps

Project Member Reported by vmp...@chromium.org, Aug 20 
In layout tests using display compositor pixel dumps, we're missing, among other things, selection rects. This bug tracks implementing this feature.

See:
https://chromium-review.googlesource.com/c/chromium/src/+/1075891/3

Layout test failures:
 editing/selection
 paint/invalidation/svg/text-selection-text-05-t.svg
 svg/text/

seem to be selection rects missing.

Comment 1 by vmp...@chromium.org, Aug 20

Blocking: 875963

Comment 2 by vmp...@chromium.org, Aug 20

Cc: schenney@chromium.org

Comment 3 by masonfreed@chromium.org, Aug 23

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75453eca5b9805945dde7a1e73d5f2c445027297

commit 75453eca5b9805945dde7a1e73d5f2c445027297
Author: Mason Freed <masonfreed@chromium.org>
Date: Mon Aug 27 17:11:23 2018

[CI] Implement selection rects for display compositor pixel dumps

This patch implements selection rects on the renderer side for display
compositor pixel dumps (when using OOPIF).

Bug:  875963 ,  876064 
Change-Id: Ie1bc94d94dd290fce13198c63ce3ae8f3fd4b6bd
Reviewed-on: https://chromium-review.googlesource.com/1185915
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586291}
[modify] https://crrev.com/75453eca5b9805945dde7a1e73d5f2c445027297/content/shell/BUILD.gn
[modify] https://crrev.com/75453eca5b9805945dde7a1e73d5f2c445027297/content/shell/browser/layout_test/blink_test_controller.cc
[modify] https://crrev.com/75453eca5b9805945dde7a1e73d5f2c445027297/content/shell/common/layout_test.mojom
[add] https://crrev.com/75453eca5b9805945dde7a1e73d5f2c445027297/content/shell/common/layout_test/layout_test_utils.cc
[add] https://crrev.com/75453eca5b9805945dde7a1e73d5f2c445027297/content/shell/common/layout_test/layout_test_utils.h
[modify] https://crrev.com/75453eca5b9805945dde7a1e73d5f2c445027297/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/75453eca5b9805945dde7a1e73d5f2c445027297/content/shell/test_runner/BUILD.gn
[modify] https://crrev.com/75453eca5b9805945dde7a1e73d5f2c445027297/content/shell/test_runner/pixel_dump.cc
[modify] https://crrev.com/75453eca5b9805945dde7a1e73d5f2c445027297/content/shell/test_runner/test_runner.cc
[modify] https://crrev.com/75453eca5b9805945dde7a1e73d5f2c445027297/content/shell/test_runner/test_runner.h
[modify] https://crrev.com/75453eca5b9805945dde7a1e73d5f2c445027297/content/shell/test_runner/web_test_runner.h
[modify] https://crrev.com/75453eca5b9805945dde7a1e73d5f2c445027297/third_party/blink/renderer/core/frame/web_local_frame_impl.cc
►

Sign in to add a comment