New issue
Advanced search Search tips

Issue 876052 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 29
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 497851



Sign in to add a comment

[css-scroll-snap] Failures of programmatic snap wpt tests

Project Member Reported by sunyunjia@chromium.org, Aug 20

Issue description

CSSScrollSnap is to be shipped in M69. However, the wpt test scrollTo-scrollBy-snaps.html still fail in some cases. I investigated it a bit and suspect this is caused by the testharness wpt tests running on the server don't really have a fixed size. This causes the snap areas overflow the snapport, which we have no control of. So they won't snap as we expect either.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a719ba0bc7539c5be57b1fd1b40984a6447360b5

commit a719ba0bc7539c5be57b1fd1b40984a6447360b5
Author: Sandra Sun <sunyunjia@chromium.org>
Date: Fri Aug 24 18:53:02 2018

Avoid overflowing snap areas in scrollTo wpt tests

Some tests in scrollTo-scrollBy-snaps.html are failing on wpt dashboard.
This is caused by the uncertainty of the window size for testharness
tests. If the window size becomes small enough that the snap area covers
the snapport, the expected snap position is ignored because any scroll
position is considered a valid snap position. This patch changes the
landing position of scrollTo and scrollBy for failing cases so that the
snap area does not cover ths snapport regardless of the window size.

More specifically, the snap area's vertical and horizontal dimensions
are 600px each thus covering the [1000, 1600] range with expected snap
position at 1000. Previously if the test vertically scrolled to 1200 and
the window's size is smaller than 400, the snap area will cover the
window. Now the test scrolls to 900 (100px before the snap position),
ensuring that the target snap area won't cover the window regardless of
the size.

Bug:  876052 
Change-Id: I448ecb1e3cc2cc458d467472ca38d49bf01d2901
Reviewed-on: https://chromium-review.googlesource.com/1182299
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585926}
[modify] https://crrev.com/a719ba0bc7539c5be57b1fd1b40984a6447360b5/third_party/WebKit/LayoutTests/external/wpt/css/css-scroll-snap/scrollTo-scrollBy-snaps.html

Status: Fixed (was: Started)

Sign in to add a comment