New issue
Advanced search Search tips

Issue 876014 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

[CRD iOS] Improve iPhone X viewport manipulation

Project Member Reported by yuweih@chromium.org, Aug 20

Issue description

Currently we simply restrict the size of the desktop view to the safe area (unobstructed by the notch), so user cannot see through the part of the unsafe area that is not blocked by the notch. We should fix the viewport manipulation logic on iOS so that we always use the safe area to determine minimum zoom level and position while user can still see desktop in unsafe area when zooming, similar to what we do on Android client.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/817178cd5c2013075965e0602b8b0d564f7ccbe8

commit 817178cd5c2013075965e0602b8b0d564f7ccbe8
Author: Yuwei Huang <yuweih@chromium.org>
Date: Fri Aug 24 00:04:29 2018

[CRD iOS] Improve viewport manipulation on iPhone X

This CL allows the iOS client to display desktop that is partially
obstructed by the notch while allowing user to pan the desktop out of
the obstructed area, similar to what we have done on the Android
client.

This CL also changes the previous logic that handles keyboard height.
We are now using DesktopViewport's SetSafeInsets() methods to adjust
for the keyboard rather than just changing the surface size.

Bug:  876014 
Change-Id: I428cf2552acb3bc33cf932890a9395428d969a40
Reviewed-on: https://chromium-review.googlesource.com/1186027
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585666}
[modify] https://crrev.com/817178cd5c2013075965e0602b8b0d564f7ccbe8/remoting/client/gesture_interpreter.cc
[modify] https://crrev.com/817178cd5c2013075965e0602b8b0d564f7ccbe8/remoting/client/gesture_interpreter.h
[modify] https://crrev.com/817178cd5c2013075965e0602b8b0d564f7ccbe8/remoting/client/ui/desktop_viewport.cc
[modify] https://crrev.com/817178cd5c2013075965e0602b8b0d564f7ccbe8/remoting/client/ui/desktop_viewport.h
[modify] https://crrev.com/817178cd5c2013075965e0602b8b0d564f7ccbe8/remoting/client/ui/desktop_viewport_unittest.cc
[modify] https://crrev.com/817178cd5c2013075965e0602b8b0d564f7ccbe8/remoting/ios/app/host_view_controller.mm
[modify] https://crrev.com/817178cd5c2013075965e0602b8b0d564f7ccbe8/remoting/ios/app/view_utils.h
[modify] https://crrev.com/817178cd5c2013075965e0602b8b0d564f7ccbe8/remoting/ios/app/view_utils.mm

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96aee2cc743453f555e6a233ec968a01bfd32d6f

commit 96aee2cc743453f555e6a233ec968a01bfd32d6f
Author: Yuwei Huang <yuweih@chromium.org>
Date: Fri Aug 24 00:48:19 2018

[CRD iOS] Allow HostViewController to auto-hide the home indicator

This CL makes HostViewController request to autohide the home indicator
(the bar acting like a virtual home button), so that user can see
things on the bottom after the home indicator times out.

This CL is dependent on internal CL:
https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/666568

Bug:  876014 
Change-Id: I4d5e3f983100dd43f84f5d422bba31207707c651
Reviewed-on: https://chromium-review.googlesource.com/1187655
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585678}
[modify] https://crrev.com/96aee2cc743453f555e6a233ec968a01bfd32d6f/remoting/ios/app/host_view_controller.mm

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 24

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/5daa8e7bcd9ef49ba26ff053024b8460e160af0a

commit 5daa8e7bcd9ef49ba26ff053024b8460e160af0a
Author: Yuwei Huang <yuweih@google.com>
Date: Fri Aug 24 00:59:29 2018

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified on 71.0.3567.0 Canary, iPhone X  iOS 11.4.1,
Looks good.
https://drive.google.com/file/d/1ynz8G6l6AG3KoQRUlcPqVBGQD6jiaFFu/view

Sign in to add a comment