New issue
Advanced search Search tips

Issue 876002 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 23
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Video Capture] Distinguish causes for video capture errors

Project Member Reported by chfremer@chromium.org, Aug 20

Issue description

The metric Media.VideoCaptureManager.Event tracks counts of video capture sessions that a closed due to an error condition as well as counts of sessions that are closed normally. A recent increase in error counts on Windows was observerd but could not be explained by any particular code change. Error counts on appear to generally be higher than they should be on several platforms. The goal of this work is to improve the UMA logging by differentiating various possible sources of error events. Doing so will help us better understand what error events contribute most to the high error counts and will help us better pinpoint causes for future changes in error counts.

Design Doc: https://docs.google.com/document/d/1chso0ntOMecY7SfcrQzkHLuBAxO_oUwSpOhy1MrXAhc/edit?usp=sharing
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91

commit bd9bf68829a9392e3cb76960ae26d52cb1ccfd91
Author: Christian Fremerey <chfremer@chromium.org>
Date: Thu Aug 23 00:38:14 2018

[Video Capture] Distinguish and log error cases

Adds an enum for distinguishing which call sites trigger video
capture errors. The goal of this work is to improve the UMA logging
by differentiating various possible sources of error events. Doing
so will help us better understand what error events contribute most
to the high error counts and will help us better pinpoint causes
for future changes in error counts.

Design Doc: https://docs.google.com/document/d/1chso0ntOMecY7SfcrQzkHLuBAxO_oUwSpOhy1MrXAhc/edit?usp=sharing

Bug: 849636,  876002 
Change-Id: I02fcc8930ff7e66a15c91c4393bf9a280383902b
Reviewed-on: https://chromium-review.googlesource.com/1180412
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585336}
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/components/mirroring/browser/single_client_video_capture_host.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/components/mirroring/browser/single_client_video_capture_host.h
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/content/browser/media/capture/desktop_capture_device.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/content/browser/media/capture/desktop_capture_device_unittest.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/content/browser/media/capture/fake_video_capture_stack.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/content/browser/media/capture/frame_sink_video_capture_device.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/content/browser/media/capture/frame_sink_video_capture_device_unittest.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/content/browser/media/capture/screen_capture_device_android.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/content/browser/media/capture/screen_capture_device_android_unittest.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/content/browser/renderer_host/media/in_process_video_capture_device_launcher.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/content/browser/renderer_host/media/service_video_capture_device_launcher.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/content/browser/renderer_host/media/service_video_capture_device_launcher_unittest.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/content/browser/renderer_host/media/service_video_capture_provider_unittest.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/content/browser/renderer_host/media/video_capture_browsertest.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/content/browser/renderer_host/media/video_capture_controller.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/content/browser/renderer_host/media/video_capture_controller.h
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/content/browser/renderer_host/media/video_capture_controller_event_handler.h
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/content/browser/renderer_host/media/video_capture_controller_unittest.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/content/browser/renderer_host/media/video_capture_device_launch_observer.h
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/content/browser/renderer_host/media/video_capture_host.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/content/browser/renderer_host/media/video_capture_host.h
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/content/browser/renderer_host/media/video_capture_manager.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/content/browser/renderer_host/media/video_capture_manager.h
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/content/browser/renderer_host/media/video_capture_manager_unittest.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/content/browser/renderer_host/media/video_capture_unittest.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/content/public/browser/video_capture_device_launcher.h
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/content/android/screen_capture_machine_android.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/content/android/thread_safe_capture_oracle.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/content/android/thread_safe_capture_oracle.h
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/mojom/video_capture_types.mojom
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/mojom/video_capture_types.typemap
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/mojom/video_capture_types_mojom_traits.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/mojom/video_capture_types_mojom_traits.h
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/android/java/src/org/chromium/media/VideoCapture.java
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/android/video_capture_device_android.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/android/video_capture_device_android.h
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/chromeos/camera_device_context.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/chromeos/camera_device_context.h
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/chromeos/camera_device_delegate.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/chromeos/camera_device_delegate_unittest.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/chromeos/mock_video_capture_client.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/chromeos/mock_video_capture_client.h
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/chromeos/stream_buffer_manager.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/chromeos/stream_buffer_manager_unittest.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/chromeos/video_capture_device_chromeos_halv3.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/fake_video_capture_device_factory.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/fake_video_capture_device_unittest.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/file_video_capture_device.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/file_video_capture_device_unittest.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/linux/v4l2_capture_delegate.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/linux/v4l2_capture_delegate.h
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/linux/video_capture_device_linux.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/mac/video_capture_device_avfoundation_mac.mm
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/mac/video_capture_device_decklink_mac.h
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/mac/video_capture_device_decklink_mac.mm
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/mac/video_capture_device_mac.h
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/mac/video_capture_device_mac.mm
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/mock_video_capture_device_client.h
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/mock_video_frame_receiver.h
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/video_capture_device.h
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/video_capture_device_client.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/video_capture_device_client.h
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/video_capture_device_unittest.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/video_frame_receiver.h
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/video_frame_receiver_on_task_runner.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/video_frame_receiver_on_task_runner.h
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/win/video_capture_device_mf_win.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/win/video_capture_device_mf_win.h
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/win/video_capture_device_mf_win_unittest.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/win/video_capture_device_win.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video/win/video_capture_device_win.h
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/media/capture/video_capture_types.h
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/services/video_capture/device_media_to_mojo_adapter.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/services/video_capture/public/cpp/receiver_media_to_mojo_adapter.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/services/video_capture/public/cpp/receiver_media_to_mojo_adapter.h
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/services/video_capture/public/mojom/receiver.mojom
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/services/video_capture/receiver_mojo_to_media_adapter.cc
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/services/video_capture/receiver_mojo_to_media_adapter.h
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/services/video_capture/test/mock_receiver.h
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/bd9bf68829a9392e3cb76960ae26d52cb1ccfd91/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)
Issue 855683 has been merged into this issue.

Sign in to add a comment