Issue metadata
Sign in to add a comment
|
Users get prompted for PSK when no username/password are configured in adm.panel for L2TP VPN |
||||||||||||||||||||||
Issue descriptionChromeOS version: 67,68,69 ChromeOS device model: any Case#: 16644673, 16244396 Description: Users get prompted for PSK when no username/password are configured in L2TP VPN It's not duplicate of crbug.com/851653 (where users get prompted for PSK when _ALL_ credentials are configured in admin console). Steps to reproduce: 1. Setup L2TP/PSK VPN network in admin console (network is not necessary to be working), fill Remote Host, Pre-shared key. Do not fill Username and Password (use-case expects users to enter it manually). 2. Navigate to chrome://policy, expand OpenNetworkConfiguration, make sure VPN connection is present, and PSK: *******" is present. 3. From root's prompt navigate to /home/root/userID/session_manager/policy execute grep -a PSK policy Observe plan-text psk, to be sure PSK is passed to session manager. 4. Try to connect to VPN network. Current Behavior / Reproduction: PSK is not populated, "Connect" button is grayed-out till user manually enters PSK. Expected Behavior: PSK is populated. It's not happening on v59 (59.png) and other versions without material design for VPN. I didn't do bisect yet, as obviously this bug is introduced together with material design for VPN interface.
,
Aug 20
,
Aug 20
I didn't realize that PSK with no username was valid for VPN. I think that we expect a valid Username. I will take a look for 70.
,
Aug 20
We can't take 3 versions of Chrome OS to fix a regression. I believe ship is sailing on 68 but marking as RBB for 69.
,
Aug 20
This likely regressed when the new UI was introduced, long before 67. It's an edge case that clearly hasn't impacted enough users to be prioritized until now. FWIW, I don't think that blocking 69 on this is the correct call. If it is that critical, please escalate this to a P1 and I will prioritize it accordingly.
,
Aug 20
Agree with stevenjb@. Removing RBB, not an M69 regression. Currently exists in Beta and will not block follow up pushes. Issue can be fixed/merged given appropriate time, but will not block.
,
Aug 20
65.0.3325.209 -- good 66.0.3326.0 -- bad
,
Aug 22
,
Sep 11
Hi, could we have an update on the status of this bug? In the end, will it be fixed on M69? Or will it be only available in higher versions?
,
Sep 11
This is still in progress. It should be completed in time to be merged into 70.
,
Sep 11
,
Sep 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/079d8c6e4b5d0dcc46d1cddc293c768dd952cb1c commit 079d8c6e4b5d0dcc46d1cddc293c768dd952cb1c Author: Steven Bennetts <stevenjb@chromium.org> Date: Thu Sep 13 18:56:43 2018 VPN: Indicate in ONC when a PSK is saved. Bug: 875983 Change-Id: I05dcd470a96d3d3b833731a9e7471af8038b8b1e Reviewed-on: https://chromium-review.googlesource.com/1184316 Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#591095} [modify] https://crrev.com/079d8c6e4b5d0dcc46d1cddc293c768dd952cb1c/chromeos/network/onc/onc_translator_shill_to_onc.cc [modify] https://crrev.com/079d8c6e4b5d0dcc46d1cddc293c768dd952cb1c/components/onc/docs/onc_spec.md [modify] https://crrev.com/079d8c6e4b5d0dcc46d1cddc293c768dd952cb1c/ui/webui/resources/cr_components/chromeos/network/network_config.html [modify] https://crrev.com/079d8c6e4b5d0dcc46d1cddc293c768dd952cb1c/ui/webui/resources/cr_components/chromeos/network/network_config.js
,
Sep 13
,
Sep 14
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 24
,
Sep 28
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0fe2d559850e88c775feb58f361017f36cd61056 commit 0fe2d559850e88c775feb58f361017f36cd61056 Author: Steven Bennetts <stevenjb@chromium.org> Date: Mon Oct 01 16:09:09 2018 VPN: Indicate in ONC when a PSK is saved. TBR=stevenjb@chromium.org (cherry picked from commit 079d8c6e4b5d0dcc46d1cddc293c768dd952cb1c) Bug: 875983 Change-Id: I05dcd470a96d3d3b833731a9e7471af8038b8b1e Reviewed-on: https://chromium-review.googlesource.com/1184316 Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#591095} Reviewed-on: https://chromium-review.googlesource.com/1254743 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#771} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/0fe2d559850e88c775feb58f361017f36cd61056/chromeos/network/onc/onc_translator_shill_to_onc.cc [modify] https://crrev.com/0fe2d559850e88c775feb58f361017f36cd61056/components/onc/docs/onc_spec.md [modify] https://crrev.com/0fe2d559850e88c775feb58f361017f36cd61056/ui/webui/resources/cr_components/chromeos/network/network_config.html [modify] https://crrev.com/0fe2d559850e88c775feb58f361017f36cd61056/ui/webui/resources/cr_components/chromeos/network/network_config.js
,
Oct 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0fe2d559850e88c775feb58f361017f36cd61056 Commit: 0fe2d559850e88c775feb58f361017f36cd61056 Author: stevenjb@chromium.org Commiter: stevenjb@chromium.org Date: 2018-10-01 16:09:09 +0000 UTC VPN: Indicate in ONC when a PSK is saved. TBR=stevenjb@chromium.org (cherry picked from commit 079d8c6e4b5d0dcc46d1cddc293c768dd952cb1c) Bug: 875983 Change-Id: I05dcd470a96d3d3b833731a9e7471af8038b8b1e Reviewed-on: https://chromium-review.googlesource.com/1184316 Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#591095} Reviewed-on: https://chromium-review.googlesource.com/1254743 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#771} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by jayhlee@google.com
, Aug 20