New issue
Advanced search Search tips

Issue 875977 link

Starred by 1 user
Status: Fixed
Owner:
bsheedy@chromium.org
Closed: Aug 23
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

VrFeedbackInfoBarTest#* flaky

Project Member Reported by bsheedy@chromium.org, Aug 20 
Since around August 17th, many of the tests in VrFeedbackInfoBarTest have been flaky. The first failed build for Nougat is https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Nougat%20Phone%20Tester/7170, and the first failed build for Oreo is https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Oreo%20Phone%20Tester/478. However, since this isn't a consistent failure, it's possible the issue was introduced several builds before then.

The first two attempts of a test end up failing due to the infobar not appearing when it should. The last one fails before running test-case-specific code due to the test supposedly starting with the option to opt out of feedback already set, which shouldn't be happening.

Comment 1 by bsheedy@chromium.org, Aug 20

Owner: offenwanger@chromium.org
Status: Assigned (was: Untriaged)
offenwanger@, I know one of your recent changes affected runtime selection - is it possible that's the cause of this?

Comment 2 by bsheedy@chromium.org, Aug 20

Owner: bsheedy@chromium.org
Nevermind, I got the name mixed up with VrInstallUpdateInfoBarTest. This shouldn't have anything to do with runtime selection.

Comment 3 by bsheedy@chromium.org, Aug 21 

Culprit CL appears to be https://chromium-review.googlesource.com/c/chromium/src/+/1159116. Initial guess is that the feedback opt out preference isn't getting properly cleaned up between tests, so when we opt out in one of the tests, all subsequent tests still have the preference set.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/388af9a07abbca9230982fea1807a821c874913f

commit 388af9a07abbca9230982fea1807a821c874913f
Author: bsheedy <bsheedy@chromium.org>
Date: Wed Aug 22 16:42:34 2018

Clear VR feedback shared prefs before test start

Clears the two VR feedback shared preference values before a test starts
if they aren't currently the default. This is to prevent flakiness in
VrFeedbackInfoBarTest#* since shared preference settings are not
automatically reset between tests (which is expected).

Bug:  875977 
Change-Id: Ic69cadd2ae43b1a3570ee9f349f2770fed812138
Reviewed-on: https://chromium-review.googlesource.com/1183816
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585073}
[modify] https://crrev.com/388af9a07abbca9230982fea1807a821c874913f/chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrTestRuleUtils.java

Comment 5 by bsheedy@chromium.org, Aug 23

Status: Fixed (was: Assigned)

Comment 6 by bsheedy@chromium.org, Aug 29

Labels: -VR-Caught-By-Test XR-Caught-By-Test
►

Sign in to add a comment