New issue
Advanced search Search tips

Issue 875974 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Aug 21
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.2% regression in rendering.mobile at 584330:584330

Project Member Reported by hjd@google.com, Aug 20

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=875974

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=0a7caf505493eae5167f723ded2ed5916cc1f5695536978b07d227c1e5fc5814


Bot(s) for this bug's original alert(s):

Android Nexus6 WebView Perf
Owner: tapted@chromium.org
Status: Assigned (was: Untriaged)
Assigning to tapted@chromium.org because this is the only CL in range:
Introduce an ObserverList<T>::Unchecked type alias.

This is a precursor to https://crrev.com/c/1053338 which introduces
base::CheckedObserver. Existing observers will be unchecked (as they
are already). There is no behavior change with this CL.

The CL is mechanical. The bulk was done with variations on a sed script:

git grep -l ' base::ObserverList<.*> .*;' -- '*.cc' '*.h' '*.mm' | \
  xargs -IX sed -i -r 's/(^[ ]*)base::ObserverList<([^>]*)> (.*);/'\
    '\1base::ObserverList<\2>::Unchecked \3;/' X

With some manual follow-ups to get special cases.

TBR=gab@chromium.org

Bug: 842987
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_mojo;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Idffe88e2b52f67f9226eb7b6d922070349dacc22
Reviewed-on: https://chromium-review.googlesource.com/1175511
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584330}

Comment 3 Deleted

The chart data only goes back a month. I suspect this is noise. Like the CL description says -- there is no behavior change. It just introduces a typedef.
Status: WontFix (was: Assigned)
Yeah seems like the only graph that changed so probably not a real regression.

Sign in to add a comment