New issue
Advanced search Search tips

Issue 875973 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 0
Type: Bug



Sign in to add a comment

mosys tries to log un-initialized vars causing random crashes

Project Member Reported by gmeinke@chromium.org, Aug 20

Issue description

mosys logs un-initialized vars causing crashes.

root cause CL has also been merged into R69 branch.
 
Labels: M-69 Merge-Approved-69
https://chromium-review.googlesource.com/c/chromiumos/platform/mosys/+/1181777 merge approval per gmeinke@ Merge to M69.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 21

Labels: merge-merged-release-R69-10895.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/mosys/+/6dcc8b78a7771807dbc5ef8f95a8ae0d28e5db93

commit 6dcc8b78a7771807dbc5ef8f95a8ae0d28e5db93
Author: Gregory Meinke <gmeinke@google.com>
Date: Tue Aug 21 18:12:01 2018

Fix uninitialized var use in mosys

BUG=b:112319097,  chromium:875973 
TEST=local builds and tryjob

Change-Id: I76ecc8d7c0e687c14c6cbf40bce42a3e486f2c4a
Reviewed-on: https://chromium-review.googlesource.com/1181777
Tested-by: Gregory Meinke <gmeinke@chromium.org>
Reviewed-by: Gregory Meinke <gmeinke@chromium.org>
Commit-Queue: Gregory Meinke <gmeinke@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1183699
Reviewed-by: C Shapiro <shapiroc@google.com>
Commit-Queue: Philip Chen <philipchen@chromium.org>
Tested-by: Philip Chen <philipchen@chromium.org>

[modify] https://crrev.com/6dcc8b78a7771807dbc5ef8f95a8ae0d28e5db93/lib/cros_config/cros_config.c
[modify] https://crrev.com/6dcc8b78a7771807dbc5ef8f95a8ae0d28e5db93/platform/glados/glados.c

Status: Fixed (was: Assigned)
closing, CL is in both ToT and R69 branch.
Labels: ReleaseBlock-Dev M-70
Project Member

Comment 7 by sheriffbot@chromium.org, Aug 24

Cc: cindyb@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by sheriffbot@chromium.org, Aug 27

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment