New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 875970 link

Starred by 1 user
Status: Fixed
Owner:
haddowk@chromium.org
Closed: Sep 10
Cc:
█ mattmallett@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Network bridge init can not re-start - if the bridge is still running

Project Member Reported by haddowk@chromium.org, Aug 20 


If the bridge is restarted from mobmonitor it will fail with 

+ brctl addbr lxcbr0
device lxcbr0 already exists; can't create bridge with the same name
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/fc65a61e413b462c01bb8dec03fb65ad0a019819

commit fc65a61e413b462c01bb8dec03fb65ad0a019819
Author: Keith Haddow <haddowk@chromium.org>
Date: Wed Aug 29 04:12:46 2018

[moblab] - Ensure the network bridge does not exist before you start it.

If something goes wrong with the network bridge mobmonitor offers
to restart this upstart job, however it typically fails because
the bridge still exists and creating another bridge with the same
name fails

BUG= chromium:875970 
TEST=adhoc testing on moblab

Change-Id: Ib4693d16a813669beb793382b773445ca0765dd6
Reviewed-on: https://chromium-review.googlesource.com/1194185
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Matt Mallett <mattmallett@chromium.org>

[rename] https://crrev.com/fc65a61e413b462c01bb8dec03fb65ad0a019819/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.1-r45.ebuild
[modify] https://crrev.com/fc65a61e413b462c01bb8dec03fb65ad0a019819/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-network-bridge-init.conf
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 29

Labels: merge-merged-release-R68-10718.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/ea29cee88c9ee2d45a98f0397fe52e407eec2b6e

commit ea29cee88c9ee2d45a98f0397fe52e407eec2b6e
Author: Keith Haddow <haddowk@chromium.org>
Date: Wed Aug 29 18:34:44 2018

[moblab] - Ensure the network bridge does not exist before you start it.

If something goes wrong with the network bridge mobmonitor offers
to restart this upstart job, however it typically fails because
the bridge still exists and creating another bridge with the same
name fails

BUG= chromium:875970 
TEST=adhoc testing on moblab

Change-Id: Ib4693d16a813669beb793382b773445ca0765dd6
Reviewed-on: https://chromium-review.googlesource.com/1194185
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Matt Mallett <mattmallett@chromium.org>
(cherry picked from commit fc65a61e413b462c01bb8dec03fb65ad0a019819)
Reviewed-on: https://chromium-review.googlesource.com/1194198
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Trybot-Ready: Keith Haddow <haddowk@chromium.org>

[rename] https://crrev.com/ea29cee88c9ee2d45a98f0397fe52e407eec2b6e/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.1-r45.ebuild
[modify] https://crrev.com/ea29cee88c9ee2d45a98f0397fe52e407eec2b6e/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-network-bridge-init.conf
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 30

Labels: merge-merged-release-R69-10895.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/ad1829b33b576b2c7a701b5ce7490cc06bbd845a

commit ad1829b33b576b2c7a701b5ce7490cc06bbd845a
Author: Keith Haddow <haddowk@chromium.org>
Date: Thu Aug 30 20:55:31 2018

[moblab] - Ensure the network bridge does not exist before you start it.

If something goes wrong with the network bridge mobmonitor offers
to restart this upstart job, however it typically fails because
the bridge still exists and creating another bridge with the same
name fails

BUG= chromium:875970 
TEST=adhoc testing on moblab

Change-Id: Ib4693d16a813669beb793382b773445ca0765dd6
Reviewed-on: https://chromium-review.googlesource.com/1194185
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Matt Mallett <mattmallett@chromium.org>
(cherry picked from commit fc65a61e413b462c01bb8dec03fb65ad0a019819)
Reviewed-on: https://chromium-review.googlesource.com/1194199
Commit-Queue: Keith Haddow <haddowk@chromium.org>
Trybot-Ready: Keith Haddow <haddowk@chromium.org>

[rename] https://crrev.com/ad1829b33b576b2c7a701b5ce7490cc06bbd845a/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.1-r45.ebuild
[modify] https://crrev.com/ad1829b33b576b2c7a701b5ce7490cc06bbd845a/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-network-bridge-init.conf

Comment 4 by haddowk@chromium.org, Sep 10

Status: Fixed (was: Assigned)
►

Sign in to add a comment