Painting problems with OOPIF layout tests |
|||||||
Issue descriptionEnable OOPIF layout tests. You can look at the try jobs from this patch: https://chromium-review.googlesource.com/c/chromium/src/+/1075891/3 The following problems are paint team for first triage. Incorrect position for elements. Real failure. media/controls-after-reload.html media/controls-strict.html media/controls-styling-strict.html media/controls-styling.html media/controls-without-preload.html media/video-controls-rendering.html media/video-display-toggle.html media/video-no-audio.html media/controls/ virtual/new-remote-playback-pipeline/media/controls/ Missing focus rings? Some other content? editing/selection paint/invalidation/svg/text-selection-text-05-t.svg svg/text/ Missing content entirely: virtual/android/fullscreen/rendering/backdrop-video.html Fix these so we can enable OOPIF layout tests by default.
,
Aug 20
The focus rings are missing due to the fact that display compositor pixel dumps don't implement those yet; I'm guessing that the missing video output is also due to the different pixel dumps path.
,
Aug 20
,
Aug 23
,
Aug 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75453eca5b9805945dde7a1e73d5f2c445027297 commit 75453eca5b9805945dde7a1e73d5f2c445027297 Author: Mason Freed <masonfreed@chromium.org> Date: Mon Aug 27 17:11:23 2018 [CI] Implement selection rects for display compositor pixel dumps This patch implements selection rects on the renderer side for display compositor pixel dumps (when using OOPIF). Bug: 875963 , 876064 Change-Id: Ie1bc94d94dd290fce13198c63ce3ae8f3fd4b6bd Reviewed-on: https://chromium-review.googlesource.com/1185915 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: vmpstr <vmpstr@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#586291} [modify] https://crrev.com/75453eca5b9805945dde7a1e73d5f2c445027297/content/shell/BUILD.gn [modify] https://crrev.com/75453eca5b9805945dde7a1e73d5f2c445027297/content/shell/browser/layout_test/blink_test_controller.cc [modify] https://crrev.com/75453eca5b9805945dde7a1e73d5f2c445027297/content/shell/common/layout_test.mojom [add] https://crrev.com/75453eca5b9805945dde7a1e73d5f2c445027297/content/shell/common/layout_test/layout_test_utils.cc [add] https://crrev.com/75453eca5b9805945dde7a1e73d5f2c445027297/content/shell/common/layout_test/layout_test_utils.h [modify] https://crrev.com/75453eca5b9805945dde7a1e73d5f2c445027297/content/shell/renderer/layout_test/blink_test_runner.cc [modify] https://crrev.com/75453eca5b9805945dde7a1e73d5f2c445027297/content/shell/test_runner/BUILD.gn [modify] https://crrev.com/75453eca5b9805945dde7a1e73d5f2c445027297/content/shell/test_runner/pixel_dump.cc [modify] https://crrev.com/75453eca5b9805945dde7a1e73d5f2c445027297/content/shell/test_runner/test_runner.cc [modify] https://crrev.com/75453eca5b9805945dde7a1e73d5f2c445027297/content/shell/test_runner/test_runner.h [modify] https://crrev.com/75453eca5b9805945dde7a1e73d5f2c445027297/content/shell/test_runner/web_test_runner.h [modify] https://crrev.com/75453eca5b9805945dde7a1e73d5f2c445027297/third_party/blink/renderer/core/frame/web_local_frame_impl.cc
,
Sep 5
,
Oct 26
,
Nov 2
This one is fixed. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by schenney@chromium.org
, Aug 20