New issue
Advanced search Search tips

Issue 875962 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 667551



Sign in to add a comment

Popup layout tests fail in OOPIF mode

Project Member Reported by schenney@chromium.org, Aug 20

Issue description

Enable OOPIF layout tests. You can look at the try jobs from this patch:

https://chromium-review.googlesource.com/c/chromium/src/+/1075891/3

Dropdown option forms are not dropping down. Could be events of could be painting locations or something else.

 compositing/overflow/update-widget-positions-on-nested-frames-and-scrollers.html
 fast/forms/calendar-picker/
 fast/forms/color/
 fast/forms/select-popup/
 fast/forms/suggestion-picker/
 http/tests/media/controls/video-controls-overflow-menu-correct-ordering.html
 http/tests/media/controls/video-controls-overflow-menu-updates-appropriately.html
 http/tests/webfont/popup-menu-load-webfont-after-open.html
 virtual/prefer_compositing_to_lcd_text/compositing/overflow/update-widget-positions-on-nested-frames-and-scrollers.html
 virtual/scalefactor150/fast/hidpi/static/*
 virtual/scalefactor200withzoom/fast/hidpi/static/*
 virtual/new-remote-playback-pipeline/http/tests/media/controls/ (probably)

Fix this so we can enable OOPIF support in layout tests.
 
Blocking: 667551
Components: Internals>Sandbox>SiteIsolation
Status: Available (was: Untriaged)
Owner: masonfreed@chromium.org
Status: Assigned (was: Available)
->masonfreed for triage to see if these failures are real or just in test mode.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1879b6e09f4caeb6af3d2ca2c7e0da01973c316

commit e1879b6e09f4caeb6af3d2ca2c7e0da01973c316
Author: Mason Freed <masonfreed@chromium.org>
Date: Mon Sep 10 17:55:11 2018

[CI] Adding functionality to RenderWidgetHostViewAura::CopyFromSurface to capture popups.

Previous to this CL, the RenderWidgetHostViewAura::CopyFromSurface function would capture
only the main window contents. It would ignore any secondary child popup screens that
were generated as a result of many popup operations, for example calendar pickers, selection popups,
suggestion pickers, etc. With this CL, those popup screens are detected, captured, and
overlaid on top of the main window capture.

Note that in the process of implementing this, I fixed a bug in
RenderWidgetHostViewAura::GetBoundsInRootWindow(), for the Windows case. Previous to this CL,
for Windows, when legacy HWNDs are not in use (UsesNativeWindowFrame() returns false), the
function would return locations in units of DIPs divided by scale factor. It should be returning
DIPs. I moved the conversion up into the if{} block. It seems that no current test catches this
issue, but once --enable-display-compositor-pixel-dumps becomes a default flag, the existing
layout tests, under virtual/scalefactorXyz, should serve to monitor this code for regressions.

Bug:  875962 ,  667551 

Change-Id: Iefc9bfd7798b3dfabb3a28eb46009fa703c0fca0
Reviewed-on: https://chromium-review.googlesource.com/1192330
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589975}
[modify] https://crrev.com/e1879b6e09f4caeb6af3d2ca2c7e0da01973c316/content/browser/renderer_host/delegated_frame_host.cc
[modify] https://crrev.com/e1879b6e09f4caeb6af3d2ca2c7e0da01973c316/content/browser/renderer_host/delegated_frame_host.h
[modify] https://crrev.com/e1879b6e09f4caeb6af3d2ca2c7e0da01973c316/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/e1879b6e09f4caeb6af3d2ca2c7e0da01973c316/content/browser/renderer_host/render_widget_host_view_base.cc
[modify] https://crrev.com/e1879b6e09f4caeb6af3d2ca2c7e0da01973c316/content/browser/renderer_host/render_widget_host_view_base.h
[modify] https://crrev.com/e1879b6e09f4caeb6af3d2ca2c7e0da01973c316/content/browser/renderer_host/render_widget_host_view_mac.h
[modify] https://crrev.com/e1879b6e09f4caeb6af3d2ca2c7e0da01973c316/content/browser/renderer_host/render_widget_host_view_mac.mm

Status: Fixed (was: Assigned)
CL has landed. Closing this bug.

Sign in to add a comment