New issue
Advanced search Search tips

Issue 875953 link

Starred by 1 user
Status: Fixed
Owner:
joedow@chromium.org
Closed: Aug 20
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 0
Type: Bug



Sign in to add a comment

CRD Native Messaging Host crashes on launch

Project Member Reported by joedow@chromium.org, Aug 20 
This is due to the missing Mojo init code in our Me2Me NMH, same root cause as  crbug.com/875462 .

It2Me NMH is not affected since it doesn't use Mojo.

Lambros had tested Linux when he made his fix and said it was working however it definitely crashes on Windows so I'm going to add the init code here as well.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8f828e39336f12f39b0bc78854af6b3cd2b8d3e

commit d8f828e39336f12f39b0bc78854af6b3cd2b8d3e
Author: Joe Downing <joedow@chromium.org>
Date: Mon Aug 20 21:32:01 2018

Fixing a NMH crash on Windows

A recent CL added a Mojo dependency to our host binaries.  This caused a
crash on Linux/MacOS ( crbug.com/875462 ) which was recently fixed. I then
saw a crash in the NMH on Windows when starting the CRD App.  This is due
to the same root problem but in our Me2Me NMH binary this time.  I've
fixed the init problem and verified I can set up a host again.

I've also tested It2Me on Windows and it works fine.

BUG= 875953 

Change-Id: Ia22e45aa2d9ed0b1e27595e1cee1038676278b70
Reviewed-on: https://chromium-review.googlesource.com/1181928
Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584569}
[modify] https://crrev.com/d8f828e39336f12f39b0bc78854af6b3cd2b8d3e/remoting/host/setup/BUILD.gn
[modify] https://crrev.com/d8f828e39336f12f39b0bc78854af6b3cd2b8d3e/remoting/host/setup/me2me_native_messaging_host_main.cc

Comment 2 by joedow@chromium.org, Aug 20

Status: Fixed (was: Available)
►

Sign in to add a comment