New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 875951 link

Starred by 2 users
Status: Fixed
Owner:
█ loonyb...@chromium.org
Last visit > 30 days ago
Closed: Nov 6
Cc:
█ loonyb...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

max-downscaling-image: kitchen sink demo no longer works

Project Member Reported by ericbidelman@chromium.org, Aug 20 
Chrome Version: 70.0.3528.0 (Official Build) canary (64-bit)
OS: macOS x

What steps will reproduce the problem?
(1) Visit https://feature-policy-demos.appspot.com/max-downscaling-image.html?on

What is the expected result?

Some of the images should be inverted.

What happens instead?

The demo no longer works.


Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

Comment 1 by cha...@chromium.org, Aug 24

Labels: -Type-Bug -Pri-3 Pri-1 Type-Bug-Regression
Owner: loonyb...@chromium.org
Status: Assigned (was: Untriaged)
I've confirmed that on Canary 70.0.3532.0, I don't see any of the images inverted. Other policies on that demo site are inverting the colours. It seems it's not a problem with the colour inversion generally.

loonybear@ I haven't done a bisect, or figured out when this broke. Would you take a look, please?

Comment 2 by loonyb...@chromium.org, Sep 6

Status: Started (was: Assigned)

Comment 3 by loonyb...@chromium.org, Sep 6 

Did you run the test with run time flag enabled? 

I just did a local clean build 
out/CleanDefault/content_shell --enable-experimental-web-platform-features
https://feature-policy-demos.appspot.com/max-downscaling-image.html?on

And everything seems to be working correctly.
screen-shot-max-downscaling.png
308 KB View Download

Comment 4 by loonyb...@chromium.org, Sep 6

Status: WontFix (was: Started)
Works on Version 71.0.3545.0 (Developer Build)

Closing as WontFix.

Comment 5 by ericbidelman@chromium.org, Sep 6

Labels: OS-Mac
Status: Unconfirmed (was: WontFix)
Still seeing the issue on 71.0.3544.2 macos (current canary). That version is a bit behind what you tested, but if we haven't touched the code in a while, something is still buggy.

I have --enable-experimental-web-platform-features enabled.

Comment 6 by loonyb...@chromium.org, Sep 6 

Interesting. No I did not touch max-downscaling lately. 

Also interesting because there are layout tests for max-downscaling https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/images/feature-policy-max-downscaling-image.html

If anything is reported as flaky/buggy, this test should also be failing.

Comment 7 by loonyb...@chromium.org, Sep 6 

I just tried it on Version 70.0.3534.4 (Official Build) dev (64-bit)
It also worked as expected.

Comment 8 by loonyb...@chromium.org, Sep 6 

Are you testing on mac?

Comment 9 by ericbidelman@chromium.org, Sep 6 

Yea, on mac. I also used an incognito window to make sure my Feature Policy chrome extension wasn't interfering in any way.

Comment 10 by loonyb...@chromium.org, Sep 6

Status: Started (was: Unconfirmed)
OK I managed to reproduce it on Mac (current canary). 
It works on Linux (current canary) incognito mode. 


Ah, I see. Mac has a different device pixel ratio (higher resolution) so I have to compress the image further to make it "max-downscaled". I changed to size to be smaller then it worked.

I will fix that ASAP.

Thanks for the finding Eric!

Comment 11 by ekaramad@chromium.org, Sep 10

Labels: M-71

Comment 12 by loonyb...@chromium.org, Nov 5 

With https://github.com/loonybear/feature-policy-demos/pull/3 merged. This issue should be fixed.

Comment 13 by loonyb...@chromium.org, Nov 6

Status: Fixed (was: Started)
►

Sign in to add a comment