New issue
Advanced search Search tips

Issue 875945 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 667551



Sign in to add a comment

Scrolling and middle mouse tests fail with OOPIF

Project Member Reported by schenney@chromium.org, Aug 20

Issue description

Run a try job with this patch and look at the failures, or look at the existing try job runs.

https://chromium-review.googlesource.com/c/chromium/src/+/1075891/3

There are issues with scroll, middle mouse in particular, and pinch zoom. These seem to be related to missing events.

  virtual/android/rootscroller/set-rootscroller-before-load.html
  fast/events/
  virtual/threaded/fast/events/pinch/
  virtual/threaded/synthetic_gestures/synthetic-pinch-zoom-gesture-touchscreen-desktop.html
  virtual/user-activation-v2/fast/events/*
  virtual/mouseevent_fractional/fast/events/*

Investigate and fix the infrastructure so we can enable OOPIF tests by default.
 
Blockedon: 667551
Blockedon: -667551
Blocking: 667551
Maybe this one too:
virtual/threaded/synthetic_gestures/synthetic-pinch-zoom-gesture-touchscreen-desktop.html
Cc: bokan@chromium.org mustaq@chromium.org
Status: Available (was: Untriaged)
I don't think we have all the tests fully resolved for user-activation-v2. Mustaq knows better though. Maybe we need to skip them if we really want to enable OOPIF by default for the layout tests.

Can someone paste the list of the failing tests. I know it is about 300 or so but it is not listed in the first page of the bots and takes forever to load the stdout for me.
Cc: -mustaq@chromium.org
Nevermind. bokan@ showed me the whole list and it only contained middlebutton scrolls which Sahel's is working on apparently.
Cc: sahel@chromium.org
Owner: sahel@chromium.org
Status: Assigned (was: Available)
Most of the failures in fast/events are the middle click tests. Assigning to sahel@ to take a first look. This could be related to either bug 872832 or bug 874162 (or neither).

Is --enable-display-compositor-pixel-dump the correct flag to add to run-layout-tests?


Re fast/events/*, since these are mostly for middle click autoscroll:
- We have a few open bugs on flaky middle-click-tests w/o OOPIFs.
- 34 "middleClickAutoscroll*" tests are currently marked as slow/skipped/flaky.
- I feel like many of these are stale: looked at middleClickAutoscroll-click-hyperlink.html once, it doesn't seem to test middle-click autoscroll behavior at all!

This bug shouldn't block User Activation v2, the corresponding virtual test suite has a single failed test ( Issue 867845 ), which fails in the main suite too.

Middle click autoscroll tests are failing since they are still using event sender to inject the input events in blink rather than browser. I have not checked other tests yet. But this seems likely to be true for other failing tests as well.
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e186dbf7422ba632056ebad32d3dcb7d35fe7638

commit e186dbf7422ba632056ebad32d3dcb7d35fe7638
Author: Sahel Sharify <sahel@chromium.org>
Date: Mon Oct 01 22:28:58 2018

Convert middleClickAutoscroll.js to use gpu benchmarking

This cl converts middleClickAutoscroll.js and the middle click autoscroll
layout tests that are using it to use gpu benchmarking.

Bug: 875945
Change-Id: Ic5acb4367dd406de3e5897063bfe6b1b44e7daa6
Reviewed-on: https://chromium-review.googlesource.com/1251901
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595596}
[delete] https://crrev.com/b8ca53abff774931800f64fa522b7b0e2a8045d4/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-click-expected.txt
[modify] https://crrev.com/e186dbf7422ba632056ebad32d3dcb7d35fe7638/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-click.html
[delete] https://crrev.com/b8ca53abff774931800f64fa522b7b0e2a8045d4/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-drag-expected.txt
[modify] https://crrev.com/e186dbf7422ba632056ebad32d3dcb7d35fe7638/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-drag.html
[delete] https://crrev.com/b8ca53abff774931800f64fa522b7b0e2a8045d4/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-event-fired-expected.txt
[modify] https://crrev.com/e186dbf7422ba632056ebad32d3dcb7d35fe7638/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-event-fired.html
[delete] https://crrev.com/b8ca53abff774931800f64fa522b7b0e2a8045d4/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-in-iframe-expected.txt
[modify] https://crrev.com/e186dbf7422ba632056ebad32d3dcb7d35fe7638/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-in-iframe.html
[delete] https://crrev.com/b8ca53abff774931800f64fa522b7b0e2a8045d4/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-nested-divs-expected.txt
[delete] https://crrev.com/b8ca53abff774931800f64fa522b7b0e2a8045d4/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-nested-divs-forbidden-expected.txt
[modify] https://crrev.com/e186dbf7422ba632056ebad32d3dcb7d35fe7638/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-nested-divs-forbidden.html
[modify] https://crrev.com/e186dbf7422ba632056ebad32d3dcb7d35fe7638/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-nested-divs.html
[modify] https://crrev.com/e186dbf7422ba632056ebad32d3dcb7d35fe7638/third_party/WebKit/LayoutTests/fast/events/resources/middleClickAutoscroll.js
[modify] https://crrev.com/e186dbf7422ba632056ebad32d3dcb7d35fe7638/third_party/WebKit/LayoutTests/resources/gesture-util.js

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/202e04f19dcf1b9b23527838e89f9e947e6c0fb5

commit 202e04f19dcf1b9b23527838e89f9e947e6c0fb5
Author: Camille Lamy <clamy@chromium.org>
Date: Tue Oct 02 13:32:29 2018

Revert "Convert middleClickAutoscroll.js to use gpu benchmarking"

This reverts commit e186dbf7422ba632056ebad32d3dcb7d35fe7638.

Reason for revert: Introduced flakyness in virtual/user-activation-v2/fast/events/middleClickAutoscroll-drag.html.

See https://crbug.com/891155

Original change's description:
> Convert middleClickAutoscroll.js to use gpu benchmarking
> 
> This cl converts middleClickAutoscroll.js and the middle click autoscroll
> layout tests that are using it to use gpu benchmarking.
> 
> Bug: 875945
> Change-Id: Ic5acb4367dd406de3e5897063bfe6b1b44e7daa6
> Reviewed-on: https://chromium-review.googlesource.com/1251901
> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
> Commit-Queue: Sahel Sharify <sahel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#595596}

TBR=nzolghadr@chromium.org,sahel@chromium.org

Change-Id: I108620182b4466997df7734f01718e102628fcf6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 875945
Reviewed-on: https://chromium-review.googlesource.com/1256923
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595818}
[add] https://crrev.com/202e04f19dcf1b9b23527838e89f9e947e6c0fb5/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-click-expected.txt
[modify] https://crrev.com/202e04f19dcf1b9b23527838e89f9e947e6c0fb5/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-click.html
[add] https://crrev.com/202e04f19dcf1b9b23527838e89f9e947e6c0fb5/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-drag-expected.txt
[modify] https://crrev.com/202e04f19dcf1b9b23527838e89f9e947e6c0fb5/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-drag.html
[add] https://crrev.com/202e04f19dcf1b9b23527838e89f9e947e6c0fb5/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-event-fired-expected.txt
[modify] https://crrev.com/202e04f19dcf1b9b23527838e89f9e947e6c0fb5/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-event-fired.html
[add] https://crrev.com/202e04f19dcf1b9b23527838e89f9e947e6c0fb5/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-in-iframe-expected.txt
[modify] https://crrev.com/202e04f19dcf1b9b23527838e89f9e947e6c0fb5/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-in-iframe.html
[add] https://crrev.com/202e04f19dcf1b9b23527838e89f9e947e6c0fb5/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-nested-divs-expected.txt
[add] https://crrev.com/202e04f19dcf1b9b23527838e89f9e947e6c0fb5/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-nested-divs-forbidden-expected.txt
[modify] https://crrev.com/202e04f19dcf1b9b23527838e89f9e947e6c0fb5/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-nested-divs-forbidden.html
[modify] https://crrev.com/202e04f19dcf1b9b23527838e89f9e947e6c0fb5/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-nested-divs.html
[modify] https://crrev.com/202e04f19dcf1b9b23527838e89f9e947e6c0fb5/third_party/WebKit/LayoutTests/fast/events/resources/middleClickAutoscroll.js
[modify] https://crrev.com/202e04f19dcf1b9b23527838e89f9e947e6c0fb5/third_party/WebKit/LayoutTests/resources/gesture-util.js

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e091c40d261a28be62bf03063e1997582efab4a

commit 7e091c40d261a28be62bf03063e1997582efab4a
Author: Sahel Sharify <sahel@chromium.org>
Date: Fri Oct 12 19:11:01 2018

Reland "Convert middleClickAutoscroll.js to use gpu benchmarking"

The original cl is reviewed here:
https://chromium-review.googlesource.com/c/chromium/src/+/1251901

The reland calls waitForCompositorCommit before starting the test to make
sure that the compositor is ready.

To Sheriffs:
Please update the test expectations in case of a flaky test instead of
reverting this cl since I need to convert middleClickAutoscroll
tests to use gpuBenchmarking to land the fix for autoscroll coordinates:
https://chromium-review.googlesource.com/c/chromium/src/+/1239174
GpuBenchmarking makes the tests prone to flakiness, input team will work
on the flakiness of the tests using gpu benchmarking in Q4.

Bug: 875945
Change-Id: Ic722fbd8a08bee7bc1e51143ae9a6cb738807fe7
Reviewed-on: https://chromium-review.googlesource.com/c/1277806
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599319}
[delete] https://crrev.com/f85dbab6541c011c1424b223c45f56f80dea43e4/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-click-expected.txt
[modify] https://crrev.com/7e091c40d261a28be62bf03063e1997582efab4a/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-click.html
[delete] https://crrev.com/f85dbab6541c011c1424b223c45f56f80dea43e4/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-drag-expected.txt
[modify] https://crrev.com/7e091c40d261a28be62bf03063e1997582efab4a/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-drag.html
[delete] https://crrev.com/f85dbab6541c011c1424b223c45f56f80dea43e4/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-event-fired-expected.txt
[modify] https://crrev.com/7e091c40d261a28be62bf03063e1997582efab4a/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-event-fired.html
[delete] https://crrev.com/f85dbab6541c011c1424b223c45f56f80dea43e4/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-in-iframe-expected.txt
[modify] https://crrev.com/7e091c40d261a28be62bf03063e1997582efab4a/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-in-iframe.html
[delete] https://crrev.com/f85dbab6541c011c1424b223c45f56f80dea43e4/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-nested-divs-expected.txt
[delete] https://crrev.com/f85dbab6541c011c1424b223c45f56f80dea43e4/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-nested-divs-forbidden-expected.txt
[modify] https://crrev.com/7e091c40d261a28be62bf03063e1997582efab4a/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-nested-divs-forbidden.html
[modify] https://crrev.com/7e091c40d261a28be62bf03063e1997582efab4a/third_party/WebKit/LayoutTests/fast/events/middleClickAutoscroll-nested-divs.html
[modify] https://crrev.com/7e091c40d261a28be62bf03063e1997582efab4a/third_party/WebKit/LayoutTests/fast/events/resources/middleClickAutoscroll.js
[modify] https://crrev.com/7e091c40d261a28be62bf03063e1997582efab4a/third_party/WebKit/LayoutTests/resources/gesture-util.js

Sign in to add a comment