New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 875935 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

ChromeVox not announcing startup on chromecast

Project Member Reported by rmrossi@chromium.org, Aug 20

Issue description

Launching the chromevox extension on chromecast no longer announces the startup message.  This is because it is not possible to determine the platform from the user agent string.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88aecf78de345710017519c764ce359a4fbf3b1b

commit 88aecf78de345710017519c764ce359a4fbf3b1b
Author: Randy Rossi <rmrossi@chromium.org>
Date: Thu Aug 23 17:47:48 2018

Fix chromevox ready message on chromecast

This CL removes the platform check for windows/linux/mac
when deciding when to announce the startup message.  The message
should be spoken for all platforms. This script is not executed
on Android anymore so there is no longer any reason to prevent the
message from being spoken on that platform.  For ChromeOS, however,
the existing onIntroduceChromeVox listener is used to announce
startup.  The criteria therefore changed to !isChromeOS.

      Installed on Chromecast and verified message is spoken to fix the
      bug.

Bug: 875935
Test: Installed on ChromeOS and verified message still spoken
Change-Id: I078ee4aaab6ed3cedabcc43edbb6660aa9c7523e
Reviewed-on: https://chromium-review.googlesource.com/1181931
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585538}
[modify] https://crrev.com/88aecf78de345710017519c764ce359a4fbf3b1b/chrome/browser/resources/chromeos/chromevox/chromevox/background/background.js

Status: Assigned (was: Untriaged)

Sign in to add a comment