New issue
Advanced search Search tips

Issue 875932 link

Starred by 1 user
Status: Verified
Owner:
eugene...@chromium.org
Closed: Aug 23
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Download manager's progress indicator is drawn out of place

Project Member Reported by shbarezer@chromium.org, Aug 20 
App Version: 69.0.3497.50 Beta
iOS Version: 11.4.1, 12.0 beta#9
Device: iPhone X,iPhone 7

Steps to reproduce:
1. Launch chrome 
2. Navigate to a site with downloadable files e.g. thinkbroadband.com/download
3. Tap on any of the files to download
4. Tap on Download link and wait for a few sec to see progress (blue progress bar)
5. Open a new tab
6. Browse to any site
7. Go back to the tab where you are downloading the file

Observed results:
Download manager's progress indicator is drawn out of place

Expected results:
Download manager's progress indicator should be in place

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: Not tested 
Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA 
Bug reproducible on current stable build (App Version, iOS Version): Yes on M68 (New UI) 
Bug reproducible on the current beta channel build (App Version, iOS Version): No on M69 (New UI) 

Link to image:
https://drive.google.com/file/d/1WXqyzjpu4mshBzGREa4MOFVCpzpD1vMY/view

Comment 1 by eugene...@chromium.org, Aug 20

Labels: Needs-Feedback
Could you please clarify the following information:

Bug reproducible on current stable build (App Version, iOS Version): Yes on M68 (New UI) 
Bug reproducible on the current beta channel build (App Version, iOS Version): No on M69 (New UI) 


Does the bug reproduce on M68 stable with old UI?
Does the bug reproduce on M69 stable with new UI?


If the bug is not reproducible with M69 (New UI), then we should close it.

Comment 2 by shbarezer@chromium.org, Aug 20 

Let me correct my mistake:
Bug reproducible on current stable build (App Version, iOS Version): Yes on M68 (Yes on New Download Manager UI) 
Bug reproducible on the current beta channel build (App Version, iOS Version): Yes on M69 (Yes on UIRefresh)

Does the bug reproduce on M68 stable with old UI? No on Old Download Manager UI
Does the bug reproduce on M69 stable with new UI? Yes

Comment 3 by eugene...@chromium.org, Aug 20

Cc: -eugene...@chromium.org
Labels: -Needs-Feedback ReleaseBlock-Stable M-70
Owner: eugene...@chromium.org
Status: Assigned (was: Untriaged)
Thanks!

Comment 4 by eugene...@chromium.org, Aug 21

Labels: -Type-Bug -Pri-2 -Proj-UIRefresh Pri-1 Type-Bug-Regression

Comment 5 by eugene...@chromium.org, Aug 21

Status: Started (was: Assigned)
CL on review: crrev.com/c/1182867
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa15b968d2ecf8c28e51443d2b58b9f2ec99eb60

commit fa15b968d2ecf8c28e51443d2b58b9f2ec99eb60
Author: Eugene But <eugenebut@google.com>
Date: Thu Aug 23 19:59:30 2018

Fix Download Manager progress view.

Do not create radial progress path until the view is added to the
hierarchy.

Bug:  875932 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic4bfab416cdc6dd4cf3e7a1b4c1f4624b7cab0bf
Reviewed-on: https://chromium-review.googlesource.com/1182867
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585591}
[modify] https://crrev.com/fa15b968d2ecf8c28e51443d2b58b9f2ec99eb60/ios/chrome/browser/ui/download/radial_progress_view.mm

Comment 7 by eugene...@chromium.org, Aug 23

Status: Fixed (was: Started)

Comment 8 by vbarig...@chromium.org, Aug 29

Status: Verified (was: Fixed)
Verified on chrome canary version 70.0.3536.0 on iPhone 6 plus with iOS 11.4.1, iPhone 6s plus with iOS 12 beta 11 following steps mentioned in comment #0.  Download manager progress indicator is in place and looks good.
►

Sign in to add a comment