New issue
Advanced search Search tips

Issue 875876 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Add setting the device hostname to ChromeAD admx templates

Project Member Reported by pnevin@chromium.org, Aug 20

Issue description

Description:
Add the a policy to set a device hostname on a Chrome device in the Active Directory admx templates. 

Use case:
Customers would like the ability to set the hostname of a Chrome device through policy in order to identify the device on the network. This is currently supported on the device (http://crbug/676195), and there is a test on the Chrome cloud-managed side (http://b/72481557). In order for ChromeAD customer to take advantage a policy needs to be added to the ChromeOS admx templates. 

The client side values can be set as follows: 

Policy=xxx                         xxx
Policy=${ASSET_ID}                 Device's asset ID [1]
Policy=${SERIAL_NUM}               Device's serial number
Policy=${MAC_ADDR}                 Device's MAC address
Policy=xxx+VAR+xxx                 xxx+VAR_VALUE+xxx

In ChromeAD it would be most valuable to allow the AD machine name ${MACHINE_NAME} to be used as a value in addition to or instead of ASSET_ID. Machine name is the way printers can be named in ChromeAD via policy.


Motivation:
This feature would allow customers to identify individual devices on the network for integration into their other enterprise systems. The only way to identify the devices today is with IP address which is subject to change.

Existing workarounds:
None

 
Owner: rsorokin@chromium.org
Status: Assigned (was: Untriaged)
- Enable DeviceHostnameTemplate for AD
- Add DeviceHostnameTemplate to kPoliciesToExpand in active_directory_policy_manager.cc
- Handle ${SERIAL_NUM} etc. in ActiveDirectoryPolicyManager::ExpandVariables
Not sure what to do with ASSET_ID. Should we map that to MACHINE_NAME?
Labels: -Pri-3 Enterprise-Triaged Chromad M-71 Pri-2
Status: Started (was: Assigned)
@ljusten Yes, I think it would be good to be able to use MACHINE_NAME on the AD side. 
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f520fed60941525603987858d6623251cbd2886

commit 3f520fed60941525603987858d6623251cbd2886
Author: Roman Sorokin <rsorokin@chromium.org>
Date: Mon Oct 08 13:36:35 2018

Enable expansion of MACHINE_NAME for DeviceHostnameTemplate

Also capitalized MACHINE_NAME placeholder for NativePrinters

BUG=chromium:875876

Change-Id: I0270db0e970665db155248d75db54da353bd8720
Reviewed-on: https://chromium-review.googlesource.com/c/1245792
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597547}
[modify] https://crrev.com/3f520fed60941525603987858d6623251cbd2886/chrome/browser/chromeos/policy/active_directory_policy_manager.cc
[modify] https://crrev.com/3f520fed60941525603987858d6623251cbd2886/chrome/browser/chromeos/policy/active_directory_policy_manager.h
[modify] https://crrev.com/3f520fed60941525603987858d6623251cbd2886/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
[modify] https://crrev.com/3f520fed60941525603987858d6623251cbd2886/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h
[modify] https://crrev.com/3f520fed60941525603987858d6623251cbd2886/chrome/browser/chromeos/policy/browser_policy_connector_chromeos_browsertest.cc
[modify] https://crrev.com/3f520fed60941525603987858d6623251cbd2886/chrome/browser/chromeos/policy/hostname_handler.cc
[modify] https://crrev.com/3f520fed60941525603987858d6623251cbd2886/chrome/browser/chromeos/policy/hostname_handler.h
[modify] https://crrev.com/3f520fed60941525603987858d6623251cbd2886/chrome/browser/chromeos/policy/hostname_handler_unittest.cc
[modify] https://crrev.com/3f520fed60941525603987858d6623251cbd2886/components/policy/resources/policy_templates.json

M-71 is going to Stable this week.  Is this feature completed or should it be moved to target another milestone?
This is completed. I keep it open so I won't forget to remove "machine_name" (lowercase) handling. I'm gonna do that now

Sign in to add a comment