New issue
Advanced search Search tips

Issue 875858 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Aug 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Change that modified paladin builder configs skipped the CQ

Project Member Reported by derat@chromium.org, Aug 20

Issue description

https://crrev.com/c/1180518 removed warn_only attributes from a suite that runs on the Chrome OS Commit Queue. When I set the Commit-Queue+1 bit on it this morning, it was committed immediately, which was unexpected to me since it's changing the behavior of the CQ. I think that any changes to -paladin builder configs in config_dump.json ought to themselves go through the CQ... right?
 
Status: WontFix (was: Untriaged)
This is WAI: http://cs/chromeos_public/chromite/config/COMMIT-QUEUE.ini?l=10&rcl=f8268f7ccb655e300527e2374056fb3b4be1a658 . It ran tests in PreCQ and submitted because they had already passed.

I think that the setup is correct until we move most of the configuration to be database-based instead of config-file-based. Once that's done, config changes will also be instantaneous.


Our system today isn't smart enough to detect that your change affected a CQ builder specifically, it only looks at the directory the files are in.

Build config changes are submitted from the PreCQ because of chances of conflicts and rebase problems in config_dump.json are so high, and quick submission helps avoid them.

Generally speaking, that's been a win.
Got it, thanks! It looks like the Tast suites were passing at the time of the change being committed, so hopefully no harm done. I'll keep this in mind when making future changes to paladin configs.
I think this is the first bug I've gotten saying a CL was submitted too quickly. ;>

Sign in to add a comment