Change that modified paladin builder configs skipped the CQ |
|
Issue descriptionhttps://crrev.com/c/1180518 removed warn_only attributes from a suite that runs on the Chrome OS Commit Queue. When I set the Commit-Queue+1 bit on it this morning, it was committed immediately, which was unexpected to me since it's changing the behavior of the CQ. I think that any changes to -paladin builder configs in config_dump.json ought to themselves go through the CQ... right?
,
Aug 20
Our system today isn't smart enough to detect that your change affected a CQ builder specifically, it only looks at the directory the files are in. Build config changes are submitted from the PreCQ because of chances of conflicts and rebase problems in config_dump.json are so high, and quick submission helps avoid them. Generally speaking, that's been a win.
,
Aug 20
Got it, thanks! It looks like the Tast suites were passing at the time of the change being committed, so hopefully no harm done. I'll keep this in mind when making future changes to paladin configs.
,
Aug 20
I think this is the first bug I've gotten saying a CL was submitted too quickly. ;> |
|
►
Sign in to add a comment |
|
Comment 1 by jclinton@chromium.org
, Aug 20