New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 875849 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 21
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 856777



Sign in to add a comment

Add NetLog events to NetworkDelegate cookie blocking paths

Project Member Reported by xunji...@chromium.org, Aug 20

Issue description

This is split off from Bug 856777.

 Bug 801910  added NetLog events to CookieMonster/CookieStore. The remaining path that cookies can be blocked is NetworkDelegate. Filing a sub bug to do it so the master bug can track DevTools work.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d184f073fbb8fd0a74862a41943e32ef9b83cb87

commit d184f073fbb8fd0a74862a41943e32ef9b83cb87
Author: Helen Li <xunjieli@chromium.org>
Date: Tue Aug 21 17:21:00 2018

Add NetLog events for cookie blocking by NetworkDelegate

Cookies setting and getting can be blocked by a NetworkDelegate.
This CL adds NetLog events so they can aid in the investigation of cookies bugs.

Bug:  875849 
Change-Id: Ia2a09b443fb1ebfe8ce9dde1617920264f6f24a7
Reviewed-on: https://chromium-review.googlesource.com/1181244
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584809}
[modify] https://crrev.com/d184f073fbb8fd0a74862a41943e32ef9b83cb87/net/log/net_log_event_type_list.h
[modify] https://crrev.com/d184f073fbb8fd0a74862a41943e32ef9b83cb87/net/url_request/url_request.cc
[modify] https://crrev.com/d184f073fbb8fd0a74862a41943e32ef9b83cb87/net/url_request/url_request_unittest.cc

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1280d17a159c4db866e3ae90a33538a55b58b00d

commit 1280d17a159c4db866e3ae90a33538a55b58b00d
Author: Sky Malice <skym@chromium.org>
Date: Wed Aug 22 00:07:40 2018

Revert "Add NetLog events for cookie blocking by NetworkDelegate"

This reverts commit d184f073fbb8fd0a74862a41943e32ef9b83cb87.

Reason for revert: Speculative revert to fix net_unittests

BUG:  876563 

Original change's description:
> Add NetLog events for cookie blocking by NetworkDelegate
> 
> Cookies setting and getting can be blocked by a NetworkDelegate.
> This CL adds NetLog events so they can aid in the investigation of cookies bugs.
> 
> Bug:  875849 
> Change-Id: Ia2a09b443fb1ebfe8ce9dde1617920264f6f24a7
> Reviewed-on: https://chromium-review.googlesource.com/1181244
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Commit-Queue: Helen Li <xunjieli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#584809}

TBR=mmenke@chromium.org,xunjieli@chromium.org

Change-Id: Ifbfcf98ec819cda47cb04e4c87e6274db0e93579
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  875849 
Reviewed-on: https://chromium-review.googlesource.com/1184274
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584929}
[modify] https://crrev.com/1280d17a159c4db866e3ae90a33538a55b58b00d/net/log/net_log_event_type_list.h
[modify] https://crrev.com/1280d17a159c4db866e3ae90a33538a55b58b00d/net/url_request/url_request.cc
[modify] https://crrev.com/1280d17a159c4db866e3ae90a33538a55b58b00d/net/url_request/url_request_unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/830d5708d6049560ca9570eeca9a09920e30c955

commit 830d5708d6049560ca9570eeca9a09920e30c955
Author: Helen Li <xunjieli@chromium.org>
Date: Wed Aug 22 16:29:18 2018

Reland "Add NetLog events for cookie blocking by NetworkDelegate"

This is a reland of d184f073fbb8fd0a74862a41943e32ef9b83cb87
The CL was speculatively reverted for an unrelated bug (876563)

TBR=mmenke@chromium.org

Original change's description:
> Add NetLog events for cookie blocking by NetworkDelegate
>
> Cookies setting and getting can be blocked by a NetworkDelegate.
> This CL adds NetLog events so they can aid in the investigation of cookies bugs.
>
> Bug:  875849 
> Change-Id: Ia2a09b443fb1ebfe8ce9dde1617920264f6f24a7
> Reviewed-on: https://chromium-review.googlesource.com/1181244
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Commit-Queue: Helen Li <xunjieli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#584809}

Bug:  875849 
Change-Id: I19e285f078599084d53c9e68a8082ef43d86e067
Reviewed-on: https://chromium-review.googlesource.com/1185102
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585049}
[modify] https://crrev.com/830d5708d6049560ca9570eeca9a09920e30c955/net/log/net_log_event_type_list.h
[modify] https://crrev.com/830d5708d6049560ca9570eeca9a09920e30c955/net/url_request/url_request.cc
[modify] https://crrev.com/830d5708d6049560ca9570eeca9a09920e30c955/net/url_request/url_request_unittest.cc

Sign in to add a comment