(Clicking "use classic" for theme does seem to fix things)

Tom, can you figure out what's up here?

+CC other people who have been working on related things.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/442ac4712c7041596675609cef07b9d0949c3053

commit 442ac4712c7041596675609cef07b9d0949c3053
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Tue Aug 21 04:04:00 2018

GTK: Supply correct frame colors when using the system frame

The GTK theme draws a different top area depending on if Chrome or the window
manager draws the frame [1].  On themes like KDE's Breeze, these colors can be
very different.  This can cause colors calculated from the frame color (like the
inactive tab text color) to be calculated incorrectly.

This CL caches the system and Chrome frame colors in GtkUi and gets the
appropriate one depending on the user's preferences.

Also fix the GTK2 build.

[1] https://cs.chromium.org/chromium/src/chrome/browser/ui/libgtkui/native_theme_gtk3.cc?rcl=ae5bd514aea0486e53a743ddc2870ac3029eb9b3&l=654

BUG= 875844 
R=pkasting

Change-Id: Ia3e8065de1f843618277b6c562bb9fb54671691d
Reviewed-on: https://chromium-review.googlesource.com/1182508
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584646}
[modify] https://crrev.com/442ac4712c7041596675609cef07b9d0949c3053/chrome/browser/themes/theme_service_aurax11.cc
[modify] https://crrev.com/442ac4712c7041596675609cef07b9d0949c3053/chrome/browser/ui/libgtkui/BUILD.gn
[modify] https://crrev.com/442ac4712c7041596675609cef07b9d0949c3053/chrome/browser/ui/libgtkui/gtk_ui.cc
[modify] https://crrev.com/442ac4712c7041596675609cef07b9d0949c3053/chrome/browser/ui/libgtkui/gtk_ui.h
[modify] https://crrev.com/442ac4712c7041596675609cef07b9d0949c3053/chrome/browser/ui/libgtkui/native_theme_gtk2.cc
[modify] https://crrev.com/442ac4712c7041596675609cef07b9d0949c3053/ui/views/linux_ui/linux_ui.h

Requesting merge of the CL in c#4 to M69.  The fix is Linux-only and should be pretty safe.

This bug would affect a considerable percentage of users considering KDE is a fairly common environment.  I wouldn't want to ship without the fix merged, so also adding ReleaseBlock-Stable.

This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Pls update bug with canary result on Wednesday morning.

M69 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Merge has to happen latest by 4:00 PM PT Friday (08/24/18) in order to make it to next week stable cut. Thank you.

> Pls update bug with canary result on Wednesday morning.

Linux doesn't have a canary channel :(

Discussed with govind@ offline.  Though Linux doesn't have a Canary channel, we still do nightly builds.  I'll test on one of those tomorrow.

The NextAction date has arrived: 2018-08-22

Verified in 70.0.3530.0

Deleted: Screenshot from 2018-08-22 11-33-36.png 250 KB

	Screenshot from 2018-08-22 11-33-36.png 250 KB View Download

Approving merge to M69 branch 3497 based on comment #13. Pls merge now and mark bug as fixed after the merge. Thank you.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22c1d41d398a68b45f5dc08c78aaae5be85f7ca7

commit 22c1d41d398a68b45f5dc08c78aaae5be85f7ca7
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Wed Aug 22 18:45:32 2018

[Merge to M69] GTK: Supply correct frame colors when using the system frame

> The GTK theme draws a different top area depending on if Chrome or the window
> manager draws the frame [1].  On themes like KDE's Breeze, these colors can be
> very different.  This can cause colors calculated from the frame color (like the
> inactive tab text color) to be calculated incorrectly.
>
> This CL caches the system and Chrome frame colors in GtkUi and gets the
> appropriate one depending on the user's preferences.
>
> Also fix the GTK2 build.
>
> [1] https://cs.chromium.org/chromium/src/chrome/browser/ui/libgtkui/native_theme_gtk3.cc?rcl=ae5bd514aea0486e53a743ddc2870ac3029eb9b3&l=654
>
> BUG= 875844 
> R=pkasting
>
> Change-Id: Ia3e8065de1f843618277b6c562bb9fb54671691d
> Reviewed-on: https://chromium-review.googlesource.com/1182508
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#584646}

BUG= 875844 
TBR=pkasting
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: I8ceb6840fc8fd62cb1add50f835a478f2d09bc30
Reviewed-on: https://chromium-review.googlesource.com/1185524
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#773}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/22c1d41d398a68b45f5dc08c78aaae5be85f7ca7/chrome/browser/themes/theme_service_aurax11.cc
[modify] https://crrev.com/22c1d41d398a68b45f5dc08c78aaae5be85f7ca7/chrome/browser/ui/libgtkui/BUILD.gn
[modify] https://crrev.com/22c1d41d398a68b45f5dc08c78aaae5be85f7ca7/chrome/browser/ui/libgtkui/gtk_ui.cc
[modify] https://crrev.com/22c1d41d398a68b45f5dc08c78aaae5be85f7ca7/chrome/browser/ui/libgtkui/gtk_ui.h
[modify] https://crrev.com/22c1d41d398a68b45f5dc08c78aaae5be85f7ca7/chrome/browser/ui/libgtkui/native_theme_gtk2.cc
[modify] https://crrev.com/22c1d41d398a68b45f5dc08c78aaae5be85f7ca7/ui/views/linux_ui/linux_ui.h

Unable to reproduce the issue on chrome version# 69.0.3497.42 using Ubuntu 14.04 with steps mentioned below:
1) Launched chrome version# 69.0.3497.32 and updated to 69.0.3497.42
2) Opened few tabs, able to see text on inactive tabs.

@Tom Anderson: Could you please find the attached screenshot for your reference and help us in verifying the fix.

Thanks!

Deleted: 875844.png 185 KB

	875844.png 185 KB View Download

Please see c#13 for the verification.

Verified on 69.0.3497.57 Beta

Deleted: Screenshot from 2018-08-23 10-29-35.png 271 KB

	Screenshot from 2018-08-23 10-29-35.png 271 KB View Download