New issue
Advanced search Search tips

Issue 875805 link

Starred by 1 user
Status: Fixed
Owner:
futhark@chromium.org
Closed: Aug 21
Cc:
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

StyleEngineTest / DummyPageHolder cannot connect to

Project Member Reported by drott@chromium.org, Aug 20 
Chrome Version: (copy from chrome://version)
OS: (e.g. Win10, MacOS 10.12, etc...)

What steps will reproduce the problem?
StyleEngineTest uses a @font-face declaration with a       
src: local(monospace);
declaration.

However, src: local() lookups are moving to a cross-process lookup system in which the renderer process requests a lookup table from the browser process.

The DummyPageHolder test harness is insufficient in setting up such a service instance and the src: local() lookup will fail and fallback to a standard font.

Comment 1 by futhark@chromium.org, Aug 21

Cc: -futhark@chromium.org
Owner: futhark@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ab05d34f5f87e1ed8f75e6d4da97fc5fe0b0d93

commit 2ab05d34f5f87e1ed8f75e6d4da97fc5fe0b0d93
Author: Rune Lillesveen <futhark@chromium.org>
Date: Tue Aug 21 08:18:29 2018

Using local() fonts in unit tests doesn't work.

The test is not relying on fonts loading, but start using dummy urls
instead.

Bug:  875805 
Change-Id: I4821e9e74fc9383d77ec2afd57652103e72f35c2
Reviewed-on: https://chromium-review.googlesource.com/1182807
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584683}
[modify] https://crrev.com/2ab05d34f5f87e1ed8f75e6d4da97fc5fe0b0d93/third_party/blink/renderer/core/css/style_engine_test.cc

Comment 3 by futhark@chromium.org, Aug 21

Status: Fixed (was: Started)
►

Sign in to add a comment