New issue
Advanced search Search tips

Issue 875801 link

Starred by 2 users
Status: Fixed
Owner:
dbeam@chromium.org
Closed: Dec 27
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
rbpotter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : In print preview, scrollbar and it's associated 'Page number' tool tip is not seen together for RTL language.

Reported by avsha...@etouch.net, Aug 20 
Chrome Version : 70.0.3528.0 (Official Build) 354e37b4e7e3c9faacf4837f19c2ff88d6e61dda-refs/branch-heads/3528@{#1} 32/64 bit
OS : Windows (7, 8, 8.1, 10), Linux(14.04 LTS), Mac(10.12.6, 10.13.1, 10.13.6, 10.14)

Precondition : 
1. Enable "#enable-new-print-preview" flag from chrome://flags.
2. Change browser language to 'Arabic' from chrome://settings page.

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://flags page and open print preview using 'CTRL + P' keys.
2. Scroll down print preview contents and observe the 'Vertical scrollbar' and associated 'Page number' tool tip.

Actual Result : Scroll bar and it's associated 'Page number' tool tip is not seen together for RTL language. (i.e. scrollbar is seen at LHS and the tooltip is present at RHS)

Expected Result : Scroll bar and it's associated 'Page number' tool tip should be seen together for RTL language.

This is a regression issue broken in ‘M-70’ and below is the bisect info:
Good Build : 70.0.3502.3 (Revision : 577760)
Bad Build : 70.0.3503.0 (Revision : 578159)

Change Log URL :
https://chromium.googlesource.com/chromium/src/+log/081f7dc4810ce63a3c976a077576bc0ad8ed6f6a..e0a4d9cf005bf241cd06a6777196e12673c2eeee

Suspecting : https://chromium.googlesource.com/chromium/src/+/e0a4d9cf005bf241cd06a6777196e12673c2eeee

Stefan@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : Issue is also observed in Dev build #70.0.3521.2

Thank you..!
Actual_Result.mp4
2.0 MB View Download
Expected_Result.mp4
1.6 MB View Download

Comment 1 by rbpotter@chromium.org, Aug 20

Components: Internals>Plugins>PDF
Precondition (1) is not actually necessary to reproduce this bug. It happens with the old Print Preview UI also.

Adding PDF plugin component since this part of the print preview dialog is actually the PDF plugin.

Comment 2 by szager@chromium.org, Sep 11

Owner: ----
Status: Untriaged (was: Assigned)
The suspect CL is almost certainly correct, but this will need to be fixed in the print preview code. Adding the PrintPreview component and unassigning for triage.

Comment 3 by thestig@chromium.org, Dec 22

Labels: -Pri-1 -Target-70 -M-70 Target-73 Pri-2
Status: Available (was: Untriaged)
The relevant code is in chrome/browser/resources/pdf/elements/viewer-page-indicator/viewer-page-indicator.html

When fixing this, be sure to test on Mac, as there is code in chrome/browser/resources/pdf/elements/viewer-page-indicator/viewer-page-indicator.js for  bug 465394 .

Comment 4 by thestig@chromium.org, Dec 22

Cc: dbeam@chromium.org

Comment 5 by dbeam@chromium.org, Dec 26

Cc: -dbeam@chromium.org rbpotter@chromium.org
Owner: dbeam@chromium.org
Status: Assigned (was: Available)

Comment 6 by dbeam@chromium.org, Dec 27

Status: Started (was: Assigned)

Comment 8 by dbeam@chromium.org, Dec 27

Status: Fixed (was: Started)

Comment 9 by sav...@virtusa.com, Dec 28

Labels: TE-Verified-73.0.3654.0 TE-Verified-M73
---------
Update :
---------
Verified above issue in latest Canary build #73.0.3654.0 on Mac(10.13.1, 10.13.6, 10.14.3), Windows(7,8,8.1,10) & Linux(14.04 LTS) OS and the issue is fixed.
Now, in print-preview, scrollbar and it's associated 'Page number' tooltip is seen together for RTL language, hence adding TE-Verified labels. Kindly review an attached screen-cast for reference.

Thank you..!
Canary Behaviour.mp4
1.7 MB View Download
►

Sign in to add a comment