New issue
Advanced search Search tips

Issue 875800 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [Print Preview] Unnecessary underline appears on 'More settings' button even when it is disabled.

Reported by dchau...@etouch.net, Aug 20

Issue description

Chrome Version: 70.0.3528.0 (Official Build) Revision	354e37b4e7e3c9faacf4837f19c2ff88d6e61dda-refs/branch-heads/3528@{#1} 32/64-bit.
OS: Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1,10.14, 10.13.6), Linux(14.04 LTS).

Pre-condition: Enable 'Enable new Print Preview UI' flag from chrome://flags.

What steps will reproduce the problem?
1. Launch Chrome and give print command on any webpage using "Ctrl/Command + P" key from keyboard.
2. Enter invalid page range in 'Pages' text-box so that 'More settings' button gets disabled.
3. Now hover the mouse pointer on 'More settings' button and observe.

Actual: Unnecessary underline appears on 'More settings' button even when it's disabled.
Expected: Underline should not appear on 'More settings' button when it's disabled.

This is a regression issue, broken in M-70 series, below is manual regression range:

Good build: 70.0.3502.0 (Revision: 577760)
Bad build: 70.0.3503.0 (Revision: 578159)

Using the per-revision bisect providing the bisect results:

You are probably looking for a change made after 578055 (known good), but no later than 578056 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/475eede957aa3b5a8f9cf08651970948d7704efe..8d2a282ddc7d679cf0f9d0bab8dd99e40455d00b

Suspecting: https://chromium.googlesource.com/chromium/src/+/8d2a282ddc7d679cf0f9d0bab8dd99e40455d00b

@rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Kindly review the attached screen-cast for reference.

Thank you.
 
Actual behavior.mp4
734 KB View Download
Expected behavior.mp4
506 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e509e9567f3ee32f599204175b796dbfbe782ec

commit 0e509e9567f3ee32f599204175b796dbfbe782ec
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Aug 22 23:04:44 2018

Print Preview: Fix more settings styling when disabled

- Remove underline
- Use default cursor since the button is not clickable when disabled.

Bug:  875800 
Change-Id: Id01f15cbde8afeb7a0e5341e4e04fd91c3b00ea0
Reviewed-on: https://chromium-review.googlesource.com/1182451
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585294}
[modify] https://crrev.com/0e509e9567f3ee32f599204175b796dbfbe782ec/chrome/browser/resources/print_preview/new/more_settings.html

Labels: TE-Verified-M70 TE-Verified-70.0.3532.0
Tested above issue in latest Canary build #70.0.3532.0 on Windows (7, 8, 8.1, 10), Mac(10.12.6, 10.13.1, 10.13.6, 10.14) and Linux(14.04 LTS) OS and the issue is fixed. 
Hence adding TE-Verified labels. Kindly review an attached screen-cast for reference.

Thank you..!
Latest_behaviour.mp4
496 KB View Download
Status: Verified (was: Assigned)

Sign in to add a comment