New issue
Advanced search Search tips

Issue 875778 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression


Participants' hotlists:
LoginRefresh


Sign in to add a comment

'Ctrl+Shift+Alt+R' crashes lock screen

Project Member Reported by mmanchala@chromium.org, Aug 20

Issue description

Chrome Version: 70.0.3524.2/10983.0.0 dev-channel Daisy,Kip and  Celes
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> At Uber Tray select 'Lock' option 
(2)Now in Lock Screen press 'Ctrl+Shift+Alt+R' key to Power wash the Device -> Observe Sign out screen is seen
(Please refer Video)

Expected: Nothing should happen in Lock screen after pressing 'Ctrl+Shift+Alt+R' key 
Actual: Instead Sign out screen is seen

This is Regression Issue as same is working fine in M-69
 
Actual_SignOutScreen.mp4
8.9 MB View Download
Expected_LockScreen.mp4
10.7 MB View Download
Owner: jdufault@chromium.org
Status: Started (was: Untriaged)
Labels: -M-70 M-69
Looking at commit history this should also repro on M-69.
Summary: 'Ctrl+Shift+Alt+R' crashes lock screen (was: Regression : Unnecessary Sign out screen is seen after pressing 'Ctrl+Shift+Alt+R' key in Lock screen)
Issue 875791 has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc16d7048cac4a09ff9095c4851bc576c54d08eb

commit cc16d7048cac4a09ff9095c4851bc576c54d08eb
Author: Jacob Dufault <jdufault@google.com>
Date: Mon Aug 20 22:30:51 2018

cros: Do not enable login-screen shortcuts on lock.

Calling the shortcut may cause chrome to crash, as the chrome-side handler
assumes the login screen is active.

Bug:  875778 
Change-Id: Ib297d5239c9198d0cd047bd2b5e240dbc1d49ca8
Reviewed-on: https://chromium-review.googlesource.com/1182184
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584577}
[modify] https://crrev.com/cc16d7048cac4a09ff9095c4851bc576c54d08eb/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/cc16d7048cac4a09ff9095c4851bc576c54d08eb/ash/login/ui/lock_contents_view_unittest.cc

Labels: Merge-Request-69
Project Member

Comment 7 by sheriffbot@chromium.org, Aug 21

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Started)
Labels: -Merge-Review-69 Merge-Approved-69
Merge approved, M69.
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 22

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24ae40f8bbc4590362a94589deb0eaa1bd09a9cd

commit 24ae40f8bbc4590362a94589deb0eaa1bd09a9cd
Author: Jacob Dufault <jdufault@google.com>
Date: Wed Aug 22 22:42:04 2018

cros: Do not enable login-screen shortcuts on lock.

Calling the shortcut may cause chrome to crash, as the chrome-side handler
assumes the login screen is active.

TBR=jdufault@google.com

(cherry picked from commit cc16d7048cac4a09ff9095c4851bc576c54d08eb)

Bug:  875778 
Change-Id: Ib297d5239c9198d0cd047bd2b5e240dbc1d49ca8
Reviewed-on: https://chromium-review.googlesource.com/1182184
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#584577}
Reviewed-on: https://chromium-review.googlesource.com/1185974
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#781}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/24ae40f8bbc4590362a94589deb0eaa1bd09a9cd/ash/login/ui/lock_contents_view.cc

Sign in to add a comment