New issue
Advanced search Search tips

Issue 875777 link

Starred by 1 user
Status: Duplicate
Merged: issue 836996
Owner:
sahel@chromium.org
Closed: Aug 21
Cc:
yosin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 836996



Sign in to add a comment

"FlingControllerTest.EarlyTouchpadFlingCancelationOnInertialGSUAckNotConsumed" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Aug 20 
"FlingControllerTest.EarlyTouchpadFlingCancelationOnInertialGSUAckNotConsumed" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVwsSBUZsYWtlIkxGbGluZ0NvbnRyb2xsZXJUZXN0LkVhcmx5VG91Y2hwYWRGbGluZ0NhbmNlbGF0aW9uT25JbmVydGlhbEdTVUFja05vdENvbnN1bWVkDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by yosin@chromium.org, Aug 21

Owner: yosin@chromium.org
Status: Started (was: Untriaged)
Investigating...

Comment 2 by yosin@chromium.org, Aug 21 

Per test failure message, it seems some floating point number rounding related on machine.

[ RUN      ] FlingControllerTest.EarlyTouchpadFlingCancelationOnInertialGSUAckNotConsumed
../../content/browser/renderer_host/input/fling_controller_unittest.cc:303: Failure
Expected: (last_sent_wheel_.delta_x) > (0.f), actual: -0.121721 vs 0

Comment 3 by yosin@chromium.org, Aug 21

Blocking: 836996

Comment 4 by yosin@chromium.org, Aug 21 

Disabling... http://crrev.com/c/1182713
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb656ddad84a5a1ca86fe222fd6d46e2af8410ec

commit fb656ddad84a5a1ca86fe222fd6d46e2af8410ec
Author: Yoshifumi Inoue <yosin@chromium.org>
Date: Tue Aug 21 03:17:18 2018

[Flaky] Disable FlingControllerTest.EarlyTouchpadFlingCancelationOnInertialGSUAckNotConsumed

The test should use better way to compare floating point numbers to handling below
case:
../../content/browser/renderer_host/input/fling_controller_unittest.cc:303: Failure
Expected: (last_sent_wheel_.delta_x) > (0.f), actual: -0.121721 vs 0

TBR=sahel@chromium.org,dtapuska@chromium.org

Bug:  836996 ,  875777 
Change-Id: Ib9eab4988b1809a753068f7cc2da5815ee7780f1
Reviewed-on: https://chromium-review.googlesource.com/1182713
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584625}
[modify] https://crrev.com/fb656ddad84a5a1ca86fe222fd6d46e2af8410ec/content/browser/renderer_host/input/fling_controller_unittest.cc

Comment 6 by yosin@chromium.org, Aug 21

Status: Fixed (was: Started)

Comment 7 by sahel@chromium.org, Aug 23

Cc: yosin@chromium.org
Mergedinto: 836996
Owner: sahel@chromium.org
Status: Duplicate (was: Fixed)
The issue is not related to floating point accuracy, the issue is time related, the fling curve goes back in time and that's why the created scroll delta is negative.
►

Sign in to add a comment