Issue metadata
Sign in to add a comment
|
Regression: Cast overlay is seen unresponsive i.e. unable to click on options from overlay.
Reported by
db...@etouch.net,
Aug 20
|
||||||||||||||||||||||||
Issue descriptionChrome Version: 70.0.3528.0 Revision 354e37b4e7e3c9faacf4837f19c2ff88d6e61dda-refs/branch-heads/3528@{#1}(64 bit) OS:Mac(10.12.6, 10.13.1, 10.13.6, 10.14) What steps will reproduce the problem? (1) Launch chrome, click on 'Cast' option from wrench menu. (2) Click Cast to drop down and observe. Actual: Cast overlay is seen unresponsive i.e. unable to click on options from overlay. Expected: Cast overlay should work properly. This is a regression issue, broken in 'M70', will soon update the other info: Good Build: 70.0.3526.0 (Revision: 584273) Bad Build: 70.0.3527.0 (Revision: 584327) NOTE: Issue is not seen on Win (7, 8, 8.1, 10) & Linux (14.04 LTS) OS.
,
Aug 20
,
Aug 20
Have a fix ready.
,
Aug 20
,
Aug 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2bae22e479aaca78d061b379bead022dd5acd40 commit f2bae22e479aaca78d061b379bead022dd5acd40 Author: Christopher Cameron <ccameron@chromium.org> Date: Mon Aug 20 23:22:37 2018 RemoteMacViews: Ensure window and view updates are synchronized When updating the views::View size, ensure that the NSWindow size be updated first (otherwise we end up with strange mismatches). Add a TODO about merging methods here. This requires access to the BridgedNativeWidget from BridgedContentView, so make BridgedNativeWidget store a pointer to BridgedContentView (from which it can access BridgedContentViewHost), rather than storing a pointer to BridgedContentViewHost. Also change one instance where we pulled the BridgedContentView from the NSWindow to use the pointer directly. Bug: 875776 , 875731 Change-Id: Ia9c3d4238f6824e5595baa5d4e856c34ead0fb75 Reviewed-on: https://chromium-review.googlesource.com/1181926 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#584582} [modify] https://crrev.com/f2bae22e479aaca78d061b379bead022dd5acd40/ui/views/cocoa/bridged_content_view.h [modify] https://crrev.com/f2bae22e479aaca78d061b379bead022dd5acd40/ui/views/cocoa/bridged_content_view.mm [modify] https://crrev.com/f2bae22e479aaca78d061b379bead022dd5acd40/ui/views/cocoa/bridged_native_widget.h [modify] https://crrev.com/f2bae22e479aaca78d061b379bead022dd5acd40/ui/views/cocoa/bridged_native_widget.mm
,
Aug 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/917518a286adb36cd3e7ccff6cdbe6e733539ec3 commit 917518a286adb36cd3e7ccff6cdbe6e733539ec3 Author: Christopher Cameron <ccameron@chromium.org> Date: Tue Aug 21 00:00:02 2018 RemoteMacViews: Ensure window and view updates are synchronized When updating the views::View size, ensure that the NSWindow size be updated first (otherwise we end up with strange mismatches). Add a TODO about merging methods here. This requires access to the BridgedNativeWidget from BridgedContentView, so make BridgedNativeWidget store a pointer to BridgedContentView (from which it can access BridgedContentViewHost), rather than storing a pointer to BridgedContentViewHost. Also change one instance where we pulled the BridgedContentView from the NSWindow to use the pointer directly. TBR=ccameron@chromium.org (cherry picked from commit f2bae22e479aaca78d061b379bead022dd5acd40) Bug: 875776 , 875731 Change-Id: Ia9c3d4238f6824e5595baa5d4e856c34ead0fb75 Reviewed-on: https://chromium-review.googlesource.com/1181926 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#584582} Reviewed-on: https://chromium-review.googlesource.com/1182582 Reviewed-by: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/branch-heads/3528@{#8} Cr-Branched-From: 2d67fa3c43ccc16edae0a742d902dd437795959b-refs/heads/master@{#584349} [modify] https://crrev.com/917518a286adb36cd3e7ccff6cdbe6e733539ec3/ui/views/cocoa/bridged_content_view.h [modify] https://crrev.com/917518a286adb36cd3e7ccff6cdbe6e733539ec3/ui/views/cocoa/bridged_content_view.mm [modify] https://crrev.com/917518a286adb36cd3e7ccff6cdbe6e733539ec3/ui/views/cocoa/bridged_native_widget.h [modify] https://crrev.com/917518a286adb36cd3e7ccff6cdbe6e733539ec3/ui/views/cocoa/bridged_native_widget.mm
,
Aug 21
Update: Above issue is fix on Mac(10.12.6, 10.13.1, 10.13.6, 10.14) using latest build #70.0.3528.4 and #70.0.3529.3 and working as intended. Thank you. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by db...@etouch.net
, Aug 20Owner: ccameron@chromium.org
Status: Assigned (was: Unconfirmed)
4.2 MB
4.2 MB View Download
3.3 MB
3.3 MB View Download