New issue
Advanced search Search tips

Issue 875776 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 875731
Owner:
Closed: Aug 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Cast overlay is seen unresponsive i.e. unable to click on options from overlay.

Reported by db...@etouch.net, Aug 20

Issue description

Chrome Version: 70.0.3528.0 Revision 354e37b4e7e3c9faacf4837f19c2ff88d6e61dda-refs/branch-heads/3528@{#1}(64 bit)
OS:Mac(10.12.6, 10.13.1, 10.13.6, 10.14) 

 What steps will reproduce the problem?
(1) Launch chrome, click on 'Cast' option from wrench menu.
(2) Click Cast to drop down and observe.

Actual: Cast overlay is seen unresponsive i.e. unable to click on options from overlay.

Expected: Cast overlay should work properly.

This is a regression issue, broken in 'M70', will soon update the other info:

Good Build: 70.0.3526.0 (Revision: 584273)
Bad Build:  70.0.3527.0 (Revision: 584327)

NOTE: Issue is not seen on Win (7, 8, 8.1, 10) & Linux (14.04 LTS) OS.


 
Labels: hasbisect-per-revision
Owner: ccameron@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 584307 (known good), but no later than 584308 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/7f48b3540a8dd9e759fc592cb6ec895fed46b3d8..78a0d81fb18f78c01c6b2b3908c9e4f4d13dc97e

Suspect: https://chromium.googlesource.com/chromium/src/+/78a0d81fb18f78c01c6b2b3908c9e4f4d13dc97e

@ccameron: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE: Issue is not seen on Win (7, 8, 8.1, 10) & Linux (14.04 LTS) OS.

Kindly refer the attached screen-cast.
Actual_Cast.mov
4.2 MB View Download
Expected_Cast.mov
3.3 MB View Download
Components: -Internals>Cast Internals>Cast>UI
Have a fix ready.
Mergedinto: 875731
Status: Duplicate (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2bae22e479aaca78d061b379bead022dd5acd40

commit f2bae22e479aaca78d061b379bead022dd5acd40
Author: Christopher Cameron <ccameron@chromium.org>
Date: Mon Aug 20 23:22:37 2018

RemoteMacViews: Ensure window and view updates are synchronized

When updating the views::View size, ensure that the NSWindow size be
updated first (otherwise we end up with strange mismatches). Add a
TODO about merging methods here.

This requires access to the BridgedNativeWidget from
BridgedContentView, so make BridgedNativeWidget store a pointer to
BridgedContentView (from which it can access BridgedContentViewHost),
rather than storing a pointer to BridgedContentViewHost. Also change
one instance where we pulled the BridgedContentView from the NSWindow
to use the pointer directly.

Bug:  875776 ,  875731 
Change-Id: Ia9c3d4238f6824e5595baa5d4e856c34ead0fb75
Reviewed-on: https://chromium-review.googlesource.com/1181926
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584582}
[modify] https://crrev.com/f2bae22e479aaca78d061b379bead022dd5acd40/ui/views/cocoa/bridged_content_view.h
[modify] https://crrev.com/f2bae22e479aaca78d061b379bead022dd5acd40/ui/views/cocoa/bridged_content_view.mm
[modify] https://crrev.com/f2bae22e479aaca78d061b379bead022dd5acd40/ui/views/cocoa/bridged_native_widget.h
[modify] https://crrev.com/f2bae22e479aaca78d061b379bead022dd5acd40/ui/views/cocoa/bridged_native_widget.mm

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 21

Labels: merge-merged-3528
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/917518a286adb36cd3e7ccff6cdbe6e733539ec3

commit 917518a286adb36cd3e7ccff6cdbe6e733539ec3
Author: Christopher Cameron <ccameron@chromium.org>
Date: Tue Aug 21 00:00:02 2018

RemoteMacViews: Ensure window and view updates are synchronized

When updating the views::View size, ensure that the NSWindow size be
updated first (otherwise we end up with strange mismatches). Add a
TODO about merging methods here.

This requires access to the BridgedNativeWidget from
BridgedContentView, so make BridgedNativeWidget store a pointer to
BridgedContentView (from which it can access BridgedContentViewHost),
rather than storing a pointer to BridgedContentViewHost. Also change
one instance where we pulled the BridgedContentView from the NSWindow
to use the pointer directly.

TBR=ccameron@chromium.org

(cherry picked from commit f2bae22e479aaca78d061b379bead022dd5acd40)

Bug:  875776 ,  875731 
Change-Id: Ia9c3d4238f6824e5595baa5d4e856c34ead0fb75
Reviewed-on: https://chromium-review.googlesource.com/1181926
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#584582}
Reviewed-on: https://chromium-review.googlesource.com/1182582
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/branch-heads/3528@{#8}
Cr-Branched-From: 2d67fa3c43ccc16edae0a742d902dd437795959b-refs/heads/master@{#584349}
[modify] https://crrev.com/917518a286adb36cd3e7ccff6cdbe6e733539ec3/ui/views/cocoa/bridged_content_view.h
[modify] https://crrev.com/917518a286adb36cd3e7ccff6cdbe6e733539ec3/ui/views/cocoa/bridged_content_view.mm
[modify] https://crrev.com/917518a286adb36cd3e7ccff6cdbe6e733539ec3/ui/views/cocoa/bridged_native_widget.h
[modify] https://crrev.com/917518a286adb36cd3e7ccff6cdbe6e733539ec3/ui/views/cocoa/bridged_native_widget.mm

Labels: TE-Verified-M70 TE-Verified-70.0.3529.3 TE-Verified-70.0.3528.4
Update:

Above issue is fix on Mac(10.12.6, 10.13.1, 10.13.6, 10.14) using latest build #70.0.3528.4 and #70.0.3529.3 and working as intended.

Thank you.
Actual_Fix.mov
5.2 MB View Download
Fix.mov
6.2 MB View Download

Sign in to add a comment