This is an umbrella bug for any clean-up that is not big and important enough to create a separate bug.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fab8f3148973f26f20d65fb08efcef8f439ecb81 commit fab8f3148973f26f20d65fb08efcef8f439ecb81 Author: Vadym Doroshenko <dvadym@chromium.org> Date: Mon Aug 20 14:43:50 2018 Password Manager code clean-up. It contains a number of tiny clean ups: 1.Using range based for 2.Dropping autofill:: namespace in favor of using 3.Using map lookup instead of range based for by map. 4.Old comment removal in password_manager.cc Bug: 875768 Change-Id: I6d7c481139d59e8de35ec49ad58f9486de04359d Reviewed-on: https://chromium-review.googlesource.com/1177743 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#584439} [modify] https://crrev.com/fab8f3148973f26f20d65fb08efcef8f439ecb81/components/password_manager/core/browser/password_autofill_manager.cc [modify] https://crrev.com/fab8f3148973f26f20d65fb08efcef8f439ecb81/components/password_manager/core/browser/password_manager.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6ccb877f3fb45516a98384ae016f0e1831bc376 commit c6ccb877f3fb45516a98384ae016f0e1831bc376 Author: Vadym Doroshenko <dvadym@chromium.org> Date: Tue Aug 28 21:56:22 2018 Wipe out WipeStoreCopyIfOutdated. Password Manager ignores saving of Chrome sync credentials. But if accounts.google.com credentials were saved before signing in in Chrome, they persist. Which may lead to the problem, that after changing password, saved sync credentials become obsolete. For this reason it was introduced wiping such credentials if Password Manager found submission with different password. The problem that it assumes that Password Manager always correctly detects success of password form submission on accounts.google.com. That's not true anymore. As result valid credentials might be removed. In the current setup probability of this is low, but with other changes it might become much bigger, for example https://crbug.com/871191 is example. So it's the time to remove wiping. Bug: 871191 , 875768, 458279 Change-Id: I24c096f6202bf21a89d091932b22984eed8efe0a Reviewed-on: https://chromium-review.googlesource.com/1183308 Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#586871} [modify] https://crrev.com/c6ccb877f3fb45516a98384ae016f0e1831bc376/components/password_manager/core/browser/form_saver.h [modify] https://crrev.com/c6ccb877f3fb45516a98384ae016f0e1831bc376/components/password_manager/core/browser/form_saver_impl.cc [modify] https://crrev.com/c6ccb877f3fb45516a98384ae016f0e1831bc376/components/password_manager/core/browser/form_saver_impl.h [modify] https://crrev.com/c6ccb877f3fb45516a98384ae016f0e1831bc376/components/password_manager/core/browser/form_saver_impl_unittest.cc [modify] https://crrev.com/c6ccb877f3fb45516a98384ae016f0e1831bc376/components/password_manager/core/browser/password_form_manager.cc [modify] https://crrev.com/c6ccb877f3fb45516a98384ae016f0e1831bc376/components/password_manager/core/browser/password_form_manager.h [modify] https://crrev.com/c6ccb877f3fb45516a98384ae016f0e1831bc376/components/password_manager/core/browser/password_form_manager_unittest.cc [modify] https://crrev.com/c6ccb877f3fb45516a98384ae016f0e1831bc376/components/password_manager/core/browser/password_manager.cc [modify] https://crrev.com/c6ccb877f3fb45516a98384ae016f0e1831bc376/components/password_manager/core/browser/password_manager_unittest.cc [modify] https://crrev.com/c6ccb877f3fb45516a98384ae016f0e1831bc376/components/password_manager/core/browser/stub_form_saver.h [modify] https://crrev.com/c6ccb877f3fb45516a98384ae016f0e1831bc376/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d7ea51d1fbedb0448ddb4fed1fd92e57b297689 commit 0d7ea51d1fbedb0448ddb4fed1fd92e57b297689 Author: Vadym Doroshenko <dvadym@chromium.org> Date: Thu Sep 27 13:31:22 2018 Remove sending sign-in vote in Password Manager. Password Manager sends crowdsourcing votes for sign-in forms with labeling of fields with Autofill votes. The idea to use autofill votes in such situation is deprecated now. And moreover on the CL https://chromium-review.googlesource.com/c/chromium/src/+/1219710 it's allowed to send normal Password Manager votes for sign-in forms. So in order to avoid double vote sending and decrease code complexity it's now time to remove sign-in vote sending. Bug: 889472 , 875768 Change-Id: Ibad10f13b69776a433f6c0a2e2017f234b85a6ec Reviewed-on: https://chromium-review.googlesource.com/1248626 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#594699} [modify] https://crrev.com/0d7ea51d1fbedb0448ddb4fed1fd92e57b297689/components/autofill/core/browser/autofill_manager.cc [modify] https://crrev.com/0d7ea51d1fbedb0448ddb4fed1fd92e57b297689/components/autofill/core/browser/autofill_manager_unittest.cc [modify] https://crrev.com/0d7ea51d1fbedb0448ddb4fed1fd92e57b297689/components/autofill/core/browser/form_structure.cc [modify] https://crrev.com/0d7ea51d1fbedb0448ddb4fed1fd92e57b297689/components/autofill/core/browser/form_structure.h [modify] https://crrev.com/0d7ea51d1fbedb0448ddb4fed1fd92e57b297689/components/autofill/core/browser/form_structure_unittest.cc [modify] https://crrev.com/0d7ea51d1fbedb0448ddb4fed1fd92e57b297689/components/password_manager/core/browser/password_form_manager_unittest.cc [modify] https://crrev.com/0d7ea51d1fbedb0448ddb4fed1fd92e57b297689/components/password_manager/core/browser/votes_uploader.cc [modify] https://crrev.com/0d7ea51d1fbedb0448ddb4fed1fd92e57b297689/components/password_manager/core/browser/votes_uploader.h
Comment 1 by bugdroid1@chromium.org
, Aug 20