New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 875751 link

Starred by 1 user
Status: Started
Owner:
battre@chromium.org
Cc:
█ nepper@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Manual password generation is offered when it should not

Project Member Reported by battre@chromium.org, Aug 20 
There are some cases where manual password generation should not be offered:

- If password saving is disabled in Chrome
- If the site has SSL errors, so we would not fill passwords.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ca3f37d526ef2134b22598f39be35db488e09a9

commit 4ca3f37d526ef2134b22598f39be35db488e09a9
Author: Dominic Battre <battre@chromium.org>
Date: Mon Aug 20 15:35:49 2018

Disable manual password generation in some cases

This CL disables manual password generation in the context menu in case the
user has disabled the password manager or the site has an SSL problem (in which
case Chrome would not fill the credential).

Bug: 875751
Change-Id: I900590e6674ba0d039033fb5bacfb83f39bcba52
Reviewed-on: https://chromium-review.googlesource.com/1180966
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584457}
[modify] https://crrev.com/4ca3f37d526ef2134b22598f39be35db488e09a9/chrome/browser/renderer_context_menu/render_view_context_menu.cc
[modify] https://crrev.com/4ca3f37d526ef2134b22598f39be35db488e09a9/components/password_manager/core/browser/password_manager_util.cc
[modify] https://crrev.com/4ca3f37d526ef2134b22598f39be35db488e09a9/components/password_manager/core/browser/password_manager_util.h
►

Sign in to add a comment