New issue
Advanced search Search tips

Issue 875742 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Remove test-only methods/classes from production code

Project Member Reported by jinsuk...@chromium.org, Aug 20

Issue description

Found that there are several test-only methods/classes that can be moved out of production code. Umbrella bug to record the tasks that move them to test-only targets.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b0f3e82bdad44b9c4933ec91597c4992e02909e

commit 5b0f3e82bdad44b9c4933ec91597c4992e02909e
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Tue Aug 21 05:30:28 2018

Android: Move more methods to test-only targets

Moved new test-only methods added to WebContents/RenderFrameHost
in https://crrev.com/c/1163831 to targets content*test_support.

Bug: 862153, 875742
Change-Id: Id9be5f53b45e2b28861a35401bba71020cf5fc0f
Reviewed-on: https://chromium-review.googlesource.com/1180824
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584660}
[modify] https://crrev.com/5b0f3e82bdad44b9c4933ec91597c4992e02909e/chrome/android/javatests/src/org/chromium/chrome/browser/vr/XrTestFramework.java
[modify] https://crrev.com/5b0f3e82bdad44b9c4933ec91597c4992e02909e/content/public/android/java/src/org/chromium/content/browser/framehost/RenderFrameHostImpl.java
[modify] https://crrev.com/5b0f3e82bdad44b9c4933ec91597c4992e02909e/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
[modify] https://crrev.com/5b0f3e82bdad44b9c4933ec91597c4992e02909e/content/public/android/java/src/org/chromium/content_public/browser/RenderFrameHost.java
[modify] https://crrev.com/5b0f3e82bdad44b9c4933ec91597c4992e02909e/content/public/android/java/src/org/chromium/content_public/browser/WebContents.java
[modify] https://crrev.com/5b0f3e82bdad44b9c4933ec91597c4992e02909e/content/public/test/android/BUILD.gn
[add] https://crrev.com/5b0f3e82bdad44b9c4933ec91597c4992e02909e/content/public/test/android/javatests/src/org/chromium/content/browser/test/RenderFrameHostTestExt.java
[modify] https://crrev.com/5b0f3e82bdad44b9c4933ec91597c4992e02909e/content/public/test/android/javatests/src/org/chromium/content/browser/test/mock/MockRenderFrameHost.java
[modify] https://crrev.com/5b0f3e82bdad44b9c4933ec91597c4992e02909e/content/public/test/android/javatests/src/org/chromium/content/browser/test/mock/MockWebContents.java
[modify] https://crrev.com/5b0f3e82bdad44b9c4933ec91597c4992e02909e/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/WebContentsUtils.java
[add] https://crrev.com/5b0f3e82bdad44b9c4933ec91597c4992e02909e/content/public/test/android/render_frame_host_test_ext.cc
[modify] https://crrev.com/5b0f3e82bdad44b9c4933ec91597c4992e02909e/content/public/test/android/web_contents_utils.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3890683844d752b78a1614cb87d3fd3aee5a9868

commit 3890683844d752b78a1614cb87d3fd3aee5a9868
Author: Brian Sheedy <bsheedy@chromium.org>
Date: Tue Aug 21 17:59:08 2018

Revert "Android: Move more methods to test-only targets"

This reverts commit 5b0f3e82bdad44b9c4933ec91597c4992e02909e.

Reason for revert: Causing VR browser test failures https://bugs.chromium.org/p/chromium/issues/detail?id=876375

Original change's description:
> Android: Move more methods to test-only targets
> 
> Moved new test-only methods added to WebContents/RenderFrameHost
> in https://crrev.com/c/1163831 to targets content*test_support.
> 
> Bug: 862153, 875742
> Change-Id: Id9be5f53b45e2b28861a35401bba71020cf5fc0f
> Reviewed-on: https://chromium-review.googlesource.com/1180824
> Reviewed-by: Bo <boliu@chromium.org>
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#584660}

TBR=mthiesse@chromium.org,boliu@chromium.org,jinsukkim@chromium.org

Change-Id: I6bb9126e3870e9381432f828e6e698bdd5b0aec9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 862153, 875742
Reviewed-on: https://chromium-review.googlesource.com/1183825
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584820}
[modify] https://crrev.com/3890683844d752b78a1614cb87d3fd3aee5a9868/chrome/android/javatests/src/org/chromium/chrome/browser/vr/XrTestFramework.java
[modify] https://crrev.com/3890683844d752b78a1614cb87d3fd3aee5a9868/content/public/android/java/src/org/chromium/content/browser/framehost/RenderFrameHostImpl.java
[modify] https://crrev.com/3890683844d752b78a1614cb87d3fd3aee5a9868/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
[modify] https://crrev.com/3890683844d752b78a1614cb87d3fd3aee5a9868/content/public/android/java/src/org/chromium/content_public/browser/RenderFrameHost.java
[modify] https://crrev.com/3890683844d752b78a1614cb87d3fd3aee5a9868/content/public/android/java/src/org/chromium/content_public/browser/WebContents.java
[modify] https://crrev.com/3890683844d752b78a1614cb87d3fd3aee5a9868/content/public/test/android/BUILD.gn
[delete] https://crrev.com/d80f55ce8353053334c7dae6b39c26c2cac46d63/content/public/test/android/javatests/src/org/chromium/content/browser/test/RenderFrameHostTestExt.java
[modify] https://crrev.com/3890683844d752b78a1614cb87d3fd3aee5a9868/content/public/test/android/javatests/src/org/chromium/content/browser/test/mock/MockRenderFrameHost.java
[modify] https://crrev.com/3890683844d752b78a1614cb87d3fd3aee5a9868/content/public/test/android/javatests/src/org/chromium/content/browser/test/mock/MockWebContents.java
[modify] https://crrev.com/3890683844d752b78a1614cb87d3fd3aee5a9868/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/WebContentsUtils.java
[delete] https://crrev.com/d80f55ce8353053334c7dae6b39c26c2cac46d63/content/public/test/android/render_frame_host_test_ext.cc
[modify] https://crrev.com/3890683844d752b78a1614cb87d3fd3aee5a9868/content/public/test/android/web_contents_utils.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1998e045d88679d26b5b31aa7367fe9b1531f411

commit 1998e045d88679d26b5b31aa7367fe9b1531f411
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Mon Aug 27 02:53:07 2018

Android: Move |isSelectPopupVisible| to a test-only class

Moves |WebContents.isSelectPopupVisibleForTesting| from the public
interface to test-only util class.

Bug: 875742
Change-Id: I51e5368b862cf1bbe4fd94ee0bba8435ae1e35a5
Reviewed-on: https://chromium-review.googlesource.com/1180943
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586183}
[modify] https://crrev.com/1998e045d88679d26b5b31aa7367fe9b1531f411/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
[modify] https://crrev.com/1998e045d88679d26b5b31aa7367fe9b1531f411/chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java
[modify] https://crrev.com/1998e045d88679d26b5b31aa7367fe9b1531f411/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
[modify] https://crrev.com/1998e045d88679d26b5b31aa7367fe9b1531f411/content/public/android/java/src/org/chromium/content_public/browser/WebContents.java
[modify] https://crrev.com/1998e045d88679d26b5b31aa7367fe9b1531f411/content/public/android/javatests/src/org/chromium/content/browser/input/SelectPopupTest.java
[modify] https://crrev.com/1998e045d88679d26b5b31aa7367fe9b1531f411/content/public/test/android/javatests/src/org/chromium/content/browser/test/mock/MockWebContents.java
[modify] https://crrev.com/1998e045d88679d26b5b31aa7367fe9b1531f411/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/WebContentsUtils.java

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b2f45fc5f1425237ff33e366dd5c12909a489e6

commit 5b2f45fc5f1425237ff33e366dd5c12909a489e6
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Tue Aug 28 06:22:04 2018

Reland "Android: Move more methods to test-only targets"

Relanding https://crrev.com/c/1180824 with following bug fixes:

- |chrome_public_test_vr_apk| was not configured to load the test-only
  native library calling the content native support lib added in the CL.
  Recycles the target |libchromefortest| for vr.
- Neglected the reminder TODO in render_frame_host_android.h. This CL
  deletes it. Also minimizes test code present in the production and
  moves more test code from Java to native (java WebContentsUtil to
  native RenderFrameHostTestEx class).

This reverts commit 3890683844d752b78a1614cb87d3fd3aee5a9868.

Bug: 862153, 875742,  876375 
Change-Id: I93746f36f74f33a93973278dc92890c77b8c2646
Reviewed-on: https://chromium-review.googlesource.com/1184131
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586595}
[modify] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/chrome/android/BUILD.gn
[modify] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/chrome/android/javatests/src/org/chromium/chrome/browser/vr/XrTestFramework.java
[modify] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/content/browser/frame_host/render_frame_host_android.cc
[modify] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/content/browser/frame_host/render_frame_host_android.h
[modify] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/content/browser/web_contents/web_contents_android.cc
[modify] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/content/browser/web_contents/web_contents_android.h
[modify] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/content/public/android/java/src/org/chromium/content/browser/framehost/RenderFrameHostImpl.java
[modify] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
[modify] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/content/public/android/java/src/org/chromium/content_public/browser/RenderFrameHost.java
[modify] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/content/public/android/java/src/org/chromium/content_public/browser/WebContents.java
[modify] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/content/public/test/android/BUILD.gn
[add] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/content/public/test/android/javatests/src/org/chromium/content/browser/test/RenderFrameHostTestExt.java
[modify] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/content/public/test/android/javatests/src/org/chromium/content/browser/test/mock/MockRenderFrameHost.java
[modify] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/content/public/test/android/javatests/src/org/chromium/content/browser/test/mock/MockWebContents.java
[modify] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/WebContentsUtils.java
[add] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/content/public/test/android/render_frame_host_test_ext.cc
[add] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/content/public/test/android/render_frame_host_test_ext.h
[modify] https://crrev.com/5b2f45fc5f1425237ff33e366dd5c12909a489e6/content/public/test/android/web_contents_utils.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05e3fb07de904f59ef754ee908c75166426a8ced

commit 05e3fb07de904f59ef754ee908c75166426a8ced
Author: Jinsuk Kim <jinsukkim@chromium.org>
Date: Wed Sep 12 11:49:11 2018

Android: Move evaluateJavaScriptForTests to a test target

Moved |WebContents.evaluateJavaScriptForTests| to a test-only class
WebContentsUtils plus its plumbing logic down to WebContentsAndroid,
and updated callsites accordingly.

A couple of test apks(chrome_sync_shell_test_apk,
webview_instrumetation_test_apk) were updated to load native library
and init JNI to be able to use content native library which
WebContentsUtils is a part of.

It was clarified that WebView is allowed to execute Javascript code
on non-webui frames as well. So replaced some of the API calls in
WebView with the non-test version (WebContents.evaluateJavaScript).

Bug: 875742

Change-Id: I2a4cb97b7f397d8435d737c01e4517117eb58373
Reviewed-on: https://chromium-review.googlesource.com/1203490
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590647}
[modify] https://crrev.com/05e3fb07de904f59ef754ee908c75166426a8ced/android_webview/java/src/org/chromium/android_webview/AwContents.java
[modify] https://crrev.com/05e3fb07de904f59ef754ee908c75166426a8ced/android_webview/javatests/src/org/chromium/android_webview/test/AwActivityTestRule.java
[modify] https://crrev.com/05e3fb07de904f59ef754ee908c75166426a8ced/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java
[modify] https://crrev.com/05e3fb07de904f59ef754ee908c75166426a8ced/android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java
[modify] https://crrev.com/05e3fb07de904f59ef754ee908c75166426a8ced/android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java
[modify] https://crrev.com/05e3fb07de904f59ef754ee908c75166426a8ced/android_webview/javatests/src/org/chromium/android_webview/test/util/JSUtils.java
[modify] https://crrev.com/05e3fb07de904f59ef754ee908c75166426a8ced/android_webview/test/BUILD.gn
[modify] https://crrev.com/05e3fb07de904f59ef754ee908c75166426a8ced/chrome/android/BUILD.gn
[modify] https://crrev.com/05e3fb07de904f59ef754ee908c75166426a8ced/chrome/android/javatests/src/org/chromium/chrome/browser/JavaScriptEvalChromeTest.java
[modify] https://crrev.com/05e3fb07de904f59ef754ee908c75166426a8ced/chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java
[modify] https://crrev.com/05e3fb07de904f59ef754ee908c75166426a8ced/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenManagerTest.java
[add] https://crrev.com/05e3fb07de904f59ef754ee908c75166426a8ced/chrome/android/js_utils.cc
[add] https://crrev.com/05e3fb07de904f59ef754ee908c75166426a8ced/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/JsUtils.java
[modify] https://crrev.com/05e3fb07de904f59ef754ee908c75166426a8ced/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/UkmTest.java
[modify] https://crrev.com/05e3fb07de904f59ef754ee908c75166426a8ced/content/browser/web_contents/web_contents_android.cc
[modify] https://crrev.com/05e3fb07de904f59ef754ee908c75166426a8ced/content/browser/web_contents/web_contents_android.h
[modify] https://crrev.com/05e3fb07de904f59ef754ee908c75166426a8ced/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
[modify] https://crrev.com/05e3fb07de904f59ef754ee908c75166426a8ced/content/public/android/java/src/org/chromium/content_public/browser/WebContents.java
[modify] https://crrev.com/05e3fb07de904f59ef754ee908c75166426a8ced/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeChildFrameTest.java
[modify] https://crrev.com/05e3fb07de904f59ef754ee908c75166426a8ced/content/public/android/javatests/src/org/chromium/content/browser/TestsJavaScriptEvalTest.java
[modify] https://crrev.com/05e3fb07de904f59ef754ee908c75166426a8ced/content/public/test/android/BUILD.gn
[modify] https://crrev.com/05e3fb07de904f59ef754ee908c75166426a8ced/content/public/test/android/javatests/src/org/chromium/content_public/browser/test/mock/MockWebContents.java
[modify] https://crrev.com/05e3fb07de904f59ef754ee908c75166426a8ced/content/public/test/android/javatests/src/org/chromium/content_public/browser/test/util/JavaScriptUtils.java
[modify] https://crrev.com/05e3fb07de904f59ef754ee908c75166426a8ced/content/public/test/android/javatests/src/org/chromium/content_public/browser/test/util/TestCallbackHelperContainer.java
[modify] https://crrev.com/05e3fb07de904f59ef754ee908c75166426a8ced/content/public/test/android/javatests/src/org/chromium/content_public/browser/test/util/WebContentsUtils.java
[modify] https://crrev.com/05e3fb07de904f59ef754ee908c75166426a8ced/content/public/test/android/web_contents_utils.cc
[add] https://crrev.com/05e3fb07de904f59ef754ee908c75166426a8ced/content/public/test/android/web_contents_utils.h

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e50e5ccc1f7787ffc43c241ce03ecdaf456e633

commit 9e50e5ccc1f7787ffc43c241ce03ecdaf456e633
Author: Eric Stevenson <estevenson@chromium.org>
Date: Wed Sep 12 20:41:22 2018

Revert "Android: Move evaluateJavaScriptForTests to a test target"

This reverts commit 05e3fb07de904f59ef754ee908c75166426a8ced.

Reason for revert: Broke downstream builder (crbug.com/883390)

Original change's description:
> Android: Move evaluateJavaScriptForTests to a test target
> 
> Moved |WebContents.evaluateJavaScriptForTests| to a test-only class
> WebContentsUtils plus its plumbing logic down to WebContentsAndroid,
> and updated callsites accordingly.
> 
> A couple of test apks(chrome_sync_shell_test_apk,
> webview_instrumetation_test_apk) were updated to load native library
> and init JNI to be able to use content native library which
> WebContentsUtils is a part of.
> 
> It was clarified that WebView is allowed to execute Javascript code
> on non-webui frames as well. So replaced some of the API calls in
> WebView with the non-test version (WebContents.evaluateJavaScript).
> 
> Bug: 875742
> 
> Change-Id: I2a4cb97b7f397d8435d737c01e4517117eb58373
> Reviewed-on: https://chromium-review.googlesource.com/1203490
> Reviewed-by: agrieve <agrieve@chromium.org>
> Reviewed-by: Bo <boliu@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#590647}

TBR=boliu@chromium.org,tedchoc@chromium.org,agrieve@chromium.org,jinsukkim@chromium.org

Change-Id: I659602799ece7d82f0128c7e9d2d3dcc7a85f207
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 875742
Reviewed-on: https://chromium-review.googlesource.com/1222628
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590811}
[modify] https://crrev.com/9e50e5ccc1f7787ffc43c241ce03ecdaf456e633/android_webview/java/src/org/chromium/android_webview/AwContents.java
[modify] https://crrev.com/9e50e5ccc1f7787ffc43c241ce03ecdaf456e633/android_webview/javatests/src/org/chromium/android_webview/test/AwActivityTestRule.java
[modify] https://crrev.com/9e50e5ccc1f7787ffc43c241ce03ecdaf456e633/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java
[modify] https://crrev.com/9e50e5ccc1f7787ffc43c241ce03ecdaf456e633/android_webview/javatests/src/org/chromium/android_webview/test/AwJavaBridgeTest.java
[modify] https://crrev.com/9e50e5ccc1f7787ffc43c241ce03ecdaf456e633/android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java
[modify] https://crrev.com/9e50e5ccc1f7787ffc43c241ce03ecdaf456e633/android_webview/javatests/src/org/chromium/android_webview/test/util/JSUtils.java
[modify] https://crrev.com/9e50e5ccc1f7787ffc43c241ce03ecdaf456e633/android_webview/test/BUILD.gn
[modify] https://crrev.com/9e50e5ccc1f7787ffc43c241ce03ecdaf456e633/chrome/android/BUILD.gn
[modify] https://crrev.com/9e50e5ccc1f7787ffc43c241ce03ecdaf456e633/chrome/android/javatests/src/org/chromium/chrome/browser/JavaScriptEvalChromeTest.java
[modify] https://crrev.com/9e50e5ccc1f7787ffc43c241ce03ecdaf456e633/chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java
[modify] https://crrev.com/9e50e5ccc1f7787ffc43c241ce03ecdaf456e633/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenManagerTest.java
[delete] https://crrev.com/7093d19d6b57479fc601da99b6f096c9e57f5b18/chrome/android/js_utils.cc
[delete] https://crrev.com/7093d19d6b57479fc601da99b6f096c9e57f5b18/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/JsUtils.java
[modify] https://crrev.com/9e50e5ccc1f7787ffc43c241ce03ecdaf456e633/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/UkmTest.java
[modify] https://crrev.com/9e50e5ccc1f7787ffc43c241ce03ecdaf456e633/content/browser/web_contents/web_contents_android.cc
[modify] https://crrev.com/9e50e5ccc1f7787ffc43c241ce03ecdaf456e633/content/browser/web_contents/web_contents_android.h
[modify] https://crrev.com/9e50e5ccc1f7787ffc43c241ce03ecdaf456e633/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
[modify] https://crrev.com/9e50e5ccc1f7787ffc43c241ce03ecdaf456e633/content/public/android/java/src/org/chromium/content_public/browser/WebContents.java
[modify] https://crrev.com/9e50e5ccc1f7787ffc43c241ce03ecdaf456e633/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeChildFrameTest.java
[modify] https://crrev.com/9e50e5ccc1f7787ffc43c241ce03ecdaf456e633/content/public/android/javatests/src/org/chromium/content/browser/TestsJavaScriptEvalTest.java
[modify] https://crrev.com/9e50e5ccc1f7787ffc43c241ce03ecdaf456e633/content/public/test/android/BUILD.gn
[modify] https://crrev.com/9e50e5ccc1f7787ffc43c241ce03ecdaf456e633/content/public/test/android/javatests/src/org/chromium/content_public/browser/test/mock/MockWebContents.java
[modify] https://crrev.com/9e50e5ccc1f7787ffc43c241ce03ecdaf456e633/content/public/test/android/javatests/src/org/chromium/content_public/browser/test/util/JavaScriptUtils.java
[modify] https://crrev.com/9e50e5ccc1f7787ffc43c241ce03ecdaf456e633/content/public/test/android/javatests/src/org/chromium/content_public/browser/test/util/TestCallbackHelperContainer.java
[modify] https://crrev.com/9e50e5ccc1f7787ffc43c241ce03ecdaf456e633/content/public/test/android/javatests/src/org/chromium/content_public/browser/test/util/WebContentsUtils.java
[modify] https://crrev.com/9e50e5ccc1f7787ffc43c241ce03ecdaf456e633/content/public/test/android/web_contents_utils.cc
[delete] https://crrev.com/7093d19d6b57479fc601da99b6f096c9e57f5b18/content/public/test/android/web_contents_utils.h

Sign in to add a comment