New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 875740 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 878465
Owner:
Closed: Sep 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocking:
issue 878465



Sign in to add a comment

Implement mDNS responder as a browser service in Chromium

Project Member Reported by qingsi@chromium.org, Aug 20

Issue description

This is a companion issue to webrtc:9605. Specifically, the implementation of mDNS responder in Chromium is intended to be a browser service that further utilizes the service provided by the network stack for mDNS transactions. The motivation of introducing the mDNS stack to WebRTC and Chromium is detailed as follows.

WebRTC currently exposes the private IP addresses of endpoints (via ICE candidate gathering) to applications in an attempt to establish a direct peer-to-peer link and increase the probability of successful connection between the endpoints. The ICE gathering process and the signaling of these private addresses as host candidates have strong privacy implications (e.g. browser fingerprinting) but are however often performed without user consent. 

In the Internet-Draft (draft-mdns-ice-candidates-00), using mDNS to obfuscate the private IP addresses of endpoints is proposed as a privacy measure to amend the current ICE candidate gathering behavior.

We intend to implement this feature for WebRTC (in Chromium), enabling IP handling modes defined in the Internet Draft (draft-ietf-rtcweb-ip-handling-09) and also new modes beyond the definition therein.

This bug tracks the related changes in the Chromium codebase.
 
Blocking: 878465
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/061d09d885e8cfdec0a2d8d55d7d96b17e53bd26

commit 061d09d885e8cfdec0a2d8d55d7d96b17e53bd26
Author: Zach Stein <zstein@chromium.org>
Date: Mon Sep 10 22:41:33 2018

Add feature flag for WebRTC mDNS work.

Enable on the command line by passing
"--enable-features=WebRtcHideLocalIpsWithMdns"
Check runtime setting with
base::FeatureList::IsEnabled(features::kWebRtcHideLocalIpsWithMdns)

Bug:  chromium:875740 
Change-Id: Ic8afd743d1b78da165cacb21ebc10837262af086
Reviewed-on: https://chromium-review.googlesource.com/1214328
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Zach Stein <zstein@google.com>
Cr-Commit-Position: refs/heads/master@{#590097}
[modify] https://crrev.com/061d09d885e8cfdec0a2d8d55d7d96b17e53bd26/content/public/common/content_features.cc
[modify] https://crrev.com/061d09d885e8cfdec0a2d8d55d7d96b17e53bd26/content/public/common/content_features.h

Mergedinto: 878465
Status: Duplicate (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d896b43d7a35130e76299520de52e984ab23776c

commit d896b43d7a35130e76299520de52e984ab23776c
Author: Zach Stein <zstein@chromium.org>
Date: Fri Oct 26 19:09:15 2018

Enable MDNS in the network service based on the feature flag in content.

Bug:  chromium:875740 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Iec6efad4b3d92877288fd29450f11ac008b26d27
Reviewed-on: https://chromium-review.googlesource.com/c/1280551
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Zach Stein <zstein@google.com>
Cr-Commit-Position: refs/heads/master@{#603160}
[modify] https://crrev.com/d896b43d7a35130e76299520de52e984ab23776c/content/renderer/p2p/host_address_request.cc
[modify] https://crrev.com/d896b43d7a35130e76299520de52e984ab23776c/services/network/p2p/socket_manager.cc
[modify] https://crrev.com/d896b43d7a35130e76299520de52e984ab23776c/services/network/p2p/socket_manager.h
[modify] https://crrev.com/d896b43d7a35130e76299520de52e984ab23776c/services/network/public/mojom/p2p.mojom

Sign in to add a comment