New issue
Advanced search Search tips

Issue 875736 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 23
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Picture-in-Picture window close button is not visible

Project Member Reported by fbeaufort@chromium.org, Aug 20

Issue description

Chrome Version       : 70.0.3524.2
OS Version: 10981.0.0

What steps will reproduce the problem?
1. Go to https://googlechrome.github.io/samples/picture-in-picture/
2. Play video
3. Click "Toggle Picture-in-Picture" button
4. Seek towards the end (to accelerate steps to reproduce)
5. Wait for video to end

What is the expected result?
Picture-in-Picture window is black and I can close it with the Close button.

What happens instead of that?
Picture-in-Picture window is black but I can't close because Close button is not visible.


 
Owner: fbeaufort@chromium.org
Status: Started (was: Available)
Regression happened at https://chromium.googlesource.com/chromium/src/+/9d6f39a010b60dfa489615b80379f502421ea231%5E%21/#F0
I'll fix this.

Comment 2 Deleted

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4a4e4e57e29d2c8404704878ad154452188fe90

commit b4a4e4e57e29d2c8404704878ad154452188fe90
Author: François Beaufort <beaufort.francois@gmail.com>
Date: Wed Aug 22 12:15:20 2018

Always show close button in Picture-in-Picture window.

This makes sure close button is always visible when
Picture-in-Picture window is focused or hovered (even
when video ends).

Bug:  875736 

Change-Id: I4c9a35d1e985eee4c7e869d2559032d303e51307
Reviewed-on: https://chromium-review.googlesource.com/1181133
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584988}
[modify] https://crrev.com/b4a4e4e57e29d2c8404704878ad154452188fe90/chrome/browser/ui/views/overlay/overlay_window_views.cc
[modify] https://crrev.com/b4a4e4e57e29d2c8404704878ad154452188fe90/chrome/browser/ui/views/overlay/overlay_window_views.h

Status: Verified (was: Started)
Verified in Chromium 70.0.3531

Sign in to add a comment