New issue
Advanced search Search tips

Issue 875729 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Gap is seen at beginning of font slider in 'chrome://settings/fonts'.

Reported by pranjali...@etouch.net, Aug 20

Issue description

Chrome version :70.0.3528.0 (Official Build)  354e37b4e7e3c9faacf4837f19c2ff88d6e61dda-refs/branch-heads/3528@{#1}(32/64-bit) 

OS :Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14)  and Linux(14.04 LTS)  OS

Steps to reproduce:
1. Launch chrome and navigate to 'chrome://settings/fonts'.
2. press tab key to bring focus on font slider and change font to extreme tiny.
3. Observe.

Actual Result:  Gap is seen at beginning of font slider in 'chrome://settings/fonts'.
Expected Result:   Gap should not be seen at beginning of font slider in 'chrome://settings/fonts'.

This is a regression issue broken in ‘M-69’ and below is bisect info.
Good build: 69.0.3472.0
Bad build: 69.0.3473.0

You are probably looking for a change made after 570185 (known good), but no later than 570186 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

 https://chromium.googlesource.com/chromium/src/+log/708568cc1a2d7f722acddbfd266ebc45de08b32e..744ac3c75d5f60a59f810c9e262e33332c2822d5

Suspect: https://chromium.googlesource.com/chromium/src/+/744ac3c75d5f60a59f810c9e262e33332c2822d5

@aee: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Thank You

 
Actual Result.mp4
314 KB View Download
Expected Result.mp4
320 KB View Download
Status: Started (was: Assigned)
Screenshots for CL https://chromium-review.googlesource.com/c/chromium/src/+/1181929.
min_value_focused_slider.png
63.2 KB View Download
disabled_slider.png
61.7 KB View Download
display_slider.png
9.3 KB View Download
disabled_display_slider.png
13.5 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c5b78cc73874a7db642351587fd8058b6d2bff4

commit 3c5b78cc73874a7db642351587fd8058b6d2bff4
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Wed Aug 22 21:43:56 2018

WebUI: cr-slider, fixing enabled/disabled knob and bar styles

Bug:  875729 
Change-Id: I3a80290e059cd9b21f660572700427d92ef9f84b
Reviewed-on: https://chromium-review.googlesource.com/1181929
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585260}
[modify] https://crrev.com/3c5b78cc73874a7db642351587fd8058b6d2bff4/chrome/browser/resources/settings/device_page/display_size_slider.html
[modify] https://crrev.com/3c5b78cc73874a7db642351587fd8058b6d2bff4/ui/webui/resources/cr_elements/cr_slider/cr_slider.js

Status: Fixed (was: Started)
Labels: TE-Verified-M70 TE-Verified-70.0.3532.0
Update:
Rechecked the above issue on Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14)  and Linux(14.04 LTS)  OS using latest canary build#70.0.3532.0 and issue is fix.

Please refer attached screencast for reference.

Thank You...
Canary Behaviour.mp4
220 KB View Download

Sign in to add a comment