Picture-in-Picture window size is not always the same after multiple requests at scale 125% |
|||||
Issue descriptionChrome Version : 70.0.3528.0 OS Version: Windows 10 What steps will reproduce the problem? 1. Go to https://googlechrome.github.io/samples/picture-in-picture/ 2. Play video 3. Click multiple times "Toogle Picture-in-Picture" button What is the expected result? Picture-in-Picture window size should be the same as window is not resized. What happens instead of that? Requesting Picture-in-Picture... > Video entered Picture-in-Picture > Window size is 293x166 <---------- Exiting Picture-in-Picture... > Video left Picture-in-Picture Requesting Picture-in-Picture... > Video entered Picture-in-Picture > Window size is 296x167 <---------- Exiting Picture-in-Picture... > Video left Picture-in-Picture Requesting Picture-in-Picture... > Video entered Picture-in-Picture > Window size is 296x168 <---------- Exiting Picture-in-Picture... > Video left Picture-in-Picture
,
Sep 28
Jennifer, I suspect there's a bug in https://cs.chromium.org/chromium/src/chrome/browser/ui/views/overlay/overlay_window_views.cc?type=cs&sq=package:chromium&g=0&l=170 and maybe https://cs.chromium.org/chromium/src/ui/views/window/window_resize_utils.cc?type=cs&sq=package:chromium&g=0&l=45 regarding rounding width and height. May you have a quick look?
,
Sep 28
,
Oct 26
Hey Tommy, can you have a quick look?
,
Oct 26
,
Oct 26
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by fbeaufort@chromium.org
, Sep 28