New issue
Advanced search Search tips

Issue 875714 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 22
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 655458



Sign in to add a comment

Add [replaceable] to name attribute in SharedWorkerGlobalScope

Project Member Reported by asamidoi@google.com, Aug 20

Issue description

Blocking: 655458
Status: Assigned (was: Untriaged)
Owner: ----
Status: Available (was: Assigned)
Cc: -nhiroki@chromium.org
Owner: nhiroki@chromium.org
Status: Started (was: Available)
shared-worker-name-via-options.html and one of test cases in name-property.html are failing by a different reason. See issue 907749.
Labels: -OS-Android
(Android doesn't support shared workers)
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45ef66be4f196b17474c0de94e3b148ac043668c

commit 45ef66be4f196b17474c0de94e3b148ac043668c
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Thu Nov 22 11:46:33 2018

Worker: Add [Replaceable] to SharedWorkerGlobalScope.name

The HTML spec requires SharedWorkerGlobalScope.name has [Replaceable]:
https://html.spec.whatwg.org/multipage/workers.html#shared-workers-and-the-sharedworkerglobalscope-interface

This CL also fixes a test expectation of
wpt/workers/interfaces/SharedWorkerGlobalScope/name/setting.html. The name
attribute is now replaceable, so the result should be replaced. Firefox fails
the test because of this wrong expectation:
https://wpt.fyi/results/workers/interfaces/SharedWorkerGlobalScope/name/setting.html?label=stable&aligned&q=%2Fname%2Fsetting.html

Bug:  875714 
Change-Id: Id04ae30895a2de4a07e30f49dc1189bb9742f6b9
Reviewed-on: https://chromium-review.googlesource.com/c/1347962
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610383}
[modify] https://crrev.com/45ef66be4f196b17474c0de94e3b148ac043668c/third_party/WebKit/LayoutTests/external/wpt/workers/interfaces/SharedWorkerGlobalScope/name/setting.html
[modify] https://crrev.com/45ef66be4f196b17474c0de94e3b148ac043668c/third_party/WebKit/LayoutTests/external/wpt/workers/name-property-expected.txt
[modify] https://crrev.com/45ef66be4f196b17474c0de94e3b148ac043668c/third_party/WebKit/LayoutTests/external/wpt/workers/support/name.js
[modify] https://crrev.com/45ef66be4f196b17474c0de94e3b148ac043668c/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/45ef66be4f196b17474c0de94e3b148ac043668c/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/45ef66be4f196b17474c0de94e3b148ac043668c/third_party/blink/renderer/core/workers/shared_worker_global_scope.idl

Labels: M-72
Status: Fixed (was: Started)

Sign in to add a comment