We use base::Callback and base::Closure in lots of places. It should be easy to switch these to use the new callback classes, with the vast majority of places using OnceCallback. This bug exists to track that work.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4819fdbc8cea963b63e6c3bb398732c965fa4218 commit 4819fdbc8cea963b63e6c3bb398732c965fa4218 Author: Stuart Langley <slangley@google.com> Date: Mon Aug 27 00:12:28 2018 Make ReadDirectoryEntriesCallback & GetFilesystemMetadataCallback OnceCallback. Start changing various file system callback types to be once callback rather than the default repeating callback. They are only repeating callback because that was the previous default and this can introduce subtle and hard to find bugs that would be more obvious if the types were once callback. An example of this is crbug.com/875140 . Bug: 875700 Change-Id: I3f37be3ca9f7622116db83fae287056203ff723e Reviewed-on: https://chromium-review.googlesource.com/1187859 Reviewed-by: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Anand Mistry <amistry@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#586173} [modify] https://crrev.com/4819fdbc8cea963b63e6c3bb398732c965fa4218/chrome/browser/chromeos/drive/debug_info_collector.cc [modify] https://crrev.com/4819fdbc8cea963b63e6c3bb398732c965fa4218/chrome/browser/chromeos/drive/debug_info_collector.h [modify] https://crrev.com/4819fdbc8cea963b63e6c3bb398732c965fa4218/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc [modify] https://crrev.com/4819fdbc8cea963b63e6c3bb398732c965fa4218/components/drive/chromeos/default_corpus_change_list_loader.cc [modify] https://crrev.com/4819fdbc8cea963b63e6c3bb398732c965fa4218/components/drive/chromeos/default_corpus_change_list_loader.h [modify] https://crrev.com/4819fdbc8cea963b63e6c3bb398732c965fa4218/components/drive/chromeos/directory_loader.cc [modify] https://crrev.com/4819fdbc8cea963b63e6c3bb398732c965fa4218/components/drive/chromeos/directory_loader.h [modify] https://crrev.com/4819fdbc8cea963b63e6c3bb398732c965fa4218/components/drive/chromeos/drive_change_list_loader.h [modify] https://crrev.com/4819fdbc8cea963b63e6c3bb398732c965fa4218/components/drive/chromeos/dummy_file_system.h [modify] https://crrev.com/4819fdbc8cea963b63e6c3bb398732c965fa4218/components/drive/chromeos/fake_file_system.cc [modify] https://crrev.com/4819fdbc8cea963b63e6c3bb398732c965fa4218/components/drive/chromeos/fake_file_system.h [modify] https://crrev.com/4819fdbc8cea963b63e6c3bb398732c965fa4218/components/drive/chromeos/file_system.cc [modify] https://crrev.com/4819fdbc8cea963b63e6c3bb398732c965fa4218/components/drive/chromeos/file_system.h [modify] https://crrev.com/4819fdbc8cea963b63e6c3bb398732c965fa4218/components/drive/chromeos/file_system_interface.h [modify] https://crrev.com/4819fdbc8cea963b63e6c3bb398732c965fa4218/components/drive/chromeos/team_drive_change_list_loader.cc [modify] https://crrev.com/4819fdbc8cea963b63e6c3bb398732c965fa4218/components/drive/chromeos/team_drive_change_list_loader.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd8b7ee107d6a77d6a56380e2ab8e475d625d221 commit bd8b7ee107d6a77d6a56380e2ab8e475d625d221 Author: Stuart Langley <slangley@google.com> Date: Mon Aug 27 01:24:44 2018 Change GetFileCallback from RepeatingCallback to OnceCallback. Part of ongoing work to cleanup various file system callbacks from repeating to once callback, to match the actual desired semantics of the operaton flow. Introduces no logic changes. Bug: 875700 Change-Id: I397368e27816ec11262e2cb4501677f7ccc02623 Reviewed-on: https://chromium-review.googlesource.com/1188725 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Anand Mistry <amistry@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#586181} [modify] https://crrev.com/bd8b7ee107d6a77d6a56380e2ab8e475d625d221/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc [modify] https://crrev.com/bd8b7ee107d6a77d6a56380e2ab8e475d625d221/chrome/browser/chromeos/extensions/file_manager/private_api_util.cc [modify] https://crrev.com/bd8b7ee107d6a77d6a56380e2ab8e475d625d221/components/drive/chromeos/dummy_file_system.h [modify] https://crrev.com/bd8b7ee107d6a77d6a56380e2ab8e475d625d221/components/drive/chromeos/fake_file_system.cc [modify] https://crrev.com/bd8b7ee107d6a77d6a56380e2ab8e475d625d221/components/drive/chromeos/fake_file_system.h [modify] https://crrev.com/bd8b7ee107d6a77d6a56380e2ab8e475d625d221/components/drive/chromeos/file_system.cc [modify] https://crrev.com/bd8b7ee107d6a77d6a56380e2ab8e475d625d221/components/drive/chromeos/file_system.h [modify] https://crrev.com/bd8b7ee107d6a77d6a56380e2ab8e475d625d221/components/drive/chromeos/file_system/download_operation.cc [modify] https://crrev.com/bd8b7ee107d6a77d6a56380e2ab8e475d625d221/components/drive/chromeos/file_system/download_operation.h [modify] https://crrev.com/bd8b7ee107d6a77d6a56380e2ab8e475d625d221/components/drive/chromeos/file_system/get_file_for_saving_operation.cc [modify] https://crrev.com/bd8b7ee107d6a77d6a56380e2ab8e475d625d221/components/drive/chromeos/file_system/get_file_for_saving_operation.h [modify] https://crrev.com/bd8b7ee107d6a77d6a56380e2ab8e475d625d221/components/drive/chromeos/file_system_interface.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3b60202e5c5dce0b662420b94682930905af560 commit d3b60202e5c5dce0b662420b94682930905af560 Author: Stuart Langley <slangley@google.com> Date: Mon Aug 27 04:24:59 2018 Change GetResourceEntryCallback from RepeatingCallback to OnceCallback. Part of ongoing work to cleanup various file system callbacks from repeating to once callback, to match the actual desired semantics of the operaton flow. Introduces no logic changes. Bug: 875700 Change-Id: I7f4c7a82e2d9a8b07bce67b683a5d1ab8d5eb39c Reviewed-on: https://chromium-review.googlesource.com/1188729 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Anand Mistry <amistry@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#586192} [modify] https://crrev.com/d3b60202e5c5dce0b662420b94682930905af560/chrome/browser/chromeos/drive/debug_info_collector.cc [modify] https://crrev.com/d3b60202e5c5dce0b662420b94682930905af560/chrome/browser/chromeos/drive/debug_info_collector.h [modify] https://crrev.com/d3b60202e5c5dce0b662420b94682930905af560/chrome/browser/chromeos/drive/download_handler.cc [modify] https://crrev.com/d3b60202e5c5dce0b662420b94682930905af560/chrome/browser/chromeos/drive/download_handler_unittest.cc [modify] https://crrev.com/d3b60202e5c5dce0b662420b94682930905af560/chrome/browser/chromeos/drive/file_task_executor.cc [modify] https://crrev.com/d3b60202e5c5dce0b662420b94682930905af560/chrome/browser/chromeos/drive/fileapi/file_system_backend_delegate.cc [modify] https://crrev.com/d3b60202e5c5dce0b662420b94682930905af560/chrome/browser/chromeos/drive/fileapi/fileapi_worker.cc [modify] https://crrev.com/d3b60202e5c5dce0b662420b94682930905af560/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc [modify] https://crrev.com/d3b60202e5c5dce0b662420b94682930905af560/chrome/browser/chromeos/file_manager/filesystem_api_util.cc [modify] https://crrev.com/d3b60202e5c5dce0b662420b94682930905af560/chrome/browser/ui/webui/chromeos/drive_internals_ui.cc [modify] https://crrev.com/d3b60202e5c5dce0b662420b94682930905af560/components/drive/chromeos/dummy_file_system.h [modify] https://crrev.com/d3b60202e5c5dce0b662420b94682930905af560/components/drive/chromeos/fake_file_system.cc [modify] https://crrev.com/d3b60202e5c5dce0b662420b94682930905af560/components/drive/chromeos/fake_file_system.h [modify] https://crrev.com/d3b60202e5c5dce0b662420b94682930905af560/components/drive/chromeos/file_system.cc [modify] https://crrev.com/d3b60202e5c5dce0b662420b94682930905af560/components/drive/chromeos/file_system.h [modify] https://crrev.com/d3b60202e5c5dce0b662420b94682930905af560/components/drive/chromeos/file_system_interface.h [modify] https://crrev.com/d3b60202e5c5dce0b662420b94682930905af560/components/drive/file_system_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0da3d888140e4dc6875e8ae0ad1282bfbbb99dd4 commit 0da3d888140e4dc6875e8ae0ad1282bfbbb99dd4 Author: Anand K. Mistry <amistry@chromium.org> Date: Mon Aug 27 23:55:03 2018 Move CrosDisksClient to {Once,Repeating}Callback. No changes to behaviour. Part of ongoing effort to clean up file manager code. BUG=875700 Change-Id: I2a3409c79b5d751bfc757dd8bd77696691ce68d6 Reviewed-on: https://chromium-review.googlesource.com/1189507 Reviewed-by: Dan Erat <derat@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#586503} [modify] https://crrev.com/0da3d888140e4dc6875e8ae0ad1282bfbbb99dd4/chromeos/dbus/cros_disks_client.cc [modify] https://crrev.com/0da3d888140e4dc6875e8ae0ad1282bfbbb99dd4/chromeos/dbus/cros_disks_client.h [modify] https://crrev.com/0da3d888140e4dc6875e8ae0ad1282bfbbb99dd4/chromeos/dbus/fake_cros_disks_client.cc [modify] https://crrev.com/0da3d888140e4dc6875e8ae0ad1282bfbbb99dd4/chromeos/dbus/fake_cros_disks_client.h [modify] https://crrev.com/0da3d888140e4dc6875e8ae0ad1282bfbbb99dd4/chromeos/disks/disk_mount_manager.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c10d4c19be0676bedc34fed1053aa8192247628d commit c10d4c19be0676bedc34fed1053aa8192247628d Author: Anand K. Mistry <amistry@chromium.org> Date: Tue Aug 28 00:17:38 2018 Use {Once,Repeating}Callback in DiskMountManager. No changes to behaviour. Part of ongoing effort to clean up file manager code. BUG=875700 Change-Id: I89b8f2bb25bb405a3b11d6b2ca960d835b7b60e9 Reviewed-on: https://chromium-review.googlesource.com/1188731 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#586516} [modify] https://crrev.com/c10d4c19be0676bedc34fed1053aa8192247628d/chrome/browser/chromeos/file_manager/fake_disk_mount_manager.cc [modify] https://crrev.com/c10d4c19be0676bedc34fed1053aa8192247628d/chrome/browser/chromeos/file_manager/fake_disk_mount_manager.h [modify] https://crrev.com/c10d4c19be0676bedc34fed1053aa8192247628d/chrome/browser/chromeos/file_manager/volume_manager.cc [modify] https://crrev.com/c10d4c19be0676bedc34fed1053aa8192247628d/chromeos/disks/disk_mount_manager.cc [modify] https://crrev.com/c10d4c19be0676bedc34fed1053aa8192247628d/chromeos/disks/disk_mount_manager.h [modify] https://crrev.com/c10d4c19be0676bedc34fed1053aa8192247628d/chromeos/disks/disk_mount_manager_unittest.cc [modify] https://crrev.com/c10d4c19be0676bedc34fed1053aa8192247628d/chromeos/disks/mock_disk_mount_manager.cc [modify] https://crrev.com/c10d4c19be0676bedc34fed1053aa8192247628d/chromeos/disks/mock_disk_mount_manager.h [modify] https://crrev.com/c10d4c19be0676bedc34fed1053aa8192247628d/chromeos/disks/suspend_unmount_manager.cc [modify] https://crrev.com/c10d4c19be0676bedc34fed1053aa8192247628d/chromeos/disks/suspend_unmount_manager_unittest.cc [modify] https://crrev.com/c10d4c19be0676bedc34fed1053aa8192247628d/components/storage_monitor/storage_monitor_chromeos.cc [modify] https://crrev.com/c10d4c19be0676bedc34fed1053aa8192247628d/components/storage_monitor/storage_monitor_chromeos_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48b51456e39a16129fb9f6b1b1dd34a36cb62c7b commit 48b51456e39a16129fb9f6b1b1dd34a36cb62c7b Author: Stuart Langley <slangley@google.com> Date: Tue Aug 28 01:17:10 2018 Change GetFileContentInitializedCallback from RepeatingCallback to OnceCallback. Part of ongoing work to cleanup various file system callbacks from repeating to once callback, to match the actual desired semantics of the operaton flow. Introduces no logic changes. Bug: 875700 Change-Id: Iae1ed25ce1d04a71cf0805e773b84fa618d4cf3e Reviewed-on: https://chromium-review.googlesource.com/1189686 Reviewed-by: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#586531} [modify] https://crrev.com/48b51456e39a16129fb9f6b1b1dd34a36cb62c7b/chrome/browser/chromeos/drive/drive_file_stream_reader.cc [modify] https://crrev.com/48b51456e39a16129fb9f6b1b1dd34a36cb62c7b/components/drive/chromeos/dummy_file_system.cc [modify] https://crrev.com/48b51456e39a16129fb9f6b1b1dd34a36cb62c7b/components/drive/chromeos/dummy_file_system.h [modify] https://crrev.com/48b51456e39a16129fb9f6b1b1dd34a36cb62c7b/components/drive/chromeos/fake_file_system.cc [modify] https://crrev.com/48b51456e39a16129fb9f6b1b1dd34a36cb62c7b/components/drive/chromeos/fake_file_system.h [modify] https://crrev.com/48b51456e39a16129fb9f6b1b1dd34a36cb62c7b/components/drive/chromeos/file_system.cc [modify] https://crrev.com/48b51456e39a16129fb9f6b1b1dd34a36cb62c7b/components/drive/chromeos/file_system.h [modify] https://crrev.com/48b51456e39a16129fb9f6b1b1dd34a36cb62c7b/components/drive/chromeos/file_system/download_operation.cc [modify] https://crrev.com/48b51456e39a16129fb9f6b1b1dd34a36cb62c7b/components/drive/chromeos/file_system/download_operation.h [modify] https://crrev.com/48b51456e39a16129fb9f6b1b1dd34a36cb62c7b/components/drive/chromeos/file_system_interface.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a4013c9697e0a181e8abb285a926bb829a2f91b commit 6a4013c9697e0a181e8abb285a926bb829a2f91b Author: Stuart Langley <slangley@google.com> Date: Tue Aug 28 01:27:14 2018 Change (Search|SearchMetadata|SearchByHashes)Callback to OnceCallback. Part of ongoing work to cleanup various file system callbacks from repeating to once callback, to match the actual desired semantics of the operaton flow. Introduces no logic changes, although updates function signatures to use pass by value for OnceCallback rather than pass by const-ref, which is the canonical way to do it. Bug: 875700 Change-Id: I10af42d3ab9685a6c130a224b5b82b9c1fa28c56 Reviewed-on: https://chromium-review.googlesource.com/1189521 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#586533} [modify] https://crrev.com/6a4013c9697e0a181e8abb285a926bb829a2f91b/components/drive/chromeos/dummy_file_system.h [modify] https://crrev.com/6a4013c9697e0a181e8abb285a926bb829a2f91b/components/drive/chromeos/fake_file_system.cc [modify] https://crrev.com/6a4013c9697e0a181e8abb285a926bb829a2f91b/components/drive/chromeos/fake_file_system.h [modify] https://crrev.com/6a4013c9697e0a181e8abb285a926bb829a2f91b/components/drive/chromeos/file_system.cc [modify] https://crrev.com/6a4013c9697e0a181e8abb285a926bb829a2f91b/components/drive/chromeos/file_system.h [modify] https://crrev.com/6a4013c9697e0a181e8abb285a926bb829a2f91b/components/drive/chromeos/file_system/search_operation.cc [modify] https://crrev.com/6a4013c9697e0a181e8abb285a926bb829a2f91b/components/drive/chromeos/file_system/search_operation.h [modify] https://crrev.com/6a4013c9697e0a181e8abb285a926bb829a2f91b/components/drive/chromeos/file_system_interface.h [modify] https://crrev.com/6a4013c9697e0a181e8abb285a926bb829a2f91b/components/drive/chromeos/search_metadata.cc [modify] https://crrev.com/6a4013c9697e0a181e8abb285a926bb829a2f91b/components/drive/chromeos/search_metadata.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5887106440e0c3c7311effec0180cd931a77318e commit 5887106440e0c3c7311effec0180cd931a77318e Author: Stuart Langley <slangley@google.com> Date: Tue Aug 28 05:10:58 2018 Change OpenFileCallback to OnceCallback. Part of ongoing work to cleanup various file system callbacks from repeating to once callback, to match the actual desired semantics of the operaton flow. Introduces no logic changes, although updates function signatures to use pass by value for OnceCallback rather than pass by const-ref, which is the canonical way to do it. In a followup CL I will change the nested callback to be OnceCallback, for now leave it as repeating. Bug: 875700 Change-Id: Ia889c349085772a2185e8eb553145c662d486520 Reviewed-on: https://chromium-review.googlesource.com/1192364 Reviewed-by: Anand Mistry <amistry@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#586586} [modify] https://crrev.com/5887106440e0c3c7311effec0180cd931a77318e/chrome/browser/chromeos/drive/fileapi/fileapi_worker_unittest.cc [modify] https://crrev.com/5887106440e0c3c7311effec0180cd931a77318e/chrome/browser/chromeos/drive/write_on_cache_file_unittest.cc [modify] https://crrev.com/5887106440e0c3c7311effec0180cd931a77318e/components/drive/chromeos/dummy_file_system.h [modify] https://crrev.com/5887106440e0c3c7311effec0180cd931a77318e/components/drive/chromeos/fake_file_system.cc [modify] https://crrev.com/5887106440e0c3c7311effec0180cd931a77318e/components/drive/chromeos/fake_file_system.h [modify] https://crrev.com/5887106440e0c3c7311effec0180cd931a77318e/components/drive/chromeos/file_system.cc [modify] https://crrev.com/5887106440e0c3c7311effec0180cd931a77318e/components/drive/chromeos/file_system.h [modify] https://crrev.com/5887106440e0c3c7311effec0180cd931a77318e/components/drive/chromeos/file_system/open_file_operation.cc [modify] https://crrev.com/5887106440e0c3c7311effec0180cd931a77318e/components/drive/chromeos/file_system/open_file_operation.h [modify] https://crrev.com/5887106440e0c3c7311effec0180cd931a77318e/components/drive/chromeos/file_system_interface.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/38148efd2e0b1301461ed8906a3be67da3f8886b commit 38148efd2e0b1301461ed8906a3be67da3f8886b Author: Stuart Langley <slangley@google.com> Date: Thu Aug 30 01:35:24 2018 Change Loadercontroller to use OnceCallbacks. Part of the ongoing work to cleanup files callback usage. I has also started investigating a reported memory leak in ChangeListProcessor and wanted to clear up the ownership of various data structures flowing in the callbacks. Bug: 875700, 868912 Change-Id: I278bb8d267b8d602643be17a71d9493329c90c28 Reviewed-on: https://chromium-review.googlesource.com/1195405 Reviewed-by: Anand Mistry <amistry@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#587385} [modify] https://crrev.com/38148efd2e0b1301461ed8906a3be67da3f8886b/components/drive/chromeos/change_list_loader.cc [modify] https://crrev.com/38148efd2e0b1301461ed8906a3be67da3f8886b/components/drive/chromeos/change_list_loader.h [modify] https://crrev.com/38148efd2e0b1301461ed8906a3be67da3f8886b/components/drive/chromeos/directory_loader.cc [modify] https://crrev.com/38148efd2e0b1301461ed8906a3be67da3f8886b/components/drive/chromeos/file_system/search_operation.cc [modify] https://crrev.com/38148efd2e0b1301461ed8906a3be67da3f8886b/components/drive/chromeos/loader_controller.cc [modify] https://crrev.com/38148efd2e0b1301461ed8906a3be67da3f8886b/components/drive/chromeos/loader_controller.h [modify] https://crrev.com/38148efd2e0b1301461ed8906a3be67da3f8886b/components/drive/chromeos/team_drive_list_loader.cc [modify] https://crrev.com/38148efd2e0b1301461ed8906a3be67da3f8886b/components/drive/chromeos/team_drive_list_loader.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d37ba940a61158d97cc6886bb7a84f0e01b0635b commit d37ba940a61158d97cc6886bb7a84f0e01b0635b Author: Stuart Langley <slangley@google.com> Date: Mon Sep 10 07:05:06 2018 Replace (bool, const std::string&) with base::Optional<std::string> As per the attached bug, replace usage of Replace (bool, const std::string&) in filesystem_api_util.cc with base::Optional<std::string> for code health. Also, change from RepeatingCallback to OnceCallback for all filesystem_api_util defined methods. Also, fix linter warnings. There are no logic changes. Bug: 729442 , 875700 Change-Id: Ib27634b9ba1372cb007ba6a190608ec4128bbeb3 Reviewed-on: https://chromium-review.googlesource.com/1215425 Reviewed-by: Sam McNally <sammc@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#589842} [modify] https://crrev.com/d37ba940a61158d97cc6886bb7a84f0e01b0635b/chrome/browser/chromeos/file_manager/filesystem_api_util.cc [modify] https://crrev.com/d37ba940a61158d97cc6886bb7a84f0e01b0635b/chrome/browser/chromeos/file_manager/filesystem_api_util.h [modify] https://crrev.com/d37ba940a61158d97cc6886bb7a84f0e01b0635b/chrome/browser/extensions/api/file_handlers/non_native_file_system_delegate_chromeos.cc [modify] https://crrev.com/d37ba940a61158d97cc6886bb7a84f0e01b0635b/chrome/browser/extensions/api/file_handlers/non_native_file_system_delegate_chromeos.h [modify] https://crrev.com/d37ba940a61158d97cc6886bb7a84f0e01b0635b/extensions/browser/api/file_handlers/mime_util.cc [modify] https://crrev.com/d37ba940a61158d97cc6886bb7a84f0e01b0635b/extensions/browser/api/file_handlers/non_native_file_system_delegate.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f462187e5b57990d59638f941309f5b0a3b6858 commit 5f462187e5b57990d59638f941309f5b0a3b6858 Author: Stuart Langley <slangley@google.com> Date: Tue Sep 11 01:04:16 2018 Change GetAvailableSpaceCallback from RepeatingCallback to OnceCallback. Part of the ongoing work to cleanup the filesystem callbacks to be OnceCallback where possible. No logic changes. Bug: 875700 Change-Id: I69c5518eaee657e0ce42d8bde3687696fa9047b9 Reviewed-on: https://chromium-review.googlesource.com/1217644 Reviewed-by: Anand Mistry <amistry@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#590152} [modify] https://crrev.com/5f462187e5b57990d59638f941309f5b0a3b6858/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc [modify] https://crrev.com/5f462187e5b57990d59638f941309f5b0a3b6858/components/drive/chromeos/dummy_file_system.h [modify] https://crrev.com/5f462187e5b57990d59638f941309f5b0a3b6858/components/drive/chromeos/fake_file_system.cc [modify] https://crrev.com/5f462187e5b57990d59638f941309f5b0a3b6858/components/drive/chromeos/fake_file_system.h [modify] https://crrev.com/5f462187e5b57990d59638f941309f5b0a3b6858/components/drive/chromeos/file_system.cc [modify] https://crrev.com/5f462187e5b57990d59638f941309f5b0a3b6858/components/drive/chromeos/file_system.h [modify] https://crrev.com/5f462187e5b57990d59638f941309f5b0a3b6858/components/drive/chromeos/file_system_interface.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95ec6984c1684b3ab619138bbdd63d1aeafc956e commit 95ec6984c1684b3ab619138bbdd63d1aeafc956e Author: Anand K. Mistry <amistry@chromium.org> Date: Wed Sep 12 01:23:36 2018 Convert callbacks in SnapshotManager to OnceCallback. No changes to behaviour. Part of ongoing effort to clean up file manager code. BUG=875700 Change-Id: If66a7ebf25d401397492133c2977a1b9e6109dde Reviewed-on: https://chromium-review.googlesource.com/1220347 Reviewed-by: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#590565} [modify] https://crrev.com/95ec6984c1684b3ab619138bbdd63d1aeafc956e/chrome/browser/chromeos/file_manager/snapshot_manager.cc [modify] https://crrev.com/95ec6984c1684b3ab619138bbdd63d1aeafc956e/chrome/browser/chromeos/file_manager/snapshot_manager.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4d123df95c82fa332647f6c825c6463a9d08ae67 commit 4d123df95c82fa332647f6c825c6463a9d08ae67 Author: Anand K. Mistry <amistry@chromium.org> Date: Wed Sep 12 03:58:46 2018 Convert file tasks callbacks to OnceCallback. No changes to behaviour. Part of ongoing effort to clean up file manager code. BUG=875700 Change-Id: I46689aff1006348fc7734cfef3f21f899f03db25 Reviewed-on: https://chromium-review.googlesource.com/1220410 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#590594} [modify] https://crrev.com/4d123df95c82fa332647f6c825c6463a9d08ae67/chrome/browser/chromeos/drive/file_task_executor.cc [modify] https://crrev.com/4d123df95c82fa332647f6c825c6463a9d08ae67/chrome/browser/chromeos/drive/file_task_executor.h [modify] https://crrev.com/4d123df95c82fa332647f6c825c6463a9d08ae67/chrome/browser/chromeos/file_manager/arc_file_tasks.cc [modify] https://crrev.com/4d123df95c82fa332647f6c825c6463a9d08ae67/chrome/browser/chromeos/file_manager/arc_file_tasks.h [modify] https://crrev.com/4d123df95c82fa332647f6c825c6463a9d08ae67/chrome/browser/chromeos/file_manager/file_browser_handlers.cc [modify] https://crrev.com/4d123df95c82fa332647f6c825c6463a9d08ae67/chrome/browser/chromeos/file_manager/file_browser_handlers.h [modify] https://crrev.com/4d123df95c82fa332647f6c825c6463a9d08ae67/chrome/browser/chromeos/file_manager/file_tasks.cc [modify] https://crrev.com/4d123df95c82fa332647f6c825c6463a9d08ae67/chrome/browser/chromeos/file_manager/file_tasks.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/503c3a2cabf2e61bcdc18a2c1cade0553409e15d commit 503c3a2cabf2e61bcdc18a2c1cade0553409e15d Author: Stuart Langley <slangley@google.com> Date: Fri Sep 14 01:15:46 2018 Change MarkMountedCallback and IsMountedCallback to OnceCallback. Part of on-going callback cleanup work to move from RepeatingCallback to OnceCallback where applicable. There are no logic changes. Bug: 875700 Change-Id: I691f069ab7010a6146b2f8885bc3d1ca4eee8379 Reviewed-on: https://chromium-review.googlesource.com/1226531 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Anand Mistry <amistry@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#591248} [modify] https://crrev.com/503c3a2cabf2e61bcdc18a2c1cade0553409e15d/chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc [modify] https://crrev.com/503c3a2cabf2e61bcdc18a2c1cade0553409e15d/components/drive/chromeos/dummy_file_system.h [modify] https://crrev.com/503c3a2cabf2e61bcdc18a2c1cade0553409e15d/components/drive/chromeos/fake_file_system.cc [modify] https://crrev.com/503c3a2cabf2e61bcdc18a2c1cade0553409e15d/components/drive/chromeos/fake_file_system.h [modify] https://crrev.com/503c3a2cabf2e61bcdc18a2c1cade0553409e15d/components/drive/chromeos/file_system.cc [modify] https://crrev.com/503c3a2cabf2e61bcdc18a2c1cade0553409e15d/components/drive/chromeos/file_system.h [modify] https://crrev.com/503c3a2cabf2e61bcdc18a2c1cade0553409e15d/components/drive/chromeos/file_system_interface.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/535ade9daf89d5730d98d421aed0dff69b9cbc1e commit 535ade9daf89d5730d98d421aed0dff69b9cbc1e Author: Anand K. Mistry <amistry@chromium.org> Date: Wed Sep 19 02:50:02 2018 Change FileWatcher and fileapi_util callbacks to OnceCallback. Additionally, update a few call sites that were missed on previous CLs. No changes to behaviour. Part of ongoing effort to clean up file manager code. BUG=875700 TBR=avi@chromium.org Change-Id: Ic3d5fb246a0610d63d377de7c038f7e2359f1bdc Reviewed-on: https://chromium-review.googlesource.com/1229721 Reviewed-by: Anand Mistry <amistry@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#592309} [modify] https://crrev.com/535ade9daf89d5730d98d421aed0dff69b9cbc1e/chrome/browser/chromeos/extensions/file_manager/event_router.cc [modify] https://crrev.com/535ade9daf89d5730d98d421aed0dff69b9cbc1e/chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api.cc [modify] https://crrev.com/535ade9daf89d5730d98d421aed0dff69b9cbc1e/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc [modify] https://crrev.com/535ade9daf89d5730d98d421aed0dff69b9cbc1e/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc [modify] https://crrev.com/535ade9daf89d5730d98d421aed0dff69b9cbc1e/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc [modify] https://crrev.com/535ade9daf89d5730d98d421aed0dff69b9cbc1e/chrome/browser/chromeos/file_manager/crostini_file_tasks.cc [modify] https://crrev.com/535ade9daf89d5730d98d421aed0dff69b9cbc1e/chrome/browser/chromeos/file_manager/crostini_file_tasks.h [modify] https://crrev.com/535ade9daf89d5730d98d421aed0dff69b9cbc1e/chrome/browser/chromeos/file_manager/file_browser_handlers.cc [modify] https://crrev.com/535ade9daf89d5730d98d421aed0dff69b9cbc1e/chrome/browser/chromeos/file_manager/file_watcher.cc [modify] https://crrev.com/535ade9daf89d5730d98d421aed0dff69b9cbc1e/chrome/browser/chromeos/file_manager/file_watcher.h [modify] https://crrev.com/535ade9daf89d5730d98d421aed0dff69b9cbc1e/chrome/browser/chromeos/file_manager/file_watcher_unittest.cc [modify] https://crrev.com/535ade9daf89d5730d98d421aed0dff69b9cbc1e/chrome/browser/chromeos/file_manager/fileapi_util.cc [modify] https://crrev.com/535ade9daf89d5730d98d421aed0dff69b9cbc1e/chrome/browser/chromeos/file_manager/fileapi_util.h [modify] https://crrev.com/535ade9daf89d5730d98d421aed0dff69b9cbc1e/chrome/browser/chromeos/file_manager/fileapi_util_unittest.cc [modify] https://crrev.com/535ade9daf89d5730d98d421aed0dff69b9cbc1e/chrome/browser/chromeos/file_manager/volume_manager.cc [modify] https://crrev.com/535ade9daf89d5730d98d421aed0dff69b9cbc1e/chrome/browser/chromeos/file_manager/volume_manager.h [modify] https://crrev.com/535ade9daf89d5730d98d421aed0dff69b9cbc1e/chrome/browser/file_select_helper.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da13071568f76b3a9d5d8d186652e86d67fe3ca1 commit da13071568f76b3a9d5d8d186652e86d67fe3ca1 Author: Anand K. Mistry <amistry@chromium.org> Date: Thu Sep 20 05:47:52 2018 Bind->BindOnce in file manager, where possible. BUG=875700 Change-Id: I8d54318dd4247d655d1e57d5d2dd358769082b83 Reviewed-on: https://chromium-review.googlesource.com/1235358 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#592689} [modify] https://crrev.com/da13071568f76b3a9d5d8d186652e86d67fe3ca1/chrome/browser/chromeos/file_manager/file_browser_handlers.cc [modify] https://crrev.com/da13071568f76b3a9d5d8d186652e86d67fe3ca1/chrome/browser/chromeos/file_manager/file_tasks_unittest.cc [modify] https://crrev.com/da13071568f76b3a9d5d8d186652e86d67fe3ca1/chrome/browser/chromeos/file_manager/fileapi_util.cc [modify] https://crrev.com/da13071568f76b3a9d5d8d186652e86d67fe3ca1/chrome/browser/chromeos/file_manager/open_util.cc
Comment 1 by slangley@chromium.org
, Aug 22Labels: CrOSFilesCategory-CodeHealth