New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 875699 link

Starred by 2 users
Status: Fixed
Owner:
deanliao@chromium.org
Closed: Aug 22
Cc:
hiroh@chromium.org
█ updowndota@chromium.org
posciak@chromium.org
jen...@chromium.org
deanliao@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

video_ChromeRTCHWDecodeUsed on M70.

Project Member Reported by deanliao@chromium.org, Aug 20 
https://sponge.corp.google.com/invocations?searchFor=video_ChromeRTCHWDecodeUsed

Multiple invocations showed Tool Failure and the real reason is that histogram diff is empty. 

08/19 18:56:14.218 WARNI|              test:0606| The test failed with the following exception
Traceback (most recent call last):
  File "/usr/local/autotest/common_lib/test.py", line 600, in _exec
    _call_test_function(self.execute, *p_args, **p_dargs)
  File "/usr/local/autotest/common_lib/test.py", line 800, in _call_test_function
    return func(*args, **dargs)
  File "/usr/local/autotest/common_lib/test.py", line 464, in execute
    postprocess_profiled_run, args, dargs)
  File "/usr/local/autotest/common_lib/test.py", line 371, in _call_run_once
    self.run_once(*args, **dargs)
  File "/usr/local/autotest/cros/video/helper_logger.py", line 82, in call
    return func(*args, **kwargs)
  File "/usr/local/autotest/tests/video_ChromeRTCHWDecodeUsed/video_ChromeRTCHWDecodeUsed.py", line 92, in run_once
    histogram_bucket_val, histogram_bucket_val)
  File "/usr/local/autotest/cros/video/histogram_verifier.py", line 186, in expect_sole_bucket
    (histogram_name, bucket_name, histogram))
TestError: Expect Media.RTCVideoDecoderInitDecodeSucces has 1. Histogram: {}
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/1e31228a02bfebee7b02e5b8a0a2d2e4b0f2f20e

commit 1e31228a02bfebee7b02e5b8a0a2d2e4b0f2f20e
Author: Dean Liao <deanliao@chromium.org>
Date: Mon Aug 20 18:45:20 2018

Revert "cros/video: use  HistogramDiffer to expect histogram change."

This reverts commit 3a26463be800cba6d09559c31c6f90a90796f707.

Reason: Unlike histogram_verifier.verify(),
histogram_verifier.expect_sole_bucket() doesn't retry if histogram
observed does not meet expectation. It makes autotests using it flaky.

BUG= chromium:875699 
TEST=test_that video_ChromeRTCHWDecodeUsed

Change-Id: I79d2c6f029ea2f9c7b92c2186336a4a99183e30f
Reviewed-on: https://chromium-review.googlesource.com/1180791
Tested-by: Shuo-Peng Liao <deanliao@google.com>
Commit-Queue: Shuo-Peng Liao <deanliao@google.com>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>

[modify] https://crrev.com/1e31228a02bfebee7b02e5b8a0a2d2e4b0f2f20e/client/site_tests/video_ChromeVidResChangeHWDecode/video_ChromeVidResChangeHWDecode.py
[modify] https://crrev.com/1e31228a02bfebee7b02e5b8a0a2d2e4b0f2f20e/client/site_tests/video_ChromeHWDecodeUsed/video_ChromeHWDecodeUsed.py
[modify] https://crrev.com/1e31228a02bfebee7b02e5b8a0a2d2e4b0f2f20e/client/site_tests/video_MediaRecorderPerf/video_MediaRecorderPerf.py
[modify] https://crrev.com/1e31228a02bfebee7b02e5b8a0a2d2e4b0f2f20e/client/cros/video/histogram_verifier_unittest.py
[modify] https://crrev.com/1e31228a02bfebee7b02e5b8a0a2d2e4b0f2f20e/client/site_tests/video_MediaRecorderHWEncodeUsed/video_MediaRecorderHWEncodeUsed.py
[modify] https://crrev.com/1e31228a02bfebee7b02e5b8a0a2d2e4b0f2f20e/client/cros/video/histogram_verifier.py
[modify] https://crrev.com/1e31228a02bfebee7b02e5b8a0a2d2e4b0f2f20e/client/site_tests/video_ChromeRTCHWDecodeUsed/video_ChromeRTCHWDecodeUsed.py

Comment 2 by deanliao@chromium.org, Aug 21

Summary: video_ChromeRTCHWDecodeUsed on M70. (was: video_ChromeRTCHWDecodeUsed flaky)
Reland w/ fix is on the way https://crrev.com/c/1180792

After ToT reland works well, cherry-pick back to M69 to fix video_ChromeHWDecodeUsed, video_ChromeVidResChangeHWDecode flaky issue because of https://crrev.com/c/1168328.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a36b878559862fe31c20af485c8c8883a7bb5113

commit a36b878559862fe31c20af485c8c8883a7bb5113
Author: Dean Liao <deanliao@chromium.org>
Date: Tue Aug 21 17:33:59 2018

Reland "cros/video: use HistogramDiffer to expect histogram change."

This reverts commit 3cdc7663539d8c7f6cf8ada119a012c7e8dfef9d,
which is a reland of 3a26463be800cba6d09559c31c6f90a90796f707.

It adds retry mechanism for histogram_verifier.expect_sole_bucket() as
its replacement target, histogram_verifier.verify(), has retry
mechanism.

Also, adds expect_histogram_grow() with observation peirod.

BUG= chromium:845372 , chromium:875699 
TEST=./histogram_verifier_unittest.py
Run autotest video_ChromeHWDecodeUsed, video_ChromeRTCHWDecodeUsed,
video_ChromeVidResChangeHWDecode, video_MediaRecorderHWEncodeUsed,
and video_MediaRecorderPerf.

Change-Id: Ic15b14234a86fb222a3947c75fb572fdba3c4083
Reviewed-on: https://chromium-review.googlesource.com/1180792
Commit-Ready: Shuo-Peng Liao <deanliao@google.com>
Tested-by: Shuo-Peng Liao <deanliao@google.com>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>

[modify] https://crrev.com/a36b878559862fe31c20af485c8c8883a7bb5113/client/site_tests/video_ChromeVidResChangeHWDecode/video_ChromeVidResChangeHWDecode.py
[modify] https://crrev.com/a36b878559862fe31c20af485c8c8883a7bb5113/client/site_tests/video_ChromeHWDecodeUsed/video_ChromeHWDecodeUsed.py
[modify] https://crrev.com/a36b878559862fe31c20af485c8c8883a7bb5113/client/site_tests/video_MediaRecorderPerf/video_MediaRecorderPerf.py
[modify] https://crrev.com/a36b878559862fe31c20af485c8c8883a7bb5113/client/cros/video/histogram_verifier_unittest.py
[modify] https://crrev.com/a36b878559862fe31c20af485c8c8883a7bb5113/client/site_tests/video_MediaRecorderHWEncodeUsed/video_MediaRecorderHWEncodeUsed.py
[modify] https://crrev.com/a36b878559862fe31c20af485c8c8883a7bb5113/client/cros/video/histogram_verifier.py
[modify] https://crrev.com/a36b878559862fe31c20af485c8c8883a7bb5113/client/site_tests/video_ChromeRTCHWDecodeUsed/video_ChromeRTCHWDecodeUsed.py

Comment 4 by deanliao@chromium.org, Aug 22

Status: Fixed (was: Started)
Sponge to watch:
https://sponge.corp.google.com/invocations?searchFor=video_ChromeRTCHWDecodeUsed%20-status%3Apassed

Only one test fail for os> R70-10988 (where the above commit landed):
https://sponge.corp.google.com/target?id=2f2a9703-43b4-43f0-8098-5094ddd70778&target=daisy-release%2FR70-10989.0.0%2Fbvt-cq%2Fvideo_ChromeRTCHWDecodeUsed&searchFor=video_ChromeRTCHWDecodeUsed+-status%3Apassed

Its histogram diff was empty after ten seconds retry.

Marked it as fixed unless more failures are observed.

Comment 5 by deanliao@chromium.org, Aug 23

Cc: deanliao@chromium.org jen...@chromium.org updowndota@chromium.org
 Issue 875910  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 23

Labels: merge-merged-release-R69-10895.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/cc94f101deecbbd4325c287fe6592e76ae1fe6ee

commit cc94f101deecbbd4325c287fe6592e76ae1fe6ee
Author: Dean Liao <deanliao@chromium.org>
Date: Thu Aug 23 17:58:38 2018

Reland "cros/video: use HistogramDiffer to expect histogram change."

This reverts commit 3cdc7663539d8c7f6cf8ada119a012c7e8dfef9d,
which is a reland of 3a26463be800cba6d09559c31c6f90a90796f707.

It adds retry mechanism for histogram_verifier.expect_sole_bucket() as
its replacement target, histogram_verifier.verify(), has retry
mechanism.

Also, adds expect_histogram_grow() with observation peirod.

BUG= chromium:845372 , chromium:875699 
TEST=./histogram_verifier_unittest.py
Run autotest video_ChromeHWDecodeUsed, video_ChromeRTCHWDecodeUsed,
video_ChromeVidResChangeHWDecode, video_MediaRecorderHWEncodeUsed,
and video_MediaRecorderPerf.

Change-Id: Ic15b14234a86fb222a3947c75fb572fdba3c4083
Previous-Reviewed-on: https://chromium-review.googlesource.com/1180792
(cherry picked from commit 4f4af6bd9e3f13196a9c76bb5215efad4ecf6103)
Reviewed-on: https://chromium-review.googlesource.com/1186013
Commit-Queue: Shuo-Peng Liao <deanliao@google.com>
Tested-by: Shuo-Peng Liao <deanliao@google.com>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>

[modify] https://crrev.com/cc94f101deecbbd4325c287fe6592e76ae1fe6ee/client/site_tests/video_ChromeVidResChangeHWDecode/video_ChromeVidResChangeHWDecode.py
[modify] https://crrev.com/cc94f101deecbbd4325c287fe6592e76ae1fe6ee/client/site_tests/video_ChromeHWDecodeUsed/video_ChromeHWDecodeUsed.py
[modify] https://crrev.com/cc94f101deecbbd4325c287fe6592e76ae1fe6ee/client/site_tests/video_MediaRecorderPerf/video_MediaRecorderPerf.py
[modify] https://crrev.com/cc94f101deecbbd4325c287fe6592e76ae1fe6ee/client/cros/video/histogram_verifier_unittest.py
[modify] https://crrev.com/cc94f101deecbbd4325c287fe6592e76ae1fe6ee/client/site_tests/video_MediaRecorderHWEncodeUsed/video_MediaRecorderHWEncodeUsed.py
[modify] https://crrev.com/cc94f101deecbbd4325c287fe6592e76ae1fe6ee/client/cros/video/histogram_verifier.py
[modify] https://crrev.com/cc94f101deecbbd4325c287fe6592e76ae1fe6ee/client/site_tests/video_ChromeRTCHWDecodeUsed/video_ChromeRTCHWDecodeUsed.py
►

Sign in to add a comment