New issue
Advanced search Search tips

Issue 875698 link

Starred by 2 users
Status: Fixed
Owner:
loyso@chromium.org
Closed: Nov 30
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Feature

Blocking:
issue 877898



Sign in to add a comment

Extract BookmarkApps install helpers and components

Project Member Reported by loyso@chromium.org, Aug 20 
Bookmark Apps Off-Extensions (BMO) will need some install components shared with
BookmarkAppHelper and extensions::TabHelper.

- Share IsValidBookmarkAppUrl.

Will need:
- BMO TabHelper.
- a BMO's simplified counterpart for CrxInstaller (ConvertWebAppToExtension). This is a WebApplicationInfo to .png ImageWriter, basically.
- BMO Manifest downloader.
- BMO ImageLoader (icon reader).

Comment 1 by loyso@chromium.org, Aug 20

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20d192c891cda23423cc37dad2936355d9f464d1

commit 20d192c891cda23423cc37dad2936355d9f464d1
Author: Alexey Baskakov <loyso@chromium.org>
Date: Mon Aug 20 07:00:41 2018

WebApp: Implement IsValidWebAppUrl helper.

It will be needed in BMO's TabHelper to start installation.

It is similar to extensions::IsValidBookmarkAppUrl
but:
- Doesn't use extensions/common/url_pattern.h
- Reports chrome-extension:// url scheme as invalid.
- Reports filesystem: and any inner URL schemes as invalid.

Bug:  875698 
Change-Id: I627a8e47593c698ef7acfc286cc310181b095685
Reviewed-on: https://chromium-review.googlesource.com/1180825
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584373}
[modify] https://crrev.com/20d192c891cda23423cc37dad2936355d9f464d1/chrome/browser/web_applications/components/web_app_helpers.cc
[modify] https://crrev.com/20d192c891cda23423cc37dad2936355d9f464d1/chrome/browser/web_applications/components/web_app_helpers.h
[modify] https://crrev.com/20d192c891cda23423cc37dad2936355d9f464d1/chrome/browser/web_applications/components/web_app_helpers_unittest.cc

Comment 3 by loyso@chromium.org, Aug 27

Blocking: 877898
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b40a0872e07ebc242f87e8b286bd9f84748562cd

commit b40a0872e07ebc242f87e8b286bd9f84748562cd
Author: Alexey Baskakov <loyso@chromium.org>
Date: Thu Aug 30 08:16:03 2018

WebApp: Remove BookmarkAppHelper dependency from BookmarkAppDataRetriever.

Remove BookmarkAppHelper and extensions_misc deps from BookmarkAppDataRetriever.

Introduce web_app::IconSize size presets.

Bug:  875698 
Change-Id: I460ef7cf8c2c55f02c9dfabb6fdb888a19883d3c
Reviewed-on: https://chromium-review.googlesource.com/1192465
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587481}
[modify] https://crrev.com/b40a0872e07ebc242f87e8b286bd9f84748562cd/chrome/browser/extensions/bookmark_app_helper.cc
[modify] https://crrev.com/b40a0872e07ebc242f87e8b286bd9f84748562cd/chrome/browser/extensions/bookmark_app_helper.h
[modify] https://crrev.com/b40a0872e07ebc242f87e8b286bd9f84748562cd/chrome/browser/web_applications/components/web_app_icon_generator.h
[modify] https://crrev.com/b40a0872e07ebc242f87e8b286bd9f84748562cd/chrome/browser/web_applications/components/web_app_icon_generator_unittest.cc
[modify] https://crrev.com/b40a0872e07ebc242f87e8b286bd9f84748562cd/chrome/browser/web_applications/extensions/bookmark_app_data_retriever.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f96d7cfc1c26470bc7e1647c9d85ae3eebbf1262

commit f96d7cfc1c26470bc7e1647c9d85ae3eebbf1262
Author: Alexey Baskakov <loyso@chromium.org>
Date: Thu Oct 04 06:39:14 2018

WebApp: Move BookmarkAppDataRetriever to components/

Rename it to WebAppDataRetriever.

Modernize: Use BindOnce.

Bug:  875698 
Change-Id: I4bf74a2966642f606f0ed602bc5bc7d72466e1da
Reviewed-on: https://chromium-review.googlesource.com/c/1256404
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596525}
[modify] https://crrev.com/f96d7cfc1c26470bc7e1647c9d85ae3eebbf1262/chrome/browser/web_applications/components/BUILD.gn
[rename] https://crrev.com/f96d7cfc1c26470bc7e1647c9d85ae3eebbf1262/chrome/browser/web_applications/components/web_app_data_retriever.cc
[rename] https://crrev.com/f96d7cfc1c26470bc7e1647c9d85ae3eebbf1262/chrome/browser/web_applications/components/web_app_data_retriever.h
[rename] https://crrev.com/f96d7cfc1c26470bc7e1647c9d85ae3eebbf1262/chrome/browser/web_applications/components/web_app_data_retriever_unittest.cc
[modify] https://crrev.com/f96d7cfc1c26470bc7e1647c9d85ae3eebbf1262/chrome/browser/web_applications/extensions/BUILD.gn
[modify] https://crrev.com/f96d7cfc1c26470bc7e1647c9d85ae3eebbf1262/chrome/browser/web_applications/extensions/bookmark_app_installation_task.cc
[modify] https://crrev.com/f96d7cfc1c26470bc7e1647c9d85ae3eebbf1262/chrome/browser/web_applications/extensions/bookmark_app_installation_task.h
[modify] https://crrev.com/f96d7cfc1c26470bc7e1647c9d85ae3eebbf1262/chrome/browser/web_applications/extensions/bookmark_app_installation_task_unittest.cc
[modify] https://crrev.com/f96d7cfc1c26470bc7e1647c9d85ae3eebbf1262/chrome/browser/web_applications/extensions/bookmark_app_shortcut_installation_task.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c219339254d92307e0e54865054e5a6c80e989ea

commit c219339254d92307e0e54865054e5a6c80e989ea
Author: Alexey Baskakov <loyso@chromium.org>
Date: Tue Oct 09 04:54:11 2018

WebApp: Minor cleanup.

Remove unused methods and namespace qualifications,
and add missing includes.

GetShortcutPaths is declared in web_app_shortcut_win.h

Bug:  875698 
Change-Id: I540d939d59ea9017a29d4bc464d41ade31ad7328
Reviewed-on: https://chromium-review.googlesource.com/c/1270197
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597800}
[modify] https://crrev.com/c219339254d92307e0e54865054e5a6c80e989ea/chrome/browser/web_applications/components/web_app_data_retriever.cc
[modify] https://crrev.com/c219339254d92307e0e54865054e5a6c80e989ea/chrome/browser/web_applications/extensions/web_app_extension_shortcut.cc
[modify] https://crrev.com/c219339254d92307e0e54865054e5a6c80e989ea/chrome/browser/web_applications/extensions/web_app_extension_shortcut.h
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0460fe2cfe71e639db55261148fec4b041fd2397

commit 0460fe2cfe71e639db55261148fec4b041fd2397
Author: Alexey Baskakov <loyso@chromium.org>
Date: Tue Oct 09 07:15:07 2018

WebApp: Extract const enums into separate header.

LaunchContainer will be a user-defined preference used in Launching.

InstallSource will be used for user-initiated installs as well.

Bug:  875698 
Change-Id: Ifa9762cd551e9ce33b63c3849165e2e2127e6419
Reviewed-on: https://chromium-review.googlesource.com/c/1270208
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597829}
[modify] https://crrev.com/0460fe2cfe71e639db55261148fec4b041fd2397/chrome/browser/chromeos/multidevice_setup/android_sms_app_helper_delegate_impl.cc
[modify] https://crrev.com/0460fe2cfe71e639db55261148fec4b041fd2397/chrome/browser/chromeos/multidevice_setup/android_sms_app_helper_delegate_impl_unittest.cc
[modify] https://crrev.com/0460fe2cfe71e639db55261148fec4b041fd2397/chrome/browser/web_applications/bookmark_apps/external_web_apps.cc
[modify] https://crrev.com/0460fe2cfe71e639db55261148fec4b041fd2397/chrome/browser/web_applications/bookmark_apps/external_web_apps_unittest.cc
[modify] https://crrev.com/0460fe2cfe71e639db55261148fec4b041fd2397/chrome/browser/web_applications/bookmark_apps/policy/web_app_policy_manager.cc
[modify] https://crrev.com/0460fe2cfe71e639db55261148fec4b041fd2397/chrome/browser/web_applications/bookmark_apps/policy/web_app_policy_manager_unittest.cc
[modify] https://crrev.com/0460fe2cfe71e639db55261148fec4b041fd2397/chrome/browser/web_applications/bookmark_apps/system_web_app_manager.cc
[modify] https://crrev.com/0460fe2cfe71e639db55261148fec4b041fd2397/chrome/browser/web_applications/bookmark_apps/system_web_app_manager_unittest.cc
[modify] https://crrev.com/0460fe2cfe71e639db55261148fec4b041fd2397/chrome/browser/web_applications/components/BUILD.gn
[modify] https://crrev.com/0460fe2cfe71e639db55261148fec4b041fd2397/chrome/browser/web_applications/components/pending_app_manager.h
[modify] https://crrev.com/0460fe2cfe71e639db55261148fec4b041fd2397/chrome/browser/web_applications/components/pending_app_manager_unittest.cc
[add] https://crrev.com/0460fe2cfe71e639db55261148fec4b041fd2397/chrome/browser/web_applications/components/web_app_constants.h
[modify] https://crrev.com/0460fe2cfe71e639db55261148fec4b041fd2397/chrome/browser/web_applications/extensions/bookmark_app_installation_task.cc
[modify] https://crrev.com/0460fe2cfe71e639db55261148fec4b041fd2397/chrome/browser/web_applications/extensions/bookmark_app_installation_task_unittest.cc
[modify] https://crrev.com/0460fe2cfe71e639db55261148fec4b041fd2397/chrome/browser/web_applications/extensions/bookmark_app_shortcut_installation_task.cc
[modify] https://crrev.com/0460fe2cfe71e639db55261148fec4b041fd2397/chrome/browser/web_applications/extensions/pending_bookmark_app_manager.cc
[modify] https://crrev.com/0460fe2cfe71e639db55261148fec4b041fd2397/chrome/browser/web_applications/extensions/pending_bookmark_app_manager.h
[modify] https://crrev.com/0460fe2cfe71e639db55261148fec4b041fd2397/chrome/browser/web_applications/extensions/pending_bookmark_app_manager_browsertest.cc
[modify] https://crrev.com/0460fe2cfe71e639db55261148fec4b041fd2397/chrome/browser/web_applications/extensions/pending_bookmark_app_manager_unittest.cc
[modify] https://crrev.com/0460fe2cfe71e639db55261148fec4b041fd2397/chrome/browser/web_applications/extensions/web_app_extension_ids_map.cc
[modify] https://crrev.com/0460fe2cfe71e639db55261148fec4b041fd2397/chrome/browser/web_applications/extensions/web_app_extension_ids_map.h
[modify] https://crrev.com/0460fe2cfe71e639db55261148fec4b041fd2397/chrome/browser/web_applications/extensions/web_app_extension_ids_map_unittest.cc
[modify] https://crrev.com/0460fe2cfe71e639db55261148fec4b041fd2397/chrome/browser/web_applications/web_app_provider.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a5a2cfabf36c1ecc973ab2314f8aef71bb534b3

commit 3a5a2cfabf36c1ecc973ab2314f8aef71bb534b3
Author: Alexey Baskakov <loyso@chromium.org>
Date: Wed Oct 10 02:44:43 2018

WebApp: Rename registrar_ to notification_registrar_

Give way to `unique_ptr<WebAppRegistrar> registrar_`

Bug:  875698 
Change-Id: Ia4b4939c1f1faee04aefc2f0e3c8cd7b146ca34a
Reviewed-on: https://chromium-review.googlesource.com/c/1272736
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598187}
[modify] https://crrev.com/3a5a2cfabf36c1ecc973ab2314f8aef71bb534b3/chrome/browser/web_applications/web_app_provider.cc
[modify] https://crrev.com/3a5a2cfabf36c1ecc973ab2314f8aef71bb534b3/chrome/browser/web_applications/web_app_provider.h
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01493038fc8cf5896f52667656e3aea7a1f5c2d4

commit 01493038fc8cf5896f52667656e3aea7a1f5c2d4
Author: Alexey Baskakov <loyso@chromium.org>
Date: Wed Oct 17 05:04:55 2018

WebApp: Fold BookmarkAppInstallationTask::ResultCode into InstallResultCode.

Merge these two enums.

Move InstallResultCode enum into web_app_constants.h.

kInstallationFailed enumerator entry becomes kFailedUnknownReason.

TBR=jlklein@chromium.org

Bug:  875698 
Change-Id: Ia5c2fb46ae0182edf1c8a3b0215f6905ad70f094
Reviewed-on: https://chromium-review.googlesource.com/c/1285871
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600280}
[modify] https://crrev.com/01493038fc8cf5896f52667656e3aea7a1f5c2d4/chrome/browser/chromeos/multidevice_setup/android_sms_app_helper_delegate_impl.cc
[modify] https://crrev.com/01493038fc8cf5896f52667656e3aea7a1f5c2d4/chrome/browser/web_applications/components/BUILD.gn
[delete] https://crrev.com/d3888464b0adb2e905a60d50041ab2639c47971b/chrome/browser/web_applications/components/install_result_code.h
[modify] https://crrev.com/01493038fc8cf5896f52667656e3aea7a1f5c2d4/chrome/browser/web_applications/components/test_pending_app_manager.cc
[modify] https://crrev.com/01493038fc8cf5896f52667656e3aea7a1f5c2d4/chrome/browser/web_applications/components/web_app_constants.h
[modify] https://crrev.com/01493038fc8cf5896f52667656e3aea7a1f5c2d4/chrome/browser/web_applications/extensions/bookmark_app_installation_task.cc
[modify] https://crrev.com/01493038fc8cf5896f52667656e3aea7a1f5c2d4/chrome/browser/web_applications/extensions/bookmark_app_installation_task.h
[modify] https://crrev.com/01493038fc8cf5896f52667656e3aea7a1f5c2d4/chrome/browser/web_applications/extensions/bookmark_app_installation_task_unittest.cc
[modify] https://crrev.com/01493038fc8cf5896f52667656e3aea7a1f5c2d4/chrome/browser/web_applications/extensions/bookmark_app_shortcut_installation_task.cc
[modify] https://crrev.com/01493038fc8cf5896f52667656e3aea7a1f5c2d4/chrome/browser/web_applications/extensions/pending_bookmark_app_manager.cc
[modify] https://crrev.com/01493038fc8cf5896f52667656e3aea7a1f5c2d4/chrome/browser/web_applications/extensions/pending_bookmark_app_manager_browsertest.cc
[modify] https://crrev.com/01493038fc8cf5896f52667656e3aea7a1f5c2d4/chrome/browser/web_applications/extensions/pending_bookmark_app_manager_unittest.cc
[modify] https://crrev.com/01493038fc8cf5896f52667656e3aea7a1f5c2d4/chrome/browser/web_applications/web_app_install_manager.cc
[modify] https://crrev.com/01493038fc8cf5896f52667656e3aea7a1f5c2d4/chrome/browser/web_applications/web_app_install_manager_unittest.cc
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/094762b741efc797a47d86ea4469f297b54aa38b

commit 094762b741efc797a47d86ea4469f297b54aa38b
Author: Alexey Baskakov <loyso@chromium.org>
Date: Tue Oct 23 07:50:58 2018

HostedApp: Plumb install callback for extensions::TabHelper.

It is not used for now.

Bug:  875698 
Change-Id: I2de44ec120deccebb36a2f031843122963bd13f4
Reviewed-on: https://chromium-review.googlesource.com/c/1295759
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601874}
[modify] https://crrev.com/094762b741efc797a47d86ea4469f297b54aa38b/chrome/browser/extensions/tab_helper.cc
[modify] https://crrev.com/094762b741efc797a47d86ea4469f297b54aa38b/chrome/browser/extensions/tab_helper.h
[modify] https://crrev.com/094762b741efc797a47d86ea4469f297b54aa38b/chrome/browser/web_applications/bookmark_apps/bookmark_app_install_manager.cc
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52646250eb6d5f303676710d1dd44f8cb487d402

commit 52646250eb6d5f303676710d1dd44f8cb487d402
Author: Alexey Baskakov <loyso@chromium.org>
Date: Mon Nov 05 03:04:45 2018

WebApp: Extract UpdateWebAppInfoFromManifest util.

We will reuse it in WebAppInstallManager.

This is a cut-and-paste CL, no behavior change.

Bug:  875698 
Change-Id: If126780727852bb0ce53979b027a01b1c00b58bc
Reviewed-on: https://chromium-review.googlesource.com/c/1314016
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605232}
[modify] https://crrev.com/52646250eb6d5f303676710d1dd44f8cb487d402/chrome/browser/extensions/bookmark_app_helper.cc
[modify] https://crrev.com/52646250eb6d5f303676710d1dd44f8cb487d402/chrome/browser/extensions/bookmark_app_helper.h
[modify] https://crrev.com/52646250eb6d5f303676710d1dd44f8cb487d402/chrome/browser/extensions/bookmark_app_helper_unittest.cc
[modify] https://crrev.com/52646250eb6d5f303676710d1dd44f8cb487d402/chrome/browser/web_applications/components/BUILD.gn
[add] https://crrev.com/52646250eb6d5f303676710d1dd44f8cb487d402/chrome/browser/web_applications/components/web_app_install_utils.cc
[add] https://crrev.com/52646250eb6d5f303676710d1dd44f8cb487d402/chrome/browser/web_applications/components/web_app_install_utils.h
[add] https://crrev.com/52646250eb6d5f303676710d1dd44f8cb487d402/chrome/browser/web_applications/components/web_app_install_utils_unittest.cc
Project Member

Comment 13 by bugdroid1@chromium.org, Nov 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00fad307e5101e01b7c66772acb8d621132b2fa0

commit 00fad307e5101e01b7c66772acb8d621132b2fa0
Author: Alexey Baskakov <loyso@chromium.org>
Date: Tue Nov 13 06:29:02 2018

WebApp: Extract pre- and post- WebAppIconDownloader utils.

We will reuse them in WebAppDataRetriever together with WebAppIconDownloader.

Unify |SizesToGenerate|: it is {32, 64, 48, 96, 128, 256} preset everywhere.
(Matches the old behavior).

Bug:  875698 
Change-Id: Ifa06136294ab5dfefd1785a143268c6a5379a154
Reviewed-on: https://chromium-review.googlesource.com/c/1331101
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607507}
[modify] https://crrev.com/00fad307e5101e01b7c66772acb8d621132b2fa0/chrome/browser/extensions/bookmark_app_helper.cc
[modify] https://crrev.com/00fad307e5101e01b7c66772acb8d621132b2fa0/chrome/browser/web_applications/components/web_app_data_retriever.cc
[modify] https://crrev.com/00fad307e5101e01b7c66772acb8d621132b2fa0/chrome/browser/web_applications/components/web_app_data_retriever_unittest.cc
[modify] https://crrev.com/00fad307e5101e01b7c66772acb8d621132b2fa0/chrome/browser/web_applications/components/web_app_icon_generator.h
[modify] https://crrev.com/00fad307e5101e01b7c66772acb8d621132b2fa0/chrome/browser/web_applications/components/web_app_install_utils.cc
[modify] https://crrev.com/00fad307e5101e01b7c66772acb8d621132b2fa0/chrome/browser/web_applications/components/web_app_install_utils.h

Comment 16 by loyso@chromium.org, Nov 30

Status: Fixed (was: Started)
►

Sign in to add a comment