New issue
Advanced search Search tips

Issue 875670 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 21
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug

Blocking:
issue 873345



Sign in to add a comment

Null-dereference READ in I422AlphaToARGBRow_SSSE3

Project Member Reported by ClusterFuzz, Aug 19

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5457325784301568

Fuzzer: attekett_surku_fuzzer
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  I422AlphaToARGBRow_SSSE3
  libyuv::I420AlphaToARGBMatrix
  I420AlphaToARGB
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=583622:583623

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5457325784301568

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Aug 19

Labels: Test-Predator-Auto-Owner
Owner: mcasas@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/1e53b4ec05f2485450a177c372e38b6215341a1c (GMBVFPool: support I420A VideoFrames).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Almost the same as  crbug.com/875158 
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecd725db6011e2b5a6f8f569e8585c7eb0ab38f2

commit ecd725db6011e2b5a6f8f569e8585c7eb0ab38f2
Author: Miguel Casas <mcasas@chromium.org>
Date: Mon Aug 20 22:10:46 2018

GMBVFPool: bail if VideoFrame format forces change of OutputFormat

ClusterFuzz encountered an issue if a given VideoFrame comes and
causes a change of OutputFormat: in the bug below, an I420 VF
was received after a series of I420A ones, and caused a crash
when the alpha channel was accessed. This might happen more
generally if the received VideoFrames cause a change of
OutputFormat and we access what we don't have.

This CL addresses that by comparing the current |output_format_|
with what is derived out of the incoming VideoFrame. If they
differ, we just bail.

Bug:  875158 ,  875670 
Change-Id: I961b5bf95651a3888482957ee0b7acd48149d467
Reviewed-on: https://chromium-review.googlesource.com/1180543
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584574}
[modify] https://crrev.com/ecd725db6011e2b5a6f8f569e8585c7eb0ab38f2/media/video/gpu_memory_buffer_video_frame_pool.cc
[modify] https://crrev.com/ecd725db6011e2b5a6f8f569e8585c7eb0ab38f2/media/video/gpu_memory_buffer_video_frame_pool_unittest.cc

Project Member

Comment 4 by ClusterFuzz, Aug 21

ClusterFuzz has detected this issue as fixed in range 584573:584574.

Detailed report: https://clusterfuzz.com/testcase?key=5457325784301568

Fuzzer: attekett_surku_fuzzer
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  I422AlphaToARGBRow_SSSE3
  libyuv::I420AlphaToARGBMatrix
  I420AlphaToARGB
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=583622:583623
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=584573:584574

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5457325784301568

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Aug 21

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5457325784301568 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Blocking: 873345

Sign in to add a comment