New issue
Advanced search Search tips

Issue 875668 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner:
Closed: Sep 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Syntax highlighting overridden when editing html attributes

Reported by maurice....@gmail.com, Aug 19

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36

Steps to reproduce the problem:
1. Open devtools -> elements and select an element 
2. Right click and select 'Edit Attribute'
3. Observe text color

What is the expected behavior?
Syntax highlighting should persist

What went wrong?
There are css selectors overriding the syntax highlighting.

Did this work before? Yes m30 something I think. Pretty long time ago. 

Chrome version: 68.0.3440.106  Channel: stable
OS Version: OS X 10.13.6
Flash Version: 

Are there any use cases where overriding the syntax highlighting is benficial? If not, I can fire a PR on devtools-frontend to fix this.
 
Labels: Needs-Triage-M68 Needs-Bisect
Cc: viswa.karala@chromium.org
Labels: Triaged-ET Needs-Feedback
Tested the issue on chrome reported version# 68.0.3440.106, using Mac 10.13.6 with steps mentioned below:
1) Launched chrome reported version and opened Devtools
2) Selected an element, right clicked on it and clicked on 'Edit Attribute'
3) Able to see selected element in highlighted colour

@Reporter: Please find the attached screencast for your reference and provide your inputs on it, if possible could you please provide the screencast of the issue which help in better understanding.

Thanks!
875668.mp4
2.8 MB View Download
The steps are replicated correctly. You'll notice in your screencast that the text color of the attribute in the 'editing' state no longer has syntax hightlighting.

In my screencast, I removed the css properties that override the syntax highlighting.
syntax-highlight-persist.mp4
9.4 MB View Download
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 20

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Needs-Feedback
Tested the issue on chrome reported version# 68.0.3440.106 using Mac 10.13.6 with steps mentioned below:
1) Launched chrome reported version and opened Devtools
2) Selected an element, right clicked on it, clicked on 'Edit Attribute' and observations as shown below:
Observations: As shown in screencast, when right clicked on "class" attribute and clicked on edit attribute, seen only "class" attribute highlighting, in the same way when i right clicked on "issue_text" value, seen only that text highlighted and when right clicked on "=" symbol, then total value "class="issue_text" is highlighted.

@Reporter: Please find the attached screencast for you reference and let us know if you are also pointing the same which i have captured in the screencast and provide your feedback on it.

Thanks!
875668.mp4
2.3 MB View Download
That is an interesting and related observation, but not what I was trying to articulate.

Attached is an example of what an attribute in edit state looks like currently and what I expected. The difference being that the color of the text (the syntax color) persists between the view and edit states

ss-2018-08-21-08-01-08.png
21.9 KB View Download
Project Member

Comment 7 by sheriffbot@chromium.org, Aug 21

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Needs-Bisect -Type-Bug-Regression Target-70 M-70 FoundIn-70 OS-Linux OS-Windows Type-Bug
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on chrome reported version# 68.0.3440.106 and on latest chrome# 70.0.3530.0 using Linux 14.04, Mac 10.12.6 and Windows-10. As this issue is seen from M-60(60.0.3112.0), hence considering this issue as Non-Regression and marking it as Untriaged.

Thanks!
Owner: einbinder@chromium.org
Status: Assigned (was: Untriaged)
Status: WontFix (was: Assigned)
This is a feature request. Based on how the text is processed, its not easy to add syntax highlighting. It is certainly doable, but I don't think its worth the maintenance cost.
>Did this work before? Yes m30 something I think. Pretty long time ago. 

Are you sure?
I don't see it in Chrome 5, 24-36, 44, 50, 60.
The syntax is already highlighted. There are css selectors that are specifically overridding it. 

https://github.com/ChromeDevTools/devtools-frontend/blob/master/front_end/elements/elementsTreeOutline.css#L209

The removal of that.. along with it's respective entry for the dark theme would 'fix' it.

@woxxom - I don't recall the exact milestone. Maybe a blame on the file above would be telling. I started theming devtools in 2013 and I distinctly remember it changing because I could no longer 'unset' the color override. 

Sign in to add a comment