New issue
Advanced search Search tips

Issue 875634 link

Starred by 2 users

Issue metadata

Status: Fixed
Merged: issue 866200
Owner:
Closed: Nov 19
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 866200



Sign in to add a comment

PeerConnections in disconnected states shouldn't prevent suspension

Project Member Reported by hta@chromium.org, Aug 19

Issue description

Code:

https://cs.chromium.org/chromium/src/content/browser/webrtc/webrtc_internals.cc?l=562&rcl=19d33c77a4173b7768bc3f7a3920a744e8b22eed

Original bug report:

 crbug.com/866200 

Reasonable behavior:

Prevent suspension when the user cares that connections stay alive

Unreasonable behavior:

Prevent suspension when there's no connected PeerConnection object

Suggested fix:

Count number of PeerConnections where IceConnectionState is "connected" or "completed" rather than just non-closed PeerConnections. For unconnected PeerConnections, nothing will time out during the suspension; for PeerConnections in "establishing" state, it's just another source of connection failure.


 
Blocking: 866200
Labels: -Pri-3 Pri-2
Status: Available (was: Untriaged)
Owner: guidou@chromium.org
Status: Started (was: Available)
Mergedinto: 866200
Status: Duplicate (was: Started)
Status: Fixed (was: Duplicate)
Fixed by r608905.

Sign in to add a comment